womax/nova
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[test]Speed up fs retry tests by mocking sleep

Browse Source 
Before

Test id                                                                        Runtime (s)
-----------------------------------------------------------------------------  -----------
nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_retry_limit         10.016
nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_retry_limit        10.015
nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_retry                1.010
nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_retry               1.009
nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys                      0.078
nova.tests.unit.test_profiler.TestProfiler.test_all_public_methods_are_traced   0.069
nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys                     0.021
nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_error                0.007
nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_error               0.007

After

Test id                                                                        Runtime (s)
-----------------------------------------------------------------------------  -----------
nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys                     0.081
nova.tests.unit.test_profiler.TestProfiler.test_all_public_methods_are_traced  0.069
nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_error               0.007
nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_retry               0.007
nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_retry_limit         0.007
nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_retry              0.007
nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_retry_limit        0.007
nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys                    0.007
nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_error              0.007

Change-Id: I50b1745bb4bccdc4662440c80c14a04dcf3efa00
Signed-off-by: Balazs Gibizer <gibi@redhat.com>
This commit is contained in:
Balazs Gibizer
2025-07-25 15:06:22 +02:00
parent d699d771b1
commit 8bf3bcccc4
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nova/tests/unit/test_filesystem.py
+6
View File
@@ -14,6 +14,8 @@ import io
import os
from unittest import mock
import fixtures
from nova import exception
from nova import filesystem
from nova import test
@@ -21,6 +23,10 @@ from nova import test
class TestFSCommon(test.NoDBTestCase):
def setUp(self):
super().setUp()
self.useFixture(fixtures.MockPatch("time.sleep", mock.Mock()))
def test_read_sys(self):
open_mock = mock.mock_open(read_data='bar')
with mock.patch('builtins.open', open_mock) as m_open: