From 8bf3bcccc449c413e2e9516fbec85f40d35c970e Mon Sep 17 00:00:00 2001 From: Balazs Gibizer Date: Fri, 25 Jul 2025 15:06:22 +0200 Subject: [PATCH] [test]Speed up fs retry tests by mocking sleep Before Test id Runtime (s) ----------------------------------------------------------------------------- ----------- nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_retry_limit 10.016 nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_retry_limit 10.015 nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_retry 1.010 nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_retry 1.009 nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys 0.078 nova.tests.unit.test_profiler.TestProfiler.test_all_public_methods_are_traced 0.069 nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys 0.021 nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_error 0.007 nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_error 0.007 After Test id Runtime (s) ----------------------------------------------------------------------------- ----------- nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys 0.081 nova.tests.unit.test_profiler.TestProfiler.test_all_public_methods_are_traced 0.069 nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_error 0.007 nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_retry 0.007 nova.tests.unit.test_filesystem.TestFSCommon.test_read_sys_retry_limit 0.007 nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_retry 0.007 nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_retry_limit 0.007 nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys 0.007 nova.tests.unit.test_filesystem.TestFSCommon.test_write_sys_error 0.007 Change-Id: I50b1745bb4bccdc4662440c80c14a04dcf3efa00 Signed-off-by: Balazs Gibizer --- nova/tests/unit/test_filesystem.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/nova/tests/unit/test_filesystem.py b/nova/tests/unit/test_filesystem.py index 5c3107472d..d7f91637a1 100644 --- a/nova/tests/unit/test_filesystem.py +++ b/nova/tests/unit/test_filesystem.py @@ -14,6 +14,8 @@ import io import os from unittest import mock +import fixtures + from nova import exception from nova import filesystem from nova import test @@ -21,6 +23,10 @@ from nova import test class TestFSCommon(test.NoDBTestCase): + def setUp(self): + super().setUp() + self.useFixture(fixtures.MockPatch("time.sleep", mock.Mock())) + def test_read_sys(self): open_mock = mock.mock_open(read_data='bar') with mock.patch('builtins.open', open_mock) as m_open: