We use MD5 for checksum, add this description
in cli helps.
Change-Id: I3469b0dface63f4684ad39421eee4c2a2de4d80b
Signed-off-by: Chen Hanxiao <chenhx@certusnet.com.cn>
With PEP 479, the behaviour of StopIteration is changing. Raising it to
stop a generator is considered incorrect and from Python 3.7 this will
cause a RuntimeError. The PEP recommends using the return statement.
More details: https://www.python.org/dev/peps/pep-0479/#examples-of-breakage
Change-Id: Ia067940066a5666926dcf61136b03d721a87666e
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I8a41be18dac0fc3199ee5fa691a4ab48fae66849
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Under python 3 with ordering randomized we cannot depend on the JSON
output matching exactly. Instead we de-serialize the data structure
that was written and compare the structures, which will always match.
Change-Id: I134b62413a7cde25f3efda6a2452c1e3d11d41d0
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
The glanceclient-dsvm-functional-identity-v3-only job is exactly
like the glanceclient-dsvm-functional job, except that it sets
the devstack config option ENABLE_IDENTITY_V2 to False. Change
I5afcba6321f496b8170be27789bee7c9ad8eacce in devstack makes False
the default value for this option, so we already have a voting gate
job that uses identity v3. This patch removes the redundant
non-voting identity-v3-only job.
Change-Id: I5d5550c06b179810d25a472cc423403daed43776
When the TC merged I2637dd714cbb6d38ef8b8dc1083e359207118284 we're
supposed to invoke stestr rather than testr so lets do that
Change-Id: I1b401c583d5e7677fc719bfc4eb2f2bba7b98cfa
Currently, when the virtual size of an image is not known, "None" is displayed.
To a regular user, it feels like a programming error. We try and make things
clearer by using a "human readable" string instead.
Change-Id: Id7b8799356857d9bc58cc8a3677024fe1a7f4f56
Partial-Bug: #1665037
Add jobs to the periodic queue that run the glanceclient unit tests
against the master of various libraries we consume so that we don't
have to wait for a release to detect a change that could be
problematic.
Change-Id: If4090462449b4c5340754490aa8f4116d5608e34
According to RFC 8187, HTTP headers should use 7-bit ASCII encoding.
The glanceclient was encoding them as UTF-8, which can leave the 8th
bit nonzero when representing unicode, and which presents problems
for any recipient following the standard and decoding the headers as
ASCII.
This change requires keystoneauth1 3.6.2, which has a fix for a
bug that made it unable to handle bytes in headers. The dependency
is a patch bumping the keystoneauth1 version in upper-constraints.
Depends-on: https://review.openstack.org/#/c/569138/
Change-Id: I0d14974126fcb20e23a37347f4f1756c323cf2f5
Closes-bug: #1766235
The list of useful image properties really belongs in the Glance
Administration Guide. The only connection they have with the
glanceclient is that you can use it to set them. Rewrite the
property keys document to reflect this. The dependency moves the
relevant text to the Glance Admin Guide.
Depends-on: https://review.openstack.org/565780
Change-Id: I39add6728aad42988a07d2ad97cd81dbdaf4c54a
Update the local copy of the image schema to reflect Image API 2.6.
Change-Id: Ib0e56027927880d0fa198ffd8ea4b57e39f9d0fe
Closes-bug: #1762044
Depends-on: https://review.openstack.org/#/c/559501/
Add checks to image-import command so that it provides better user
feedback in failure situations.
Change-Id: I8b6b32c3d1d1a745aa68ff8dc629419dff9bb130
Closes-bug: #1758718
Add checks to the image-create-via-import commmand so that it provides
better user feedback and doesn't begin the import workflow unless the
input has a chance of succeeding. Preserves backward compatibility
with the current image-create command by (1) allowing an image record
only to be created when no import-method is specified AND no data is
supplied, and (2) doing the glance-direct workflow when no import-
method is specified AND data is provided. Also adds the ability for
the import-method to be set as an env var OS_IMAGE_IMPORT_METHOD.
Change-Id: I0a225f5471a9311217b5d90ebb5fd415c369129a
Closes-bug: #1758149
The do_image_download code has a check to make sure that there's
a place to put the data (either filename or stdout redirect) before
initiating the download. The location of this check was moved by
change I841bebeda38814235079429eca0b1e5fd2f04dae to happen at the
beginning of the function. The two intermittently failing tests
do not explicitly address the check condition, and as a result the
tests do exit early, but before they can check what they're supposed
to be testing.
Closes-bug: #1759951
Change-Id: I3c85bb358f669504b364d55618c21382b7a2a66b
Prepare for the Image API v1 to be removed from glance during Rocky
by splitting the functional tests that hit v1 from the tests that hit
v2. Introduce a new job that runs the functional-v1 tests against a
devstack running glance stable/queens, and configure this job for both
check and gate for the glanceclient. The v2 functional tests
continue to be run for both check and gate against a devstack running
glance master.
Change-Id: Ifa98ada26a84e4cca3ea8c98173f61a6174cca27
Fail image-create-via-import requests for the web-download import
method that don't include values for container_format or disk_format.
Closes-bug: #1757927
Change-Id: Ic5c81916823ff32f2dbddd32b40e825de0697dc9
Help text for some image properties (architecture, os_distro) is
pulled from the glanceclient's local version of the image schema.
The URL for those property definitions has gotten out of sync with
Glance. This patch updates the URL to be the same as that given
in the Glance image-schema response.
Change-Id: I4e46e78525fe5c00e031a98c47cacc17e5693d53
Closes-bug: #1757918
This change adds support for 'web-download' import method
to 'image-import' and 'create-image-via-import' call.
To use this 'web-download' import method, user needs to pass
--uri option 'a valid uri to external image to import in glance'
to 'image-import' and 'create-image-via-imaport' calls.
Co-authored-by: Pranali Deore <pdeore@redhat.com>
Co-authored-by: Erno Kuvaja <jokke@usr.fi>
Change-Id: I0e1d18844f64723608288de473e97710798eb602
Zuul