Artom Lifshitz
751c2e8b8b
The typo'ed spelling is only used in _strip_additional_query_parameters(), which is as the name implies, removes from the request any keys that are not present in the schema. The nuance is that this happens only _after_ calling the _schema_validation_helper() (which actually validates the request against the schema), and _only_ if the validation succeeds. So while yes, _strip_additional_query_parameters() erroneously tried to find 'addtionalProperties' in the schema, never found it, always defaulted to True, and proceed to unconditionally strip any keys not found in the schema, this was never a problem: the validation had already been done, and if additionalProperties was False, the validation correctly failed if extra keys were present. Which means that if the code flow ever got to _strip_additional_query_parameters() _with_ extra keys present in the request, it means additionalProperties was True anyways, and it made no material difference. And I hate that I spent over an hour trying to understand why this typo makes no difference in unit tests of behaviour. Change-Id: I1ba5b9fa2ec5e4021543021068625d61ee671cdb
==============
OpenStack Nova
==============
.. image:: https://governance.openstack.org/tc/badges/nova.svg
:target: https://governance.openstack.org/tc/reference/tags/index.html
.. Change things from this point on
OpenStack Nova provides a cloud computing fabric controller, supporting a wide
variety of compute technologies, including: libvirt (KVM, Xen, LXC and more),
VMware and OpenStack Ironic.
Use the following resources to learn more.
API
---
To learn how to use Nova's API, consult the documentation available online at:
- `Compute API Guide <https://docs.openstack.org/api-guide/compute/>`__
- `Compute API Reference <https://docs.openstack.org/api-ref/compute/>`__
For more information on OpenStack APIs, SDKs and CLIs in general, refer to:
- `OpenStack for App Developers <https://www.openstack.org/appdev/>`__
- `Development resources for OpenStack clouds
<https://developer.openstack.org/>`__
Operators
---------
To learn how to deploy and configure OpenStack Nova, consult the documentation
available online at:
- `OpenStack Nova <https://docs.openstack.org/nova/>`__
In the unfortunate event that bugs are discovered, they should be reported to
the appropriate bug tracker. If you obtained the software from a 3rd party
operating system vendor, it is often wise to use their own bug tracker for
reporting problems. In all other cases use the master OpenStack bug tracker,
available at:
- `Bug Tracker <https://bugs.launchpad.net/nova>`__
Developers
----------
For information on how to contribute to Nova, please see the contents of the
CONTRIBUTING.rst.
Any new code must follow the development guidelines detailed in the HACKING.rst
file, and pass all unit tests.
Further developer focused documentation is available at:
- `Official Nova Documentation <https://docs.openstack.org/nova/>`__
- `Official Client Documentation
<https://docs.openstack.org/python-novaclient/>`__
Other Information
-----------------
During each `Summit`_ and `Project Team Gathering`_, we agree on what the whole
community wants to focus on for the upcoming release. The plans for nova can
be found at:
- `Nova Specs <http://specs.openstack.org/openstack/nova-specs/>`__
.. _Summit: https://www.openstack.org/summit/
.. _Project Team Gathering: https://www.openstack.org/ptg/