Matt Riedemann
5657dc5006
'networks' in the server request body is a list of dicts that can take a fixed_ip, port id or network id. There are semantic rules for the combinations of these which are checked in the helper method _get_requested_networks. The network id validation logic is a bit convoluted where it's placed though, so this change cleans that up and moves it to it's own method. Note the main difference in nesting logic. You can't request a port and network on the same nic (dict entry in the networks list). So the conditional logic is such that you either have a port or a network in a single request. Before this change, the network id validation was happening outside that conditional, and checked a second time if port was requested before validating the network id. Since we already have that condition, this change moves the network id validation under the condition where a port is not requested (so a network id must be). There are no test changes since this is just cleaning up the code and also shows that this doesn't change the overall results of the validation. Change-Id: I466f2273a4ce02279b942f7ada264a3da97dfe92
OpenStack Nova README ===================== OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of virtualization technologies, including KVM, Xen, LXC, VMware, and more. In addition to its native API, it includes compatibility with the commonly encountered Amazon EC2 and S3 APIs. OpenStack Nova is distributed under the terms of the Apache License, Version 2.0. The full terms and conditions of this license are detailed in the LICENSE file. Nova primarily consists of a set of Python daemons, though it requires and integrates with a number of native system components for databases, messaging and virtualization capabilities. To keep updated with new developments in the OpenStack project follow `@openstack <http://twitter.com/openstack>`_ on Twitter. To learn how to deploy OpenStack Nova, consult the documentation available online at: http://docs.openstack.org For information about the different compute (hypervisor) drivers supported by Nova, read this page on the wiki: https://wiki.openstack.org/wiki/HypervisorSupportMatrix In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at: http://bugs.launchpad.net/nova Developers wishing to work on the OpenStack Nova project should always base their work on the latest Nova code, available from the master GIT repository at: https://git.openstack.org/cgit/openstack/nova Developers should also join the discussion on the mailing list, at: http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests. Further developer focused documentation is available at: http://docs.openstack.org/developer/nova/ For information on how to contribute to Nova, please see the contents of the CONTRIBUTING.rst file. -- End of broadcast