Balazs Gibizer
081130d329
There were libvirt disk attach / detach unit test cases that mocked threading.Event.wait to speed up the test execution as the libvirt event based device detach has a 20 seconds timeout. However this mock is very wide. It effects all the threading.Event usage during the test case. As we are switched to the native threaded backed of oslo.service we got an LoopingCall implementation that relies on threading.Event to signal when the call is finished. In these test cases the wide mock broke this logic and the LoopingCall signalled "done" while the actual call in the background was still running making that call leaking out from the test case and therefore under the fixtures the test case tore down after the test case finished. This caused that later the call hit non mocked code paths like importing the real libvirt lib instead of using our libvirt fixture causing late failures. The fix is to remove the wide mock and instead change the detach timeout in these test cases. Later follow ups will check put protection in place to avoid re-introducing this wide mock. Closes-Bug: #2136815 Change-Id: I3f40d9dad6ef87e6fa4db0ea4065a77421e8c271 Signed-off-by: Balazs Gibizer <gibi@redhat.com>
============== OpenStack Nova ============== OpenStack Nova provides a cloud computing fabric controller, supporting a wide variety of compute technologies, including: libvirt (KVM, Xen, LXC and more), VMware and OpenStack Ironic. Use the following resources to learn more. API --- To learn how to use Nova's API, consult the documentation available online at: - `Compute API Guide <https://docs.openstack.org/api-guide/compute/>`__ - `Compute API Reference <https://docs.openstack.org/api-ref/compute/>`__ For more information on OpenStack APIs, SDKs and CLIs in general, refer to: - `OpenStack for App Developers <https://www.openstack.org/appdev/>`__ - `Development resources for OpenStack clouds <https://developer.openstack.org/>`__ Operators --------- To learn how to deploy and configure OpenStack Nova, consult the documentation available online at: - `OpenStack Nova <https://docs.openstack.org/nova/>`__ In the unfortunate event that bugs are discovered, they should be reported to the appropriate bug tracker. If you obtained the software from a 3rd party operating system vendor, it is often wise to use their own bug tracker for reporting problems. In all other cases use the master OpenStack bug tracker, available at: - `Bug Tracker <https://bugs.launchpad.net/nova>`__ Developers ---------- For information on how to contribute to Nova, please see the contents of the CONTRIBUTING.rst. Any new code must follow the development guidelines detailed in the HACKING.rst file, and pass all unit tests. To understand better the processes that the team is using, please refer to the `Process document <https://docs.openstack.org/nova/latest/contributor/process.html>`__. Further developer focused documentation is available at: - `Official Nova Documentation <https://docs.openstack.org/nova/>`__ - `Official Client Documentation <https://docs.openstack.org/python-novaclient/>`__ Other Information ----------------- During each `Summit`_ and `Project Team Gathering`_, we agree on what the whole community wants to focus on for the upcoming release. The plans for nova can be found at: - `Nova Specs <http://specs.openstack.org/openstack/nova-specs/>`__ .. _Summit: https://www.openstack.org/summit/ .. _Project Team Gathering: https://www.openstack.org/ptg/