Move another generally useful utility method out of nova-net to
somewhere more generic.
Change-Id: I1bf7afecd2e8122492dcb2c21b26e5b72919e6b5
blueprint: remove-nova-network
Currently only _proxy_as_attr fields are available as attributes, and
they are not available as dict values. Other values are available as
both. This is inconsistent. This change ensures all fields are exposed
as both dict values and attributes, so the caller doesn't have to
remember which type of attribute they're accessing.
Part of bp local-disk-serial-numbers
Change-Id: I35ebff9a06617aa58e612919eba81e8eea21f6a3
Change I751fcb7532679905c4279744919c6cce84a11eb4 modified
the ComputeDriver.detach_volume method signature to pass
the RequestContext as the first argument. This was missed
in the volume attach rollback code where the driver.detach_volume
method is called. It was missed because that is called
in a try/except block which catches generic Exception, which
also means that the unit test covering that flow, which
raised an Exception, was not failing.
This change fixes the code bug and re-writes the test to
use mock rather than mox and explicitly assert the calls made.
An alternative to this would be changing the generic
Exception handling in the rollback code, however, the
virt drivers raise things other than NovaException, like
os-brick exceptions and libvirtError, so refactoring that
error handling is non-trivial.
Change-Id: I9bafd4c47489b61973302310720b11ec1b5e0374
Closes-Bug: #1765742
- as per the bug #1704129, the plug/unplug is moved to a
separate os-vif plugin
- IVS's methods have also been moved to a separate package
called os-vif-bigswitch [1]
- hence removing all dangling calls from here
[1] https://github.com/bigswitch/os-vif-bigswitch
Partial-Bug: #1704129
Change-Id: Icf948f6ee1c0da2327fb5eac61fec6e89ac30531
* Function documentation of member_of param is fixed in multiple places
* Defaulting member_of to None instead of empty string to use a value
that the caller documented to expect
* Fixing placement db test case that still used a single UUID list as
member_of
Change-Id: I9b7184f8f8b1e621df61b5652956707345be2ab0
We were using `warning`, and `important` themes to mark deprecations in
various places. We have a `deprecated` role, so this change switches to
use it.
Note that I also found the following files that mentioned deprecation,
but not in a way where using this role seemed appropriate. I'm
recording them here so you know I considered them.
doc/source/admin/configuration/hypervisor-kvm.rst
doc/source/admin/configuration/schedulers.rst
doc/source/cli/index.rst
doc/source/cli/nova-rootwrap.rst
doc/source/contributor/api.rst
doc/source/contributor/code-review.rst
doc/source/contributor/policies.rst
doc/source/contributor/project-scope.rst
doc/source/reference/policy-enforcement.rst
doc/source/reference/stable-api.rst
doc/source/user/feature-classification.rst
doc/source/user/flavors.rst
doc/source/user/upgrade.rst
Change-Id: Icd7613d9886cfe0775372c817e5f3d07d8fb553d
A recent'ish change in openstack-manuals [1] noted the new support for
NUMA topologies when using the Hyper-V driver. As part of this change, a
section was added that describes the configuration steps that were
necessary on Hyper-V hosts before booting instances. However, the way
this section is integrated gives the impression that NUMA support is a
Hyper-V only feature.
Correct this by moving this configuration step to the end of the
document and instead opting to link to it from higher in the doc.
[1] https://review.openstack.org/#/c/424102/
Change-Id: Ic8d9c1b35d52a26374763b5c0e4be79875814569
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This patch deletes a duplicative test and enhance it to validate a
case where a compute node's local disk is not enough while there
is a shared storage with enough disk.
This case has been already fixed thanks to new _exceeds_capacity
function from commit 9af073384c.
Change-Id: Ia544dc529c844f7bee5b04f90456fd66a20ecdd0
Related-Bug: #1769854
In a new microversion, the GET /allocation_candidates API now accepts
granular resource request syntax:
?resourcesN=...&requiredN=...&member_ofN=...&group_policy={isolate|none}
Change-Id: I4e99974443aa513fd9f837a6057f67d744caf1b4
blueprint: granular-resource-requests
The following methods in nova/compute/utils.py
have not been used since
I9269ffa2b80e48db96c622d0dc0817738854f602.
* reverse_upsize_quota_delta
* downsize_quota_delta
In addition, remove an unused argument of
the 'upsize_quota_delta' method in the file.
Change-Id: Ia8eed927e3946ee8d7c90f6aead2883728772aca
Replace mox with mock or stub_out in the following class
in nova/tests/unit/virt/xenapi/test_xenapi.py.
* XenAPIVMTestCase
Subsequent patches will remove mox in other test methods
in the file.
Change-Id: Ie0fc1c66088c4665bc16b46e5eedba33af89a966
Implements: blueprint mox-removal
This defines the nova-live-migration job, based on the
tempest-dsvm-multinode-live-migration job from openstack-zuul-jobs.
The branch override parts of the job definition are removed since
the job will be defined per-branch now.
Change-Id: Idea86d6bb648b1e6fef8813dbe569724ce81a750
We don't need to log every single sync event, this can get
pretty spammy, especially when you have computes in the hundreds.
Change-Id: I958005b6a3e2b90ca6fe6046e4dbcc5991581245
Michael Still