The Instance.get_by_uuid method takes an expected_attrs
kwarg which needs to be a list or tuple, not just any old
iterable like a string. Because of how the underlying
Instance object code massages this value, it's not a hard
failure but does mean you don't join the columns you expect
when getting the instance.
This makes it a list and makes sure the stub in the unit
tests is checking for valid values.
Change-Id: I3ad85f9062b5cb19962d9e6a7af52440166def45
Closes-Bug: #1645479
An attempt to create an instance with the deleted flag set will
not work as intended, especially from instance.create(), which
can't properly pass the yet-to-be-determined deleted=id protocol.
This makes Instance.create() throw an error like the one for
being already created, and fixes the one test where we depend
on this working.
Change-Id: I60d18ca694a2eb7f333c0cf2a898cf8f17eb83dd
Closes-Bug: #1644513
We should already have the rehydrated instance having the deleted field being
set. That field is also a BooleanField type, so we should never try to cast it
from an integer (even if we support it). Instead, we need to make sure that if
the field is not set for any reason (mostly because an Instance wasn't persisted
before we persisted the BuildRequest object that was nesting it), then we would
default the deleted field to False.
Change-Id: I828191f750a5978fed65a86e797388d11042b4a0
Related-Bug: #1644513
During a live migration process we reserve serial ports on
destination host and update domain XML during migration to
use the new reserved ports from destination.
If the migration succeeds we release ports on the source host.
If the migration fails we release reserved ports on the
destination host.
Co-Authored-By: Sahid Ferdjaoui <sahid.ferdjaoui@redhat.com>
Change-Id: Ie2524191d22cca2287eb7dbaa22b74d43e43c896
Closes-Bug: #1455252
This extends the work done in libvirt-virtio-net-multiqueue bp to
allow for enabling multiqueue mode for vrouter VIFs (OpenContrail).
In case of vrouter mechanism is slightly different and a tap device
created by nova-compute must already be in the multiqueue mode,
when it's passed to vrouter.
Implements blueprint vif-vrouter-multiqueue
Co-Authored-By: Michal Dubiel <md@semihalf.com>
Change-Id: I7b20650c8a772fdaa05707e0dfe27ad32481a2d3
This commit adds additional help text to interval_opts and
instance_cleaning_opts. It also adds the 'min' param to IntOpts
where applicable.
Blueprint centralize-config-options-ocata
Change-Id: Id052419d5c2b52c5a3ec457afbb32ab150f813cb
This is useful for e.g. enabling multiqueue support for vrouter: tap
devices created by Nova and then passed to libvirt must have
multiqueue enabled.
Implements blueprint vif-vrouter-multiqueue
Co-Authored-By: Michal Dubiel <md@semihalf.com>
Change-Id: I7170bf7c181b038bb3d70a3b86c87ee254d10efc
Jenkins