Commit Graph

57905 Commits

Author SHA1 Message Date
Lee Yarwood f357d80407 zuul: Introduce nova-evacuate
This change reworks the evacuation parts of the original
nova-live-migration job into a zuulv3 native ansible role and initial
job covering local ephemeral and iSCSI/LVM volume attached instance
evacuation. Future jobs will cover ceph and other storage backends.

Change-Id: I380e9ca1e6a84da2b2ae577fb48781bf5c740e23
2020-09-23 16:47:47 +01:00
Zuul 167472c9ac Merge "test_evacuate.sh: Stop using libvirt-bin" 2020-09-23 12:51:39 +00:00
Zuul e1842ee739 Merge "Test for disabling greendns" 2020-09-23 11:33:53 +00:00
Zuul 5441a76b0e Merge "docs: fix aggregate weight multiplier property names" 2020-09-22 15:27:51 +00:00
Zuul 3986c5c35c Merge "doc: correct the link to user/flavor.rst" 2020-09-22 15:22:24 +00:00
Zuul ed5de21dd8 Merge "doc: Fix rendering in the accelerator support doc" 2020-09-22 15:11:43 +00:00
Artom Lifshitz 6f35e4fd2a Test for disabling greendns
In commit 7c1d964faa we fixed how we disable greendns. This patch adds
a test for this. It also lays down the groundwork for future tests
of how we manage eventlet's monkeypatching.

How and what eventlet monkeypatches can be controlled by environment
variables that are processed by eventlet at import-time (for exmaple,
EVENTLET_NO_GREENDNS). Nova manages all of this in nova.monkey_patch.
Therefore, nova.monkey_patch must be the first thing to import
eventlet. As nova.tests.functional.__init__ imports nova.monkey_patch,
our new test can go in the functional tree.

Related-bug: 1895322
Change-Id: I5b6c45b7b9a9eca3c13ecfaa5f50942922b69270
2020-09-22 10:56:42 -04:00
Lee Yarwood 5ab9b28161 test_evacuate.sh: Stop using libvirt-bin
I49dc963ada17a595232d3eb329d94632d07b874b missed that
call_hook_if_defined will actually cause the entire run to fail [1] if
we attempt to stop the non-existent libvirt-bin service so just remove
it now we are using the train UCA.

[1] https://opendev.org/openstack/devstack-gate/src/commit/7a70f559c559e22b498d735b4ed20aadc71b7f39/functions.sh#L74

Change-Id: Ife26f1ceb6208e12328ccdccbab0681ee55d5a2a
2020-09-22 10:29:37 +01:00
Zuul b5330a97ae Merge "test_evacuate.sh: Support libvirt-bin and libvirtd systemd services" 2020-09-18 23:03:01 +00:00
Zuul e3acb21641 Merge "test_evacuate: Wait until subnode is down before starting tests" 2020-09-18 17:03:15 +00:00
Zuul 0a2403acd9 Merge "releasenote: Add known issue for bug #1894804" 2020-09-18 13:22:18 +00:00
Lee Yarwood 6c62830ae8 test_evacuate.sh: Support libvirt-bin and libvirtd systemd services
The systemd service unit for libvirtd has changed name from libvirt-bin
to libvirtd, as such the evacuation test script needs to be changed to
support both as we move between these versions.

Change-Id: I49dc963ada17a595232d3eb329d94632d07b874b
2020-09-18 13:45:39 +01:00
Zuul c49cd3b966 Merge "Victoria 22.0.0 prelude section" 2020-09-18 10:03:41 +00:00
Lee Yarwood 57ac83d4d7 releasenote: Add known issue for bug #1894804
Related-Bug: #1882521
Change-Id: Ib9059dde41b0a07144ffa26552577308b1ffc9e1
2020-09-18 10:45:43 +01:00
Takashi Natsume e3cfcb0b37 doc: Fix rendering in the accelerator support doc
Fix list rendering in the accelerator support document.

Change-Id: Ic58c5604b2e63daab7a30a95ad6a3481d96f6f63
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
2020-09-18 09:03:15 +00:00
Wang Huaqiang db7f263406 doc: correct the link to user/flavor.rst
In commit a76277f81a, the introduction
of flavor extra specs, such as 'hw:cpu_policy', 'hw:cpu_thread_policy'
and ... , have been moved to 'doc/source/user/flavors.rst' from
'doc/source/admin/flavors.rst', while in 'cpu-topologiest.rst' this
change hasn't been updated. Apply this change.

Change-Id: I031a5ea6de00a8c5cf67897ddb78075c8bc79c0b
Signed-off-by: Wang Huaqiang <huaqiang.wang@intel.com>
2020-09-18 09:02:58 +00:00
Lee Yarwood 75250d6b17 fakelibvirt: Use versionutils to set min versions found in the driver
These were previously manually converted ints based on the version
tuples present in the driver. To avoid ever needing to worry about these
again this change simply uses versionutils to covert the tuples found in
the driver into ints used by fakelibvirt.

Change-Id: I864494e11ff697788167c996a39f38d3d833d0d7
2020-09-17 21:21:28 +01:00
Zuul 9fa563666e Merge "compute: Skip cinder_encryption_key_id check when booting from volume" 2020-09-17 19:59:43 +00:00
Zuul 2f18450adc Merge "Add regression test for bug #1895696" 2020-09-17 19:00:27 +00:00
Zuul 8a33066b25 Merge "api: Set min, maxItems for server_group.policies field" 2020-09-17 19:00:20 +00:00
Sylvain Bauza 09204e6616 Victoria 22.0.0 prelude section
Mostly based on cycle highlights and a couple of additions worth
mentioning.

Change-Id: I3587f7d89f8ab164a5569601d9fd237c2c031886
2020-09-17 15:33:12 +02:00
Zuul f47bde539c Merge "tests: Remove '_FakeImageService'" 2020-09-17 12:46:35 +00:00
Lee Yarwood f9b67893ac compute: Skip cinder_encryption_key_id check when booting from volume
Idf84ccff254d26fa13473fe9741ddac21cbcf321 added this check in order for
Nova to avoid booting encrypted images created by Cinder as there is
currently no support for using such images (rotating keys etc).

The check however missed the slightly convoluted use case where this
image property is found against a volume after the volume in question is
created using an encrypted image created by cinder from an encrypted
volume. In other words:

- Cinder creates an encrypted volume A
- Glance creates an encrypted image A from volume A
- Cinder creates an encrypted volume B from image A
- Nova attempts to boot an instance using volume B

Note that Nova may request the creation of volume B or a user could also
do this directly through Cinder.

As such this change simply ensures that the instance isn't booting from
a volume when preforming the check as it is only valid when booting from
an image.

Closes-Bug: #1895696
Change-Id: Ic92cab7362fa25050e5bbef5c3e360108365b5c7
2020-09-17 12:16:54 +01:00
Lee Yarwood e76cccddd3 Add regression test for bug #1895696
Related-Bug: #1895696
Change-Id: I15271fb0b8de7f1184acddd607d605837e2eb7d4
2020-09-17 12:16:44 +01:00
Zuul cf26d18631 Merge "Fix error that cannot overwrite policy rule for 'forced_host'" 2020-09-16 21:49:20 +00:00
Zuul 77e24cc6e7 Merge "tests: Add regression test for bug 1894966" 2020-09-16 19:07:21 +00:00
Zuul b262e23734 Merge "functional: Add and use 'GlanceFixture'" 2020-09-16 17:10:21 +00:00
Zuul d42909a9e5 Merge "functional: Enable real policy fixture by default" 2020-09-16 17:10:12 +00:00
Stephen Finucane 2a7f1f986e docs: Improve 'AggregateImagePropertiesIsolation' docs
When we introduced the 'ImageMetaProps' o.vo in Liberty, we lost the
ability to consume arbitrary metadata configured for images. This
affects users of the 'AggregateImagePropertiesIsolation' filter, who may
have set such arbitrary metadata and expected their instances to be
restricted to host aggregates matching that metadata.

The world has changed a lot since Liberty was released, and it's
probably too late and maybe even a little unwise to let that genie back
out of its bottle, however, we can and should probably do a better job
of warning people of this change in behavior in our documentation. Do
just this.

Change-Id: If7245a90711bd2ea13095ba26b9bc82ea3e17202
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Related-Bug: #1741810
2020-09-16 14:27:51 +01:00
Stephen Finucane 19ef3655b1 tests: Remove '_FakeImageService'
Migrate unit tests over to the new GlanceFixture, allowing us to fully
delete '_FakeImageService' and various helpers.

Change-Id: I3e3d9bbd32aa2fe0777681f21ba827610d5b3040
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2020-09-16 11:31:23 +01:00
Stephen Finucane cc45581a18 functional: Add and use 'GlanceFixture'
This rather beefy (but also quite simple) patch replaces the
'stub_out_image_service' call and associated cleanup in all functional
tests with a new 'GlanceFixture', based on the old 'FakeImageService'.
The use of a fixture means we don't have to worry about teardown and
allows us to stub Glance in the same manners as Cinder, Neutron,
Placement etc.

Unit test cleanup is handled in a later patch.

Change-Id: I6daea47988181dfa6dde3d9c42004c0ecf6ae87a
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2020-09-16 11:31:23 +01:00
Stephen Finucane 8750c4e173 functional: Enable real policy fixture by default
Enable the policy fixture by default, which should yield more realistic
functional tests. We need to update some tests to use admin APIs where
policy dictates they are necessary. Note that we're currently testing
the legacy policy - not the updated, scoped policy - since the legacy
policy is the default one currently.

Note that we also need to modify the 'SingleCellSimple' fixture in this
change to use the same project ID as the 'OSAPIFixture'.

Change-Id: Ia3dea78f16cb3c7081714c4db36e20d5ee76ed7d
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2020-09-16 11:31:23 +01:00
Stephen Finucane 32c43fc801 api: Set min, maxItems for server_group.policies field
As noted inline, the 'policies' field may be a list but it expects one
of two items.

Change-Id: I34c68df1e6330dab1524aa0abec733610211a407
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-Bug: #1894966
2020-09-16 11:13:47 +01:00
Stephen Finucane 2c66962c7a tests: Add regression test for bug 1894966
You must specify the 'policies' field. Currently, not doing so will
result in a HTTP 500 error code. This should be a 4xx error. Add a test
to demonstrate the bug before we provide a fix.

Change-Id: I72e85855f621d3a51cd58d14247abd302dcd958b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Related-Bug: #1894966
2020-09-16 11:13:45 +01:00
Zuul f72c9e59fb Merge "Allow tap interface with multiqueue" 2020-09-16 09:56:29 +00:00
Lee Yarwood 9d55b754f2 test_evacuate: Wait until subnode is down before starting tests
Change-Id: I714eb2ef3a6d307b60d82e7fedc49bfeadd20289
2020-09-15 08:48:06 +00:00
Zuul e0f088c95d Merge "functional: Add test for SR-IOV neutron ports" 2020-09-14 19:32:06 +00:00
Zuul 6414afd0ef Merge "conductor: Don't use setattr" 2020-09-14 19:31:58 +00:00
Zuul 30530f5ba7 Merge "Remove write_to_file." 2020-09-14 19:31:52 +00:00
Zuul c710a3f1e3 Merge "Run voting jobs in gate pipeline also" 2020-09-14 18:12:08 +00:00
Stephen Finucane 17ba10b759 functional: Add test for SR-IOV neutron ports
Add a simple test to demonstrate the interaction between nova and
neutron when creating an instance with a (pre-created) SR-IOV port.

Change-Id: I9d0596f31ca342b952c35c742befd75fdc39d95c
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2020-09-14 16:47:17 +01:00
Stephen Finucane cc8b300f67 conductor: Don't use setattr
setattr kills discoverability, making it hard to figure out who's
setting various fields. Don't do it.

While we're here, we drop legacy compat handlers for pre-Train
compute nodes.

Change-Id: Ie694a80e89f99c8d3e326eebb4590d93c0ebf671
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
2020-09-14 16:47:15 +01:00
Zuul 18bae88fd8 Merge "doc: mark the max microversion for victoria" 2020-09-14 12:14:08 +00:00
Zuul 3f54f5033b Merge "Update compute rpc version alias for victoria" 2020-09-14 12:14:01 +00:00
Zuul 76b2fbd90e Merge "Fix invalid assert_has_calls" 2020-09-14 10:29:43 +00:00
Zuul 90777d790d Merge "trivial: Final cleanup" 2020-09-13 23:38:50 +00:00
Zuul 51f698ece4 Merge "objects: Remove 'XenapiLiveMigrateData'" 2020-09-13 23:38:43 +00:00
Zuul 9a2763f846 Merge "xenapi: Remove Xen-only code paths" 2020-09-13 23:12:34 +00:00
Zuul 9e2aa2e87c Merge "virt: Remove 'is_xenapi' helper" 2020-09-13 23:12:27 +00:00
Zuul 7688bc0309 Merge "Correctly disable greendns" 2020-09-13 21:30:08 +00:00