Commit Graph

19832 Commits

Author SHA1 Message Date
Clark Boylan dbbbbf4ecb Enable tox use of site-packages for libvirt.
Enable the use of site-packages in tox which will allow the use of the
system install of libvirt while testing.

Hardcode the libvirt host UUID for tests that check this UUID when
system libvirt is being used. Without this hardcoding eight tests
would fail when using the system libvirt install.

Partially fixes bug #1113181

Change-Id: I59c5fbd45639962c0963298203c39759b6ca2d11
2013-03-19 12:11:10 +02:00
Alessio Ababilov 96c874cac5 Require netaddr>=0.7.6 to avoid UnboundLocalError
This issue is discussed at https://github.com/drkjam/netaddr/issues/2.
The bug in netaddr was fixed in release 0.7.6 on 13th Sep 2011.

Change-Id: Iea75a30963a09f9b0dd94138460bf041ab98fc66
Fixes: bug #1157058
2013-03-19 11:25:14 +02:00
Jenkins 31f954b096 Merge "Fix XenAPI performance issue" 2013-03-18 22:47:13 +00:00
Jenkins 5aec4001eb Merge "Remove unused virt.disk.api methods bind/unbind" 2013-03-18 22:46:58 +00:00
Chris Behrens f9a89b7065 Fix XenAPI performance issue
This patch implements 'list_instance_uuids' in the xenapi virt driver so
that compute manager's '_get_instances_on_driver' can operate more
efficiently.

Fixes bug 1097980

The cleanup_running_deleted_instances periodic task uses the above call
while context has been modified to be read_deleted='yes'.  Without
list_instance_uuids being implemented in xenapi, there's a fallback to
querying all instances on the host.  Because of read_deleted='yes', this
queries all instances that have ever lived on the host.  In a very busy
environment where instances are repeatedly built and destroyed, one can
end up with thousands of deleted instances.  Now that we are storing
instance_type data in system_metadata and system_metadata is joined with
every instance_get, this results in 10x the number of rows being
returned with sqlalchemy... the fallback doesn't perform well enough.

Change-Id: I4bbfd69c9769807cec813af757665f03d9643460
2013-03-18 20:26:02 +00:00
Jenkins 85aebeb8b8 Merge "Remove dead code." 2013-03-18 19:39:47 +00:00
Jenkins 47ded8e612 Merge "Fix issues with cells and resize" 2013-03-18 15:53:17 +00:00
Jenkins c519a378a2 Merge "Reset migrating task state for more Exceptions" 2013-03-18 12:25:15 +00:00
Jenkins ed1d6f2d02 Merge "Check keypair destroy result operation" 2013-03-17 23:02:51 +00:00
Russell Bryant 23fbde0b04 Remove dead code.
This patch removes an unreachable line of code.  Just above this line
was an if/else that had a return in both cases.  This final return False
was unreachable.

Change-Id: Ib71f732d231dd541a4f77d0244dda2c8d9914060
2013-03-17 18:32:31 -04:00
OpenStack Jenkins dcc76e702b Merge "Imported Translations from Transifex" 2013-03-17 22:21:27 +00:00
Jenkins 6db884e91f Merge "Add standard methods to the Limits API" 2013-03-17 19:31:54 +00:00
Jenkins f32bd1e8cc Merge "Revert "Remove the usage of instance['extra_specs'" 2013-03-17 19:29:36 +00:00
Jenkins c405e776bc Merge "Fix use of libvirt_disk_prefix" 2013-03-17 19:21:24 +00:00
Jenkins 60e3ac6cc4 Merge "Store project_id for instance actions" 2013-03-17 19:19:07 +00:00
Jenkins 36c7f0523e Merge "rstrip() strips characters, not strings" 2013-03-17 16:05:56 +00:00
Jenkins 919b7f7e94 Merge "Update migration 153 for efficiency." 2013-03-17 14:51:35 +00:00
Jenkins 87a5604004 Merge "Make ssh key injection work with xenapi agent" 2013-03-17 14:50:47 +00:00
mathrock dc3eb8e30d Remove unused virt.disk.api methods bind/unbind
The bind and unbind methods were only used by the old LXC
attach/detach volume code which was removed in
https://review.openstack.org/17861 (commit
b8831091a8). Remove them.

Fixes bug 1156127

Change-Id: I37b0344970415fe93faabd955b4b4db88de269db
2013-03-17 01:26:53 -04:00
OpenStack Jenkins b7a561dbf6 Imported Translations from Transifex
Change-Id: Ibb55a14b6ec8b30f7c478d7b999ea93c825aebe4
2013-03-17 00:03:09 +00:00
Dan Prince 6031a81fd5 Revert "Remove the usage of instance['extra_specs'
This reverts commit 76c47c1c30.

Fix libvirt vif get_config interface breakage.

In 76c47c1 we added a new arg to the libvirt vif driver get_config
interface (instance_type=None). We did not update all the libvirt
drivers to use it however which can break things badly (instances
fail to spawn, etc). We clearly need more test coverage here as well.

This should fix SmokeStack.

Fixes LP Bug #1155950.

Change-Id: I073d119ea2bfd5c314d2d8c8bbf2f6d7d649753a
2013-03-16 10:26:02 -04:00
Jenkins 9ee8c946f2 Merge "Remove the usage of instance['extra_specs']." 2013-03-16 03:12:10 +00:00
Giampaolo Lauria f5212a5831 Add standard methods to the Limits API
- Added create, delete, detail, show, and update
  stubs to the Limits API
- Added unit test cases
Fixes bug 869877

Change-Id: I112a8016ff2cf83009b3bcfe2fe6307568ce7334
2013-03-15 19:06:46 -04:00
Andrew Laski dba2f0296a Store project_id for instance actions
When packing values to store for an instance action, include the project
id from the request context.  This allows tracking which tenant has
performed an action.

Bug 1155801

Change-Id: I07b986655581fd6fbfdced90eb3151019f18ada7
2013-03-15 18:46:02 -04:00
Jenkins 0ca55dcccd Merge "Revert 1154253 causes XenServer image compat issue" 2013-03-15 22:18:26 +00:00
Johannes Erdfelt 397bb31c24 rstrip() strips characters, not strings
Fixes bug 1155761

This use of rstrip() could end stripping off more than just the ".gz"
suffix if the filename contains any of the ".gz" characters at the end
of the string.

Change-Id: Id75388453f286ca7b05bab51c9826c43c10ef516
2013-03-15 22:00:36 +00:00
Jim Fehlig 3e6eaa1f19 Fix use of libvirt_disk_prefix
The code supporting libvirt_disk_prefix was dropped during the
refactoring work in commit 7be531fe.  This patch re-enables
support for this option, along with a test case to verify it.

Change-Id: I84f059e2b35d9237b799236032de5c272a03a451
2013-03-15 15:13:31 -06:00
Dan Prince 7f1b1b69d7 Revert 1154253 causes XenServer image compat issue
In 1154253 we:

  Drop gzip flag from tar command for OVF archives

While support more OVF file formats is a worthy goal the approach
in 1154253 is going to cause serious issues for existing
Nova XenServer users who are already zipping their OVS images.

I would also point out that our utils.py xenserver plugins still
zips tarballs we create (see create_tarball) so the new code
causes internal inconsistencies as well.

This should fix SmokeStack.

Fixes LP Bug #1155783.

Change-Id: Iff6db314c0dec6df2e48d98db2a547f6624b9d9a
2013-03-15 16:57:47 -04:00
Jenkins 9dac4e6975 Merge "Fix db archiving bug with foreign key constraints." 2013-03-15 20:44:49 +00:00
Jenkins 11f6587250 Merge "Make os-services API extensions consistent." 2013-03-15 20:14:14 +00:00
Jenkins 4aac62be59 Merge "Make conductor's quota methods pass project_id properly" 2013-03-15 20:13:57 +00:00
Jenkins b2d35dbf68 Merge "Fix: improve API error responses from os-hosts extension" 2013-03-15 20:13:09 +00:00
Jenkins dd2a861aae Merge "Drop gzip flag from tar command for OVF archives" 2013-03-15 19:26:39 +00:00
Andrew Laski f5fa022468 Reset migrating task state for more Exceptions
There are a number of exceptions that can occur during pre
live-migration checks, and they should reset the task state to None when
they occur since they prevent the migration from beginning.  This adds
two more exceptions to the list of exceptions that just need to reset
the task state rather than set the instance to error.

Bug 1100462

Change-Id: I95e09f49908fbc3a79f5d2eb490d5a0b3296a6ed
2013-03-15 13:59:33 -04:00
Jenkins f14cd697c0 Merge "Fix OS-DCF:diskconfig XML handling" 2013-03-15 17:35:40 +00:00
Jenkins d802d80704 Merge "Fixes instance task_state being left as migrating" 2013-03-15 15:28:38 +00:00
Jenkins 63c1d5e6fa Merge "Add missing API doc for networks-post-req." 2013-03-15 15:23:37 +00:00
Jenkins d4e456876e Merge "Fix exception message in Networks API extension" 2013-03-15 15:23:15 +00:00
OpenStack Jenkins 7770390bf3 Merge "Imported Translations from Transifex" 2013-03-15 14:25:18 +00:00
Jenkins 6507ca1749 Merge "Fixes Hyper-V live migration with attached volumes" 2013-03-15 14:24:42 +00:00
David Ripton bb1977718d Fix db archiving bug with foreign key constraints.
Fixes bug 1137977

A few Nova tables have foreign key constraints on other tables.
Deleting a row whose id is referenced as an enforced foreign key for
another table results in an error.

The fix is to detect the IntegrityError when we attempt to delete a row,
and exit from archive_deleted_rows_for_table early.  The parent
archive_deleted_rows function will continue deleting from other tables,
including the one whose dependence on this row caused the IntegrityError,
and things will eventually sort themselves out.

Change-Id: I0afdfe0778057abc5fd269a20bfa4c4ca3a7b003
2013-03-15 09:15:12 -04:00
Jenkins 412b9e15cb Merge "Add quotas for fixed ips." 2013-03-15 02:10:27 +00:00
OpenStack Jenkins 5b73daed2e Imported Translations from Transifex
Change-Id: I9e57c57edc56e0bf68797ccfc920a119bb57905f
2013-03-15 00:03:54 +00:00
Jenkins c3468a830a Merge "Do cleaning up resource before rescheduling." 2013-03-14 23:54:43 +00:00
Brian Lamar 767aa58c29 Update migration 153 for efficiency.
Currently migration 153 inserts 10 rows per instance in the database.
For new/small installations this is relatively quick, but for large
installations this can take some time.

This change modifies the migration to only insert records for
non-deleted instances and makes bulk inserts (10 rows are inserted
with each query, instead of 1 per query) for added speed.

Fixes bug 1155371

Change-Id: I88a6cec2c117368fda6eefd82150106a1542027d
2013-03-14 19:45:38 -04:00
Jenkins bfc137d9db Merge "Fix system_metadata "None" and created_at values" 2013-03-14 23:07:12 +00:00
Jenkins 9b7ba0a067 Merge "Don't include traceback when wrapping exceptions" 2013-03-14 22:58:38 +00:00
Jenkins a95b62b51c Merge "Add the serial to connection info for boot volumes" 2013-03-14 22:58:15 +00:00
Jenkins 66a8721c43 Merge "Fixes an iSCSI connector issue in the Hyper-V driver." 2013-03-14 21:15:36 +00:00
Vishvananda Ishaya d63bd8d692 Don't include traceback when wrapping exceptions
The fix in fa52cb09b2 strips tracebacks
from exceptions when returning them to the user, but it still spams
the log with a long traceback. We shouldn't be including the traceback
when we wrap the exception in the first place. Instead we just
include the message.

It also updates the error code to 409 for device in use since this
is actually a conflict.

Fix for:

  bug 1155315
  bug 1103324
  bug 1092610

Change-Id: I95019a3022eb52e0335c455009c13fe229475d03
2013-03-14 13:53:06 -07:00