This is no longer necessary with our current minimum libvirt version.
Change-Id: Id2beaa7c4e5780199298f8e58fb6c7005e420a69
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Support for value-description tuples for the 'choices' parameters was
recently added to oslo.config [1]. Start using this in nova.
[1] https://review.openstack.org/#/c/526012/
Change-Id: Icd280d4daecabd1760080790e4aefc33dc2bece0
Couple of cleanups:
* Use openstack-lower-constraints-template, remove jobs that are part
of templates.
* Use openstack-tox-cover template, this runs the cover job
in the check queue only. Remove post job.
* Sort list of jobs and templates
* Use dsvm-irrelevant-files for newly imported jobs
Change-Id: Ibce77d3442e21bbd5f5ce379c203542f1f31ce9e
This is a mechanically generated patch to switch the documentation
jobs to use the new PTI versions of the jobs as part of the
python3-first goal.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: I102d40d5897a4f0963dffe6d4c25186c057fa856
Story: #2002586
Task: #24315
This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.
Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.
Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: Id44018e3c19d96f5f2dd104d0ed4d85973cd84e8
Story: #2002586
Task: #24315
The help for the [pci]aliases config option was confusing in that it
wasn't clear how to specify multiple aliases. The default value being []
made it seem like you ought to be able to specify a list as:
alias = [{...}, {...}, ...]
This won't actually work; you instead have to say:
alias = {...}
alias = {...}
...
So this patch adds a multi-alias example to the help string and
explicitly calls out the fact that you can't use list values.
See the referenced bug for more details.
Change-Id: I71d4c440340db31d22a73a8b3e3abc51771aa7bc
Closes-Bug: #1786870
This fixes the weird formatting in the changes-since
guide along with splitting up the giant wall of text
so this is easier to consume.
Change-Id: Ia15d3b5e3e1e8279d9109ca9c54f213c3e7838bb
There is a log message in the scheduler which dumps all instances
running on a compute host. There are at least 2 problems with this:
1. it generates huge amount of logs which are not really useful
2. it crashes when there is an instance with non-ascii name
Instead of fixing 2), just print instance UUIDs.
Closes-Bug: #1790126
Related-Bug: #1620692
Change-Id: I0eda1c58a7eb54121230c880818b4b1d0fdf4893
During a rebuild on the compute, the rebuild_instance method
fetches the new image from glance once to get the image_meta
for the RT.rebuild_claim, and then _do_rebuild_instance gets
the new image again to get image_meta for the driver.spawn/rebuild
method. Since it's the same image_meta either way, we can just
pass the image_meta from rebuild_instance to _do_rebuild_instance
and avoid the redundant GET call to glance.
Change-Id: I037a83f0a8cb4cdf87514dd4133da8bfedb564f5
Closes-Bug: #1790972
The create_incomplete_consumers online data migration was added in
Rocky via change Id609789ef6b4a4c745550cde80dd49cabe03869a. That
relies on hitting some tables in the API (or placement) database.
The DB API code for that migration relies on a placement context
manager which looks like it was regressed with change
I2fff528060ec52a4a2e26a6484bdf18359b95f77 (also in Rocky). This
results in a DB error trying to query the projects table but
because of a generic try/except in _run_migration, the failure
was missed in CI testing.
Similarly, the nova-status upgrade check "_check_resource_providers"
routine also uses the placement DB API context manager to count the
number of compute resource providers in the API (or placement) DB,
which is returning 0 because it's not using the proper DB connection.
This was not caught in the nova-status CLI tests because they use
the DatabaseFixture which *does* configure the global placement DB
API context manager.
This adds the configuration of the global placement DB API context
manager so we can properly query the placement-related tables.
The blanket problematic try/except from _run_migration is left
as-is in this change but will be addressed in a separate patch.
Integration testing of this fix is being performed with devstack:
https://review.openstack.org/599847/
Change-Id: I9d97b7a904e2b7d15c763e2a067cc5909cc6c9c5
Closes-Bug: #1790701
Closes-Bug: #1790721
The way in which this check counted compute nodes was
broken because of an incorrect for/else condition. If
the check is run with a nova.conf like we have in
devstack, where the API database is configured but
the [database]/connection is pointing at cell0, where
there are no compute nodes, the check passes saying
there are no compute nodes even if the are compute
nodes found in the cell databases (in the for loop).
This is because the else executes because the for loop
doesn't break, and then _count_compute_nodes returns 0
for cell0 and overwrites the num_computes variable.
This fixes the issue by checking if we have cell mappings
before running the loop, else we hit the else block as
was originally intended.
Change-Id: I1a706d028a9ca894348a19b7b3df1ea673e4ec90
Partial-Bug: #1790721
Cell mappings don't require a name, so when listing
cells, if any mappings don't have a name, the sorted
function will fail with a TypeError since you can't compare
None to a string.
This fixes the issue by using the empty string if the cell
mapping name is None.
Change-Id: I4fc9d8d1a96f1ec722c2c92dead3f5c4c94d4382
Closes-Bug: #1790695
Stephen Finucane