In Pike release, there is no auto-heal in the resource tracker.
So when instance booting failed, the allocation records aren't
cleaned up.
This patch clean up the allocation records when the instance
rescheduled and aborted.
Change-Id: I95d2f4c9392883052188fb7901451530068502db
Closes-Bug: #1712718
The Cells v1 feature is deprecated, meaning we can also deprecate the
respective commands in nova-manage. Do this.
Change-Id: I6db62a16272c74215944db164830515b774f5085
No recent neutron deployment should ever have the port_binding extension
missing in its list.
It appears like this has been the case since this commit in Liberty:
61121c5f2af27e31092db7ac6947f796198410a8
It causing lots of confusion around when an admin_client should be used,
among other things, so lets remove this needless complexity.
Co-Authored-By: Augustina Ragwitz <auggy@cpan.org>
Change-Id: I5fa73fa0610b23ef231952b2035a284819186a7c
Related-Bug: 1608601
We do not yet support live migrating an instance
across cells. This change handles two cases for
live migration:
1. The destination host is forced so the scheduler
is bypassed. In this case we directly compare the
source cell against the destination cell and fail
if they are not the same with a MigrationPreCheckError.
2. If no destination host is specified, or it's not forced,
we update the RequestSpec sent to the scheduler so it
will restrict the compute nodes it pulls from the same
cell that the instance lives in. If a host is requested
in this case but it's in a different cell, it would result
in a NoValidHost error from the scheduler.
Change-Id: I66fc72d402ac118270a835cf929fe1ea387d78cd
Closes-Bug: #1712008
This is done in a similar way to evacuation and shelve offload
to avoid further mingling of new-style allocation management
code with existing resource tracker code (soon to be removed).
Closes-Bug: #1712045
Change-Id: I6afd69166704e45d983b8b06a32a2799fb82b58a
When forcing a host during live migration, conductor bypasses
the scheduler so the scheduler won't create an allocation in
Placement against the destination host.
With change Ia93168b1560267178059284186fb2b7096c7e81f, once all
computes are upgraded to Pike, the computes won't auto-heal the
allocations for their respective nodes either, so we end up with
no allocation for the destination node during a live migration when
the host is forced.
This change makes conductor use the source compute node allocations
for the instance to claim the same resource amounts on the forced
destination host in Placement. If the claim fails, a
MigrationPreCheckError is raised.
This is a short-term fix for Pike. A longer-term fix to avoid this
duplication with the scheduler is to have conductor call the
scheduler even when force=True but pass a flag to the scheduler
so it skips the filters but still makes the claim on the destination
node.
Finally, some comments are left in the live_migrate method in the
compute API code since this is all tightly-coupled between the
API and conductor when a host is specified in the request, and it's
easy to get lost on what the API is doing to the request spec which
changes how conductor behaves, i.e. if it calls the scheduler or not.
Change-Id: I40b5af5e85b1266402a7e4bdeb3705e1b0bd6f3b
Closes-Bug: #1712008
Live migration now seems to be failing, as after the movement of the VM,
the allocations are both present on the source host, and on the
destination host.
The related assertions are commented out and replaced with wrong ones to
make the test pass.
Change-Id: Ib15d34c8da14dd006a0782e325d3c5e7b83fd0f1
Related-Bug: #1712045
Forced live migration now seems to be failing, as after the movement of
the VM, the allocations are only present on the source host, and not on
the destination host.
The related assertions are commented out and replaced with wrong ones to
make the test pass.
Related-Bug: #1712008
Change-Id: I6856f57426db6f2f49daea86679b50d5d019fe19
Per comments in I6815958b2533d462a2e5d27e7be57440d9f4f40a and
I5fdafd9f6cf07a19bf86a6343663dad410887dcb.
Part of bp: doc-migration
Change-Id: Iac833503b57386ab91fa86f8c48f0dd8039e5922
Fix test_validate_volume_no_mtab_entry. Currently depends on /etc/mtab,
this patches and mocks psutil.disk_partitions, which is the source of
the dependency.
Change-Id: Ie10b134a1840b1277c0c4059f634a6bafd256c2d
Closes-Bug: #1708196
it's apparently too late to make this change in Pike rc stage
so defer to Queens by changing the release version.
Change-Id: I006f41383dcef68d63a646665a56cbd4c3f93c4b
Periodic task _cleanup_running_deleted_instances() looks for orphaned
and running instances on hypervisor that should be deleted.
The problem is it checks if running instance has the same
hypervisor defined as it is in nova database.
In bug #1285000 it has been found that removing instance during
its migration could lead to abandon instance files on destination
host.
This change removes host filter in _running_deleted_instances() to
find also orphaned instances that are running on 'post migration'
destination host.
Change-Id: Idd1b58b85329b8e021eba4bc27f577af1b3338f4
Partial-Bug: #1285000
He Jie Xu