To better understand why sync_power_state is being skipped include the
pending task name in the log message.
Change-Id: I832a3d5820efab301e12610b28ca2a1e5cfd946a
This makes add_instance_fault_from_exc() use the InstanceFault
object instead of a raw conductor call. This is actually a
minor change except that all callers of this method must now
stop passing the conductor API, and tests must return something
valid from the mocked call.
Related to blueprint virt-objects-juno
Change-Id: I49b17c1ef3d14fd36f016c37d88287e62126bf68
This allows creating InstanceFaults through the object interface.
Related to blueprint virt-objects-juno
Change-Id: Iedde2e220127778fa6252d310f9e73c8506f605e
This removes use of some service calls in the conductor by xenapi's
host.py module and replaces them with object usage. Existing tests
are sufficient to confirm the same behavior remains.
Related to blueprint virt-objects-juno
Change-Id: I908cca4fa1d297c5c9b1d84ae7ebe7452a30ba12
This patch optimizes validate_networks so that it only queries neutron
when needed. Previously, this method would perform an additional net_list,
list_ports, and show_quota regardless if a request contains only
port_ids. If a request only contains port ids we do not need to check neutron
for quota as these ports are already allocated.
Change-Id: Ia7abc7d95b663f165fc95385dda3bab13b7a43e6
Closes-bug: #1291565
Moves the inner function "execute_create_vm" from the spawn method
to vm_util. Additionally, return the vm_ref after VM creation so
an extra call to retrieve the vm_ref does not need to take place
after the fact.
partial blueprint vmware-spawn-refactor
Co-authored-by: Tracy Jones <tjones@vmware.com>
Change-Id: I67c3c8c14b6c01b160611cc001d51f1da29ffb24
The root cause of the slow agent tests was not mocking this method:
compute_utils.add_instance_fault_from_exc
This cleans up the tests to share a bit more code, and ensures they
actually check that the appropriate exception is raised.
This change adds a log message to report errors that could occur in
running systems that also helped identify this issue in the unit tests.
test_spawn_fails_agent_not_implemented was a duplicate test and has been
removed.
Change-Id: I6fd31520fffd5e888ce0c2b58af2715f0d929ce1
Closes-Bug: #1279317
To actually check if a call was made, we should use
assert_called_once_with. assert_called_once is just a auto-spec'd
method and hence does not really check anything.
Change-Id: I21064dfca2a281683ee3b6ed4926f471bb74dbfa
The vCenter cluster will have multiple hosts.
The cluster does not have a uptime feature.
Returning uptime of one of the host/longest
running host, can be misleading to the user.
Hence raising NotImplementedError
Closes-Bug:#1313375
Change-Id: I70e5ab35b8944abd7b874762de2af5b01d6a7313
Removes the local method 'wrap_check_security_groups_policy' to
the module neutron_driver.py - This method is already defined
in compute_api.
Change-Id: I008326f7b77515a0fc878befe45fe705420835ad
Closes-Bug: #1314548
Our translation policy
(https://wiki.openstack.org/wiki/LoggingStandards#Log_Translation) calls
for not translating debug level logs. This is to help prioritize log
translation. Furthermore translation has a performance overhead, even if
the log isn't used (since nova doesn't support lazy translation yet).
Change-Id: Id270b6c7e020679c3e2e3931300e82ea3489e942
Our translation policy
(https://wiki.openstack.org/wiki/LoggingStandards#Log_Translation) calls
for not translating debug level logs. This is to help prioritize log
translation. Furthermore translation has a performance overhead, even if
the log isn't used (since nova doesn't support lazy translation yet).
Change-Id: Idb346d04f24cbbc19b6e41af6e4782ac1c49d3b8
The fake networks use a pre-serialized timestamp in str(datetime)
format which which doesn't give us the opportunity to test the
serialization code properly and isn't the format use in practice.
Use real dateime objects instead.
Full context here:
http://lists.openstack.org/pipermail/openstack-dev/2014-April/033971.html
Change-Id: I5cbe722fb59cdd326b4c75dcfea14f206d71f668
Joe Gordon