Our translation policy
(https://wiki.openstack.org/wiki/LoggingStandards#Log_Translation) calls
for not translating debug level logs. This is to help prioritize log
translation. Furthermore translation has a performance overhead, even if
the log isn't used (since nova doesn't support lazy translation yet).
Remove unnecessary debug level log translation in the scheduler to
comply with our translation policy. This has the added benefit of making
the scheduler slightly faster too.
Add a local hacking rule to enforce this.
Change-Id: Ie1068d2d2c7c37f27c62d0e4e5a64a1a504af9f5
Need to import API from nova.conductor not from nova.conductor.api
directly. This is needed so the is_local flag can be used to
determine the conductor API to use (local or rpc)
Change-Id: I9a45a705a39050b296936edc486db5c2f0aae4dc
Closes-Bug: #1308811
When using nova-manage with neutron v2 API, all CRUD operations
should be done directly against the neutron API, rather than
using nova-manage.
Change-Id: I663bd06eb50872f16fc9889dde917277739fefce
Closes-Bug: #1019895
This deprecates network_migrate_instance_start() and
network_migrate_instance_finish() from conductor, which are no
longer used.
Related to blueprint compute-manager-objects-juno
Change-Id: I01d7d502e8e8016cef3006ceddbcb31bccc4baf8
This marks aggregate_host_add() and aggregate_host_delete() as
deprecated in conductor.
Related to blueprint compute-manager-objects-juno
Change-Id: Icb84a730c737160ba194586a523f18c4dcf1c96d
This makes the instance_usage_audit() periodic task use the
InstanceList object to get the list of instances in the window
instead of using a raw conductor api.
Related to blueprint compute-manager-objects-juno
Change-Id: Ib267d742e26b2d4285003619c5e5dedae8ec1035
Previously, we added indirection APIs in conductor to wrap network
methods that still had direct-to-database calls that compute
manager couldn't make. Now that those are cleaned up, we can
remove the use of the indirection layer (and the layer itself from
conductor) and go direct to network_api again.
Related to blueprint compute-manager-objects-juno
Change-Id: Ia76552f49adf9b0d0128f08e3f99953560d8aa64
This makes the network api _is_multi_host() method use objects
instead of direct database access so that compute manager can
call it directly.
Note that the previous unit tests for this method used the
random.choice() method to selectively test the is/is-not multihost
case. Unit tests should not be non-deterministic like this, for
coverage and stability reasons. This patch pulls out the two
possibilities for each into separate cases to ensure both are
tested.
Related to blueprint compute-manager-objects-juno
Change-Id: I432a759a666948f2cfaa29d82f749dc9a39141be
There is no reason to fetch the network_info from the network api on shutdown
since we can just pull it out of the local cache. There are probably other
places where this call to the network api call can be removed but this patch
just handles the case for shutdown.
Note: the following test was removed 'test_terminate_no_fixed_ips' as
the call to the network api is no longer done so this test would be the
same as test_terminate_no_network.
Closes-bug: #1288392
Change-Id: Ifbf751739c215e566926719f481c03e2c064163a
In order to support backward compatibility a new method
'get_by_hint' has been added. This method will check if the
hint is a uuid and if no it will return get_by_uuid else it
will return get_by_name.
Change-Id: I728bf3454dc5a5367e21f242281719c1a967269a
Partial-bug: #1303360
Libvirt currently attempts to unplug VIFs after destroying an
instance, which can fail if the instance was never built
properly in the first place. This patch makes it ignore errors
when trying to tear down VIFs during that cleanup. Failure
in this case would block the deletion of the instance (which
should never happen) and any real failures aren't something
we could do anything about.
Closes-bug: #1306718
Change-Id: I84a4433c3959b8f14e0259be0aa51da1654006c8
This reverts commit 79ab96e34b.
This commit broke the Nova metadata API when using neutron.
Change-Id: I6855b03f00492fdf51e18c0dcb0a73590a71b374
Closes-bug: #1307582
Current "get console output" API does not allow -1 as the length and
returns a BadRequest response if receiving it. The other APIs(quota)
considers -1 as an unlimited value.
This patch allows -1 as the length for API consistency.
DocImpact
Change-Id: Idf88a238d1b0e545ebab5be872269b1b1030cc56
Related-Bug: #1295426
Moves the nova.image.glance.GlanceImageService._get_locations object
method into module level scope (the self argument was unused) and
adds full unit tests for the nova.image.glance._get_location() function.
Change-Id: Ib386330b70abe1e0353f1fafa3e68bc3e7a2d1b1
Partial-bug: #1293938