The docs job is not run in the gate, meaning invalid JSON files with
\r\n line endings are able to sneak in. Duplicate the checks from the
docs environment to the pep8 environment so that gate jobs run it.
Note that pep8 is our general linting target and thus should include
these kind of tests.
Change-Id: Ie923902b04be79b9f66ba1841c60899a413f6439
Closes-Bug: #1673131
When deleting an instance we look it up in the _get_instance
method and if it's in cell0 then the context is permanently
targeted to that cell via the set_target_cell method.
When we delete the instance in _delete we need to temporarily
untarget the context when we decrement the quota usage otherwise
the quota usage gets decremented in the cell0 database rather than
the cell database. Once the instance is deleted then we
re-apply the target cell on the context.
Change-Id: I7de87dce216835729283bca69f0eff59a679b624
Closes-Bug: #1670627
When we fail to schedule an instance, e.g. there are no hosts
available, conductor creates the instance in the cell0 database
and deletes the build request. At this point quota usage
has been incremented in the main 'nova' database.
When the instance is deleted, the build request is already gone
so _delete_while_booting returns False and we lookup the instance
in cell0 and delete it from there, but that flow wasn't decrementing
quota usage like _delete_while_booting was.
This change adds the same quota usage decrement handling that
_delete_while_booting performs.
Change-Id: I4cb0169ce0de537804ab9129bc671d75ce5f7953
Partial-Bug: #1670627
This patch updates network options deprecation releasenotes
for left out comment in I3f1dbddebea846b19c0a1647595c447fefc435e2
Change-Id: I3563cd6789bef411d0713b866d68a84dc28db097
Co-Authored-By: Gábor Antal <antal@inf.u-szeged.hu>
Change-Id: I8340817977ed7b15bb85d266de4fe9eedb0b0fa0
Implements: bp versioned-notification-transformation-pike
Handling rebuild.error:
https://review.openstack.org/#/c/396621/
Co-Authored-By: Béla Vancsics <vancsics@inf.u-szeged.hu>
Co-Authored-By: Gábor Antal <antal@inf.u-szeged.hu>
Change-Id: If624c2691830584851e9c97693cd7b7e73e73bb2
Implements: bp versioned-notification-transformation-pike
This adds a functional regression test for bug 1670627.
This is the recreate scenario. Patches that are proposed to
fix the bug will build on top of this and change it's assertions
to know when it's properly fixed.
Change-Id: I872a3fd5cfd3dd869f74cd3fd0aa5da411b1fec3
Related-Bug: #1670627
One goal of Cells v2 is to remove all up-calls from compute to API
cells. This change removes the up-call to delete consoleauth tokens
during instance deletion and live migration. Instead, the tokens are
deleted near the start of these processes in the API cell. To close
the loop, new consoleauth tokens are not granted to instances in
deleting or migrating task states.
Change-Id: Ic7c68b75e22bad2b0237a2f861254611a86516f3
This adds CellMapping.identity, a property to help with quick logging of
a CellMapping. It's tempting to just log a a whole CellMapping object,
but that can be bad due to the credentials stored within. This adds a
convenient way to log the uuid or name-and-uuid of a CellMapping without
having to replicate the is-name-set-or-none logic everywhere.
Related to blueprint cells-aware-api
Change-Id: Ie8eaf08e9f5bda56431358c40ccf187251be4542
In the current state, no warning was output in the logs.
With this fix, a warning is output in the logs and the value from
[DEFAULT] is used correctly.
Change-Id: I6a7f856e583aed31a3316c0b174a5559cd09e34b
Closes-Bug: #1671847
Previously we had aimed to make things like compute RPC automatically
look up the InstanceMapping or HostMapping for the call being performed
to target appropriately. However, we cannot do that within the cell,
and even trying incurs some overhead. For now, just deprecate the
by_instance() and by_host() methods and honor what is in the context
(if set) and otherwise fall back to the default client. Make the context
target routines create and store the RPC transport and remove the caching
logic from the ClientRouter since we're removing its ability to do that.
Related to blueprint cells-aware-api
Change-Id: I10f374adca672576058c4dbab708c040d166df47
Some of the sample files have duplicate
attributes in sample files.
Those did not cause failure as tests load json
sample file as dict and duplicate values gets merged.
This patch fix duplicate entry.
Functional sample file left while fixing the same on
doc sample - I7cd969fb4c9d4bff995c34725cfb739cccaba12c
Change-Id: I3fa0411e0a3f17020389911d5a16bcd247870839
Fix parameter types and the order of parameters.
Add missing parameters.
Add a period at the end of a parameter description.
Replace sample files with v2.10 files.
Change-Id: I9d8d20b42c7d32e11af479e79c9c9e8475421302
Closes-Bug: #1656781
The I8742071b55f018f864f5a382de20075a5b444a79 introduced cases when an
instance object is destroyed without the instance.delete notification
being emitted.
This patch adds the necessary notification to restore legacy
behaviour.
Closes-Bug: #1665263
Change-Id: I55ce90ca34c927c5dcd340fa5bdb0607a4ad4971
While these options are all deprecated, they were breaking the display
of option in the config-guide found in openstack-manuals. Remove excess
indentation and format code as such.
Change-Id: I72792ce7a12ac283e403cccf07ee6b9b63ad90bf
fdatasync is not available on Windows, for which reason this
operation now fails.
This change switches to fsync, which is platform independent.
Closes-Bug: #1671435
Change-Id: I71ac19160f198a97bb1834c5c81684758f129bcc
Stephen Finucane