These were added in Rocky [1] and can now been removed, since we don't
need to support anything from before Train in Ussuri.
[1] I4636a8d270ce01c1831bc951c4497ad472bc9aa8
Change-Id: Ib01ebeff0647f6e27714856f3a36c3896eeab27f
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Support for boot from volume where nova creates the volume
with a specified volume type was added in Stein [1] and an API
validation check was added to only allow that if the computes
were upgraded to Stein [2]. Now that we're in Ussuri and don't
need to support pre-Stein computes we can drop that API compat
check.
[1] Icc301230fe7c8e3ebbbcc7f4a807e562db7f93e3
[2] I45bd42908d44a0f05e1231febab926b23232b57b
Change-Id: If9c459a9a0aa752c478949e4240286cbdb146494
Change I3cc775fc7dafe691b97a15e50ae2e93c92f355be in Rocky
added compat code in _validate_bdm for when a boot-from-volume
request ends up using the legacy attachment flow and
_check_attach_and_reserve_volume was not called or did not set
bdm.attachment_id.
The legacy flow compat code was removed in Train in change
I6a777b4b7a5729488f939df8c40e49bd40aec3dd so we can remove the
now dead condition in _validate_bdm because the bdm.attachment_id
is always going to be set on a pre-existing volume during boot
from volume.
Change-Id: Ia1071ff1cb31e57f73e40eeb9b1531a7b1996cae
We only need this mocking if we're using nova-network.
Change-Id: Ic22f17764fa3ed3885a68c5928bfd56c3f81f2a7
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Previously any exception while rolling back the connection_info and
attachment_id of volume bdms would result in the overall attempt to
rollback a LM failing. This change refactors this specific bdm rollback
logic into two self contained methods that ignore by default errors
where possible to allow the LM rollback attempt to continue.
Change-Id: I6bc73e8c8f98d9955f33f309beb8a7c56981b553
This is a follow-up patch for https://review.opendev.org/676730.
In the TOC of the current PDF file [1], most contents related to
user and admin guides are located under "For Contributors" section.
This is weird. It happens because the latex builder constructs
the document tree based on "toctree" directives even though they
are marked as "hidden".
This commit reorganizes "toctree" per section.
The "toctree" directives must be placed at the end of
individual sections. Otherwise, content of a last section and
content just after "toctree" directive are concatenated
into a same section in the rendered LaTeX document.
This commit also improves the following as well:
* Specify "openany" as "extraclassoptions" to skip blank pages
along with "oneside" to use same page style for odd and even pages.
* Set "tocdepth" and "secnumdepth" to 3 respectively.
"tocdepth" controls the depth of TOC and "secnumdepth" controls
the level of numbered sections in TOC.
Note that this commit does not reorganize file structure under doc/source.
I believe this should be done separately.
[1] https://docs.openstack.org/nova/latest/doc-nova.pdf
Change-Id: Ie9685e6a4798357d4979aa6b4ff8a03663a9c71c
Story: 2006100
Task: 35140
Found this error in heat gate during running grenade test job.
Should not asking to provide cell_uuid if queue.get is timeout.
Closes-Bug: #1847131
Change-Id: I7f9edc9a4b4930f4dce98df271888fa8082a1701
A possible fix [1] for bug #1709118 is in keystoneauth1 release 3.3.0.
This change removes a workaround for that bug in
nova.utils.get_endpoint.
[1] https://review.openstack.org/#/c/500956/
Change-Id: If2a56ed56ecb3402fdee1189df81f0b9fbc483b3
Related-Bug: #1709118
These closely related features are the source of a disproportionate
number of bugs and a large amount of confusion among users. The spread
of information around multiple docs probably doesn't help matters.
Do what we've already done for the metadata service and remote consoles
and clean these docs up. There are a number of important changes:
- All documentation related to host aggregates and availability zones is
placed in one of three documents, '/user/availability-zones',
'/admin/aggregates' and '/admin/availability-zones'. (note that there
is no '/user/aggregates' document since this is not user-facing)
- References to these features are updated to point to the new location
- A glossary is added. Currently this only contains definitions for host
aggregates and availability zones
- nova CLI commands are replaced with their openstack CLI counterparts
- Some gaps in related documentation are closed
Change-Id: If847b0085dbfb4c813d4a8d14d99346f8252bc19
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This has been tying us to nova-network. This should be a one line change
but it has a large knock-on effect due to lots of samples using it. We
just need to suck it up and deal with it, unfortunately.
Change-Id: I09c88e0fdf3635683c56901637fc3c0a9084d482
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
We do this because most of our sample tests are currently using a fake
network cache due to 'stub_compute_with_ips', and that fake cache uses
the name 'private' instead of 'private-network'. When we remove that in
a future change, there's going to be a lot of refactoring. Head some of
that off by just using the same name.
Change-Id: I6339005a0d49a6dfd376523d3f9e145a00cfc3bd
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
When creating a port, we send a bit of information to neutron, namely,
the requested network, the tenant (project) ID and, crucially, the
device ID. The 'NeutronFixture' should be setting these fields on the
created port but is not. This hasn't been an issue to date but will when
we add subnet support, so fix this now.
Change-Id: Ia842854c12cd2d2ed630d1e0f2bb691859592cd9
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
It turns out it's possible to filter on multiple possible values using
by using an iterable query value. We're going to need this for proper
subnet mocking, so add it now. There's no impact on tests.
Change-Id: Ia02ff34ec94a911906e2e812ab6503d4a2118bce
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
The sample networks, subnets and ports this used were missing a lot of
fields that the neutron API returns. Beef these up to match something
like what we'd receive from a modern neutron instance. Note that this
does involve some shuffling around of lines, but that's intentional to
make things easier to diff. A future change will add proper security
group and floating IP support.
Change-Id: Ib07303d3ad96110d7d416a3d6e1e9197420f8680
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
I'm not sure why we weren't using 'self' here, but we can and should.
Change-Id: Ibc0e7159901a542dd436d3529d057e250351c413
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This test case is using common samples and falling back to the v2.37
server create request sample which uses auto-network creation rather
than a specific network ID. As a result, we must mock the relevant
functions from the neutronclient in our NeutronFixture.
Change-Id: I28493775b9135b8fb4d778963a2b227a4d8ed0a2
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Stephen Finucane