Since we look up the instance and call to its cell in consoleauth,
we need to look up the InstanceMapping and properly target the
database and rpc operation.
Related to blueprint cells-aware-api
Change-Id: I80013fa59b221f70376d6e1d4080ca699ff6caeb
Again, this is to ease cognitive overhead of comparing different tests.
Change-Id: I5f48d9d04601bf7dd0bd3b80d5b0fd6a476f1ada
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Make it easier to compare the various VIF types side-by-side.
Change-Id: Icd8d830a618c2ac56f17e8cf6d2d66051615908e
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This came up while reviewing change
I921daea7f6d5776b19561f0ca457e604a372eb9e but it was
noted that we're just stubbing out methods on a fake
virt driver object in these tests, so we should at the
very least autospec the mock so we don't mess up the
actual methods being stubbed.
Change-Id: I62e1c3e86394c8a6e815b1ea41ba005019026330
The unit tests covering the case that an invalid resource class
name was passed to set_inventory_for_provider were a bit too
unit-y and we can get the same coverage down the full stack with
a simple addition to the existing functional tests for the report
client. This adds the simple change to the functional test and removes
the now redundant unit tests.
Change-Id: Idb579acf6852650d4d5a6bc7704f123a40258f2d
The placement_database config options were added in Newton
but the actual code to use the options was reverted and is
not used. The help text actually has a typo (Ocata was 15.0.0,
not 14.0.0) and, more importantly, the help text makes it sound
like you should really be setting up a separate database for the
placement service but we don't actually use these options, we use
the api_database options for all of the placement data models.
To avoid confusion until this is actually supported, let's just
remove the options which should have been cleaned up as part of
39fb302fd9 anyway.
Change-Id: I31293ac4689630e4113588ab2c6373cf572b8f38
Closes-Bug: #1670419
log_path is required in _create_pty_device if:
1. serial consoles are disabled
2. libvirt/qemu are new enough that they support virtlogd
This was working fine for kvm and qemu since _create_consoles_s390x
and _create_consoles_qemu_kvm pass in the log_path, but for the
non-kvm/qemu cases, like xen, the log_path wasn't provided.
This wasn't caught by the XenProject CI since it's using libvirt
1.3.1 which does not have virtlogd support so this path was
not exercised and apparently not unit tested either.
A release note is provided since this is a pretty severe bug if
you're running new enough libvirt/qemu and not using kvm/qemu as
the virt type because CONF.serial_console.enabled is False by
default so you're going to have failed server creates immediately
upon upgrading to Ocata.
Change-Id: I7f60db1d243a75b90e3c0e53201cb6000ee95778
Closes-Bug: #1670522
Adds a new get_inventory() method to the virt driver API for returning a
dict of inventory records in a format that the placement API
understands.
We also move the ComputeNode.save() call out of the scheduler reporting
client and into the resource tracker. The resource tracker's _update()
method now attempts to call the new get_inventory() virt driver method
and falls back on the existing update_resource_stats() (renamed to
update_compute_node() in this patch) method when get_inventory() is not
implemented.
The next patch implements get_inventory() for the Ironic virt driver.
Change-Id: I921daea7f6d5776b19561f0ca457e604a372eb9e
blueprint: custom-resource-classes-pike
Use the flake8 plugin flake8-import-order to check import ordering. It
can do it automatically and don't need reviewers to check it.
Change-Id: Ia3d81bbbb44b40804b3268c0e648276a36cb4805
This reverts commit 99989cb652.
The bug this was added for (bug 1668958) has been resolved
so logging metadata contents is no longer necessary.
Change-Id: Ifd05aaacafaafc3ff01cd6c7323f57c0028e38ff
Related-Bug: #1668958
Jenkins