womax/nova
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fill the exception msg"

Browse Source
This commit is contained in:
Zuul
2022-01-11 17:34:06 +00:00
committed by Gerrit Code Review
parent f37a368e4e 2d4c77aa68
commit f2b364df64
3 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nova/tests/unit/virt/zvm/test_driver.py
+9 -5
View File
@@ -130,7 +130,7 @@ class TestZVMDriver(test.NoDBTestCase):
@mock.patch('nova.virt.zvm.utils.ConnectorClient.call')
def test_get_available_resource_err_case(self, call):
res = {'overallRC': 1, 'errmsg': 'err', 'rc': 0, 'rs': 0}
call.side_effect = exception.ZVMConnectorError(res)
call.side_effect = exception.ZVMConnectorError(results=res)
results = self._driver.get_available_resource()
self.assertEqual(0, results['vcpus'])
self.assertEqual(0, results['memory_mb_used'])
@@ -151,10 +151,14 @@ class TestZVMDriver(test.NoDBTestCase):
@mock.patch('nova.virt.zvm.utils.ConnectorClient.call')
def test_private_get_image_info_err(self, call):
res = {'overallRC': 500, 'errmsg': 'err', 'rc': 0, 'rs': 0}
call.side_effect = exception.ZVMConnectorError(res)
self.assertRaises(exception.ZVMConnectorError,
self._driver._get_image_info,
'context', 'image_meta_id', 'os_distro')
call.side_effect = exception.ZVMConnectorError(results=res)
ex = self.assertRaises(exception.ZVMConnectorError,
self._driver._get_image_info,
'context', 'image_meta_id', 'os_distro')
self.assertEqual(ex.overallRC, res['overallRC'])
self.assertEqual(ex.errmsg, res['errmsg'])
self.assertEqual(ex.rc, res['rc'])
self.assertEqual(ex.rs, res['rs'])
@mock.patch('nova.virt.zvm.utils.ConnectorClient.call')
@mock.patch('nova.virt.zvm.driver.ZVMDriver._import_spawn_image')
nova/tests/unit/virt/zvm/test_guest.py
+1 -1
View File
@@ -65,7 +65,7 @@ class TestZVMGuestOp(test.NoDBTestCase):
@mock.patch('nova.virt.zvm.utils.ConnectorClient.call')
def test_get_info_err_general(self, call):
res = {'overallRC': 500, 'errmsg': 'err', 'rc': 0, 'rs': 0}
call.side_effect = exception.ZVMConnectorError(res)
call.side_effect = exception.ZVMConnectorError(results=res)
self.assertRaises(exception.ZVMConnectorError, self._guest.get_info)
@mock.patch('nova.virt.zvm.utils.ConnectorClient.call')
nova/tests/unit/virt/zvm/test_hypervisor.py
+1 -1
View File
@@ -59,7 +59,7 @@ class TestZVMHypervisor(test.NoDBTestCase):
@mock.patch('nova.virt.zvm.utils.ConnectorClient.call')
def test_get_available_resource_err_case(self, call):
res = {'overallRC': 1, 'errmsg': 'err', 'rc': 0, 'rs': 0}
call.side_effect = exception.ZVMConnectorError(res)
call.side_effect = exception.ZVMConnectorError(results=res)
results = self._hypervisor.get_available_resource()
# Should return an empty dict
self.assertFalse(results)