Merge "Add test coverage of existing create_backup policies"

2020-03-06 19:50:35 +00:00
parent 9e7352c1dc b6692ee48a
commit f26d782895
2 changed files with 90 additions and 31 deletions
@@ -396,37 +396,6 @@ class CreateBackupTestsV21(admin_only_action_common.CommonMixin,
                      six.text_type(ex))


-class CreateBackupPolicyEnforcementv21(test.NoDBTestCase):
-
-    def setUp(self):
-        super(CreateBackupPolicyEnforcementv21, self).setUp()
-        self.controller = create_backup_v21.CreateBackupController()
-        self.req = fakes.HTTPRequest.blank('')
-        patch_get = mock.patch.object(self.controller.compute_api, 'get')
-        self.mock_get = patch_get.start()
-        self.addCleanup(patch_get.stop)
-
-    def test_create_backup_policy_failed(self):
-        rule_name = "os_compute_api:os-create-backup"
-        self.policy.set_rules({rule_name: "project:non_fake"})
-        metadata = {'123': 'asdf'}
-        body = {
-            'createBackup': {
-                'name': 'Backup 1',
-                'backup_type': 'daily',
-                'rotation': 1,
-                'metadata': metadata,
-            },
-        }
-        exc = self.assertRaises(
-            exception.PolicyNotAuthorized,
-            self.controller._create_backup, self.req, fakes.FAKE_UUID,
-            body=body)
-        self.assertEqual(
-            "Policy doesn't allow %s to be performed." % rule_name,
-            exc.format_message())
-
-
 class CreateBackupTestsV239(test.NoDBTestCase):

    def setUp(self):
@@ -0,0 +1,90 @@
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+
+import fixtures
+import mock
+from oslo_utils.fixture import uuidsentinel as uuids
+from oslo_utils import timeutils
+
+from nova.api.openstack.compute import create_backup
+from nova.compute import vm_states
+from nova.tests.unit.api.openstack import fakes
+from nova.tests.unit import fake_instance
+from nova.tests.unit.policies import base
+
+
+class CreateBackupPolicyTest(base.BasePolicyTest):
+    """Test Create Backup APIs policies with all possible context.
+
+    This class defines the set of context with different roles
+    which are allowed and not allowed to pass the policy checks.
+    With those set of context, it will call the API operation and
+    verify the expected behaviour.
+    """
+
+    def setUp(self):
+        super(CreateBackupPolicyTest, self).setUp()
+        self.controller = create_backup.CreateBackupController()
+        self.req = fakes.HTTPRequest.blank('')
+        self.mock_get = self.useFixture(
+            fixtures.MockPatch('nova.api.openstack.common.get_instance')).mock
+        uuid = uuids.fake_id
+        self.instance = fake_instance.fake_instance_obj(
+                self.project_member_context, project_id=self.project_id,
+                id=1, uuid=uuid, vm_state=vm_states.ACTIVE,
+                task_state=None, launched_at=timeutils.utcnow())
+        self.mock_get.return_value = self.instance
+        # Check that admin or owner is able to create server backup.
+        self.admin_authorized_contexts = [
+            self.legacy_admin_context, self.system_admin_context,
+            self.project_admin_context, self.project_member_context,
+            self.project_reader_context, self.project_foo_context
+        ]
+        # Check that non-admin and non-owner is not able to create server
+        # backup.
+        self.admin_unauthorized_contexts = [
+            self.system_member_context, self.system_reader_context,
+            self.system_foo_context,
+            self.other_project_member_context
+        ]
+
+    @mock.patch('nova.compute.api.API.backup')
+    def test_create_backup_policy(self, mock_backup):
+        rule_name = "os_compute_api:os-create-backup"
+        body = {
+            'createBackup': {
+                'name': 'Backup 1',
+                'backup_type': 'daily',
+                'rotation': 1,
+            },
+        }
+        self.common_policy_check(self.admin_authorized_contexts,
+                                 self.admin_unauthorized_contexts,
+                                 rule_name, self.controller._create_backup,
+                                 self.req, self.instance.uuid,
+                                 body=body)
+
+
+class CreateBackupScopeTypePolicyTest(CreateBackupPolicyTest):
+    """Test Create Backup APIs policies with system scope enabled.
+
+    This class set the nova.conf [oslo_policy] enforce_scope to True
+    so that we can switch on the scope checking on oslo policy side.
+    It defines the set of context with scoped token
+    which are allowed and not allowed to pass the policy checks.
+    With those set of context, it will run the API operation and
+    verify the expected behaviour.
+    """
+
+    def setUp(self):
+        super(CreateBackupScopeTypePolicyTest, self).setUp()
+        self.flags(enforce_scope=True, group="oslo_policy")