womax/nova
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix two test cases that use side effects in comprehensions

Browse Source 
List comprehensions with side effects considered harmful. Fix two known
instances.

Change-Id: Idfc05de3b42d08b288ff611b5c87c27d837e1301
This commit is contained in:
Dan Smith
2020-03-03 07:23:40 -08:00
parent 72224775fb
commit 6dd73d191a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nova/tests/unit/db/test_db_api.py
+4 -2
View File
@@ -3554,7 +3554,8 @@ class ServiceTestCase(test.TestCase, ModelsObjectComparatorMixin):
_make_compute_node('host2', 'node3', 'ironic', services[1]['id']),
_make_compute_node('host3', 'host3', 'kvm', services[2]['id']),
]
[db.compute_node_create(self.ctxt, cn) for cn in compute_nodes]
for cn in compute_nodes:
db.compute_node_create(self.ctxt, cn)
expected = services[:1]
real = db.service_get_all_computes_by_hv_type(self.ctxt,
@@ -3576,7 +3577,8 @@ class ServiceTestCase(test.TestCase, ModelsObjectComparatorMixin):
_make_compute_node('host2', 'node3', 'ironic', services[1]['id']),
_make_compute_node('host3', 'host3', 'kvm', services[2]['id']),
]
[db.compute_node_create(self.ctxt, cn) for cn in compute_nodes]
for cn in compute_nodes:
db.compute_node_create(self.ctxt, cn)
expected = services[:2]
real = db.service_get_all_computes_by_hv_type(self.ctxt,