Move comment about _destroy_evacuated_instances()

Per feedback in I595b27a57516cffe1f172cf2fb736e1b11373a1d, this moves
a comment about _destroy_evacuated_instances() further down closer to
where that method is called.

Change-Id: I72812918b26bf20d6ab5289f5eb855b23cc83881
This commit is contained in:
Dan Smith
2023-01-31 11:30:35 -08:00
parent d892905904
commit 5934f85fb9
+6 -6
View File
@@ -1610,12 +1610,6 @@ class ComputeManager(manager.Manager):
# NOTE(gibi): At this point the compute_nodes of the resource tracker
# has not been populated yet so we cannot rely on the resource tracker
# here.
# NOTE(gibi): If ironic and vcenter virt driver slow start time
# becomes problematic here then we should consider adding a config
# option or a driver flag to tell us if we should thread
# _destroy_evacuated_instances and
# _error_out_instances_whose_build_was_interrupted out in the
# background on startup
context = nova.context.get_admin_context()
nodes_by_uuid = self._get_nodes(context)
@@ -1633,6 +1627,12 @@ class ComputeManager(manager.Manager):
self._validate_pinning_configuration(instances)
self._validate_vtpm_configuration(instances)
# NOTE(gibi): If ironic and vcenter virt driver slow start time
# becomes problematic here then we should consider adding a config
# option or a driver flag to tell us if we should thread
# _destroy_evacuated_instances and
# _error_out_instances_whose_build_was_interrupted out in the
# background on startup
try:
# checking that instance was not already evacuated to other host
evacuated_instances = self._destroy_evacuated_instances(