Commit Graph

36 Commits

Author SHA1 Message Date
Alexander Bashmakov aba02eaa68 Remove unused _i18n.py shim.
This patch is part of the effort to remove copies incubated
Oslo code [1]. Removed unused openstack/common/_i18n.py which
graduated to oslo.i18n back in Juno release [2].

[1] http://governance.openstack.org/goals/ocata/remove-incubated-oslo-code.html
[2] http://specs.openstack.org/openstack/oslo-specs/specs/juno/graduate-oslo-i18n.html

Change-Id: I7f7d2916baebf0c23c962329d22b4be930abc326
2016-09-30 10:04:19 -07:00
Matt Riedemann 96927a6c2b Remove unused openstack/common/apiclient/client
This code comes from oslo-incubator and is now frozen,
and the client module specifically is not used in glanceclient.
It's confusing to have in the library since glanceclient has
it's own HTTPClient under glanceclient.common.http. So let's just
remove this effectively dead code.

Change-Id: I820b2439ce7158a63dc55553ce50a9580d63ffb3
2016-07-27 12:02:01 -04:00
Rui Chen 7651b596a3 Fix Resource.__eq__ mismatch semantics of object equal
The __eq__ of apiclient.base.Resource will return True,
if the two objects have same id, even if they have different
other attributes value. The behavior is weird and don't
match the semantics of object equal. The objects that have
different value should be different objects.
Fix this issue and add some test cases in this patch.

Change-Id: I24ba39bf90d727116f256de46241746520efbfee
Closes-Bug: #1499369
2015-11-28 18:15:52 +08:00
kairat_kushaev df0f6642e5 Do not use openstack.common.i18n in glance client
i18n library is present in openstack.common but we also have
glanceclient module that supports the same functionality.
In order to be consistent and exclude dependencies on
oslo-incubator code we need to use glanceclient.i18n module only.

Change-Id: Iae9722d7903034bfa6fb8afadbb1f1292c29203e
2015-09-29 14:16:27 +03:00
Darja Shakhray ec0f2dfd85 Enable flake8 checks
This commit enables new flake8 checks:
* E265  block comment should start with '# '
* H405  multi line docstring summary not separated with an empty line
* E123  closing bracket does not match indentation of opening bracket's line
* H238  old style class declaration, use new style (inherit from `object`)
* E128  continuation line under-indented for visual indent
and makes related changes in the code.

Change-Id: Ie993afc930f6b74d7a990bcaa9fc0e9f5ba1585c
2015-07-21 17:08:27 +03:00
Davanum Srinivas 5e85d61fb9 cleanup openstack-common.conf and sync updated files
periodic updates of latest from oslo-incubator. please
note that files no longer on oslo-incubator mean that
they have been moved to oslo.* libraries. So there's
more work needed to remove these files and switch
to appropriate libraries

Change-Id: Icd71b4b1ea9f1df526614a29277f25a7ab47b721
2015-06-10 11:59:12 +00:00
Jenkins 7f9b643371 Merge "Remove graduated gettextutils from openstack/common" 2015-03-03 23:38:17 +00:00
Louis Taylor e99e0c8690 Change oslo.utils to oslo_utils
The oslo.utils libraries are moving away from namespace packages.

This requires oslo.utils>=1.2.0

bp drop-namespace-packages

Change-Id: I803df61e91eabb96329d859aef6bea03530fb84f
2015-02-05 22:27:16 +00:00
Ian Cordasco 1d823962e1 Remove graduated gettextutils from openstack/common
Use oslo.i18n package and handle different versions properly in
glanceclient._i18n. The oslo namespace is being deprecated so imports
will be oslo_i18n going forward. For older versions of oslo.i18n though,
we will still be able to import i18n from oslo.

Change-Id: Id56d34ccf447dc6f7becafb74d6a30e8a1642030
2015-02-03 13:20:39 -06:00
Louis Taylor 878bdcbdbc Remove openstack.common.importutils
This module now lives in oslo.utils, so import it from there.

Change-Id: I41fa4897fc820596fb010336044ff4c493017d5a
2015-01-28 02:12:18 +00:00
Louis Taylor b818826420 Remove openstack.common.strutils
This module now lives in oslo.utils, so import it from there instead.

Co-Authored-By: Ian Cordasco <ian.cordasco@rackspace.com>
Change-Id: Ib35dc840992433542490670781badd9529ec8947
2015-01-27 19:22:42 +00:00
Zhi Yan Liu 363b170851 Sync latest apiclient from oslo-inc
a908d66 Remove uuidutils
5985b35 Prefer delayed %r formatting over explicit repr use
002999b Curl statements to include globoff for IPv6 URLs
03e6272 Add ConnectionError exception
3bc8231 deprecate apiclient package
fd8dc0c Handle different format of api exception
a7af1e2 Mask keystone token in debug output
55ca7c3 Split cliutils
5d40e14 Remove code that moved to oslo.i18n
6ff6b4b Switch oslo-incubator to use oslo.utils and remove old modules
f76f44c Delete the token and endpoint on expiry of token of client
ed0ffb8 Do not incur the cost of a second method call
cf449e2 Fix response_key parameter usage in BaseManager
94245b1 Make it possible to get the request_id from python clients
d73f3b1 Remove unused/mutable default args
5e00685 Centralize bash-completion in Novaclient
4ef0193 Handle non-openstack errors gracefully
ac995be Fix E126 pep8 errors
de4adbc pep8: fixed multiple violations
e42e77f Restore UUID and human-ID bash completion
9e88af1 fixed typos found by RETF rules
822e09b Don't slugify names that don't exist
4a777e5 Fix warnings in doc build for apiclient
3fb053c apiclient.exceptions.from_response() may miss request_id

Btw, the patch removed the uesless 'network_utils' line from
openstack-common.conf, currently we use oslo_utils.netutils directly.

Change-Id: Ic3d48a13d5366b050b07ef26ab34fad411a0db05
Signed-off-by: Zhi Yan Liu <zhiyanl@cn.ibm.com>
2015-01-23 23:05:05 +08:00
Oleksii Chuprykov 5f4966df68 Remove network_utils
Use oslo.utils instead

Change-Id: I4830b13794db5570e7dde4a897a7396065028e37
2014-10-03 16:26:29 +03:00
Dirk Mueller 7bdf2526b7 Remove py3k module
This module is obsolete and has been dropped from oslo-incubator.
Use six instead (which is already done here).

Change-Id: I8e0b49cdfbddcf2d44a601ad06be2e75897905fc
2014-04-28 18:23:46 +02:00
Davanum Srinivas 58ee451286 Adding network_utils module from oslo-incubator
Needed for fixing bug 1298137

Change-Id: I6803f1af8b0ff036bed634c8aa1cffc52bc508e0
2014-04-02 21:36:10 -04:00
Davanum Srinivas ff0c87eeca Sync with oslo-incubator
Head of oslo-incubator is commit id:
2fd457bf2ccbeb2b84ffb204778b6417cd5405ba

includes a fix for gettextutil.Message handling of deep copy
failures and adding a license header

Change-Id: Ie89de1f95bb6fb9d11058413e682c441c39524f1
2014-04-02 21:30:22 -04:00
Cyril Roelandt 3c16d23293 Sync with Oslo
This will help with porting to Python 3. List of merged commits:

04a1abe59ac39890f57d2eed57d3d1b12bb5d757
12bcdb71ffbe9ee1688beed1f0ddb0c198822682
2cfc1a78d8063cf20083cf7df796d730a576551c
302c7c80b503b8090e8118e45061e8903b5339a9
35dc1d797209f0b22ff3ed3b8a6059961563daee
3b248dd683d83fd564f740ea58565d1bc0bd6cc0
4246ce0f373aa8f8955a99a3b6288a32547d8e80
6650435004af149284f0badb2bb8c89005cc7dab
6d55e26aa379fd043c66d1b7c5bf59a1b4a54632
71c22e9b2fbf04fc91a7343d3de0e0c7f10e3988
84d461e859e4b1eb1a00b9b141df61c37da84d2d
8575d87af49ea276341908f83c8c51db13afca44
885828af2297b20a3f9f8e8f6647f7291f784743
8b2b0b743e84ceed7841cf470afed6a5da8e1d07
9f1e7eb4112067423f845bd99ec52256db1c8bb1
bd5dad97585208ea5e86d636f3dc3b669e361a41
be81d6ba70152e5cdd7e8e9d789b9733c6ff527f
bec3a5eb8157c0c552c6392ccf0da342ffb8da26
c178e567cb48d3bc67dcf06bcbb4c6a97df9f434

Closes-Bug: 1289690
Change-Id: I39fa5e3fa46ffe9448b381ed54759cb4270cc898
2014-03-08 05:06:30 +01:00
Andrey Kurilin 0bf7bdd6f2 Sync apiclient and py3kcompat from oslo
In the process of unification of the clients code we should
reuse common functionality from Oslo.

Related to blueprint common-client-library-2

Change-Id: If261bce6f2f7676484594c45970d6dd8e676ca79
2013-12-30 12:20:52 +02:00
Chuck Short 79138278b1 Sync from oslo-incubator
Sync from oslo-incubator contains various python3 fixes.

Change-Id: I55e867450d65d9fa74fd6ef6ffece2bbb9f929cf
Signed-off-by: Chuck Short <chuck.short@canonical.com>
2013-10-15 14:57:26 -04:00
Dirk Mueller 62579fbb21 Start using Pyflakes and Hacking
Instead of globally ignoring pyflakes and
hacking warnings, only blacklist those that trigger
very frequently so far, in order to clean them
up in followup commits. Fix and start gating
on the rest already.

Change-Id: Ied7c7250061e3bf379e8286e8ce3b9e4af817faf
2013-06-22 16:00:26 +02:00
Flaper Fesp 7818387d4a Replace utils.ensure_(str|unicode) with strutils.safe(decode|encode)
Glanceclient implemented both functions before they landed into oslo.
Since both functions are already in oslo, it is now possible to pull
them in.

There's a small difference between glance's implementation and oslo's,
that is the later does not convert non-str objects - int, bool - to str
before trying to decode / encode them. This patch takes care of that
where necessary, more precisely, while encoding headers before doing a
new request.

Fixes bug: #1172253

Change-Id: I9a0dca31140bae28d8ec6aede515c5bb852b701b
2013-06-04 00:42:32 +02:00
Flaper Fesp 9e515245a3 Update importutils and openstack-common.conf format
THe patch updates the importutils module and uses a per-line module
specification instead of the old modules= options.

Change-Id: Ieb28780bb9034fd61942305ff1eec21b3637027a
2013-05-23 11:11:56 +02:00
Monty Taylor 4f9d4d051a Migrate to pbr.
Fixes bug 1179007.

Change-Id: I99d571bbf37ef53366a96de088c249cb6fd23b0e
2013-05-18 09:02:07 -07:00
Davanum Srinivas e22d37d6f9 Sync with oslo-incubator copy of setup.py and version.py
Keep up with the changes to the master copy

Change-Id: Id938cc593a61b56a06c05069034bd958fc6aa8b3
2013-04-21 20:18:49 -04:00
Monty Taylor d20d9d1ca4 Update to latest oslo-version.
Remove the need for versioninfo file and just use python's PKG-INFO.

Change-Id: I4765141e9bf3fa075dfbbc6a07e495c29e12177b
2013-02-07 05:10:08 -06:00
Alessandro Pilotti 16aafa728e Fixes setup compatibility issue on Windows
Fixes Bug #1052161

"python setup.py build" fails on Windows due to a hardcoded shell path:
/bin/sh

setup.py updated using openstack-common/update.py

Change-Id: If0ae835aeada8769e46dddf4f3c2f2edfdfbc5fe
2012-11-05 18:19:13 +02:00
Mark McLoughlin 7402590255 Sync importutils changes from openstack-common
Syncs the following changes from stable/folsom:

 769ec65 Don't trap then re-raise ImportError.
 8c74b37 Improve exception from importutils.import_class().
 1fb2361 add import_object_ns function

Change-Id: Ib6046181ec4712702c30c8a8e938fc9a21b1a594
2012-09-05 12:57:30 +01:00
Monty Taylor a814c15465 Add ability to get version information in python
* A user can access glanceclient.__version__ to get a string
  representing the version of the installed library.
* Add openstack-common's 'version' module.

Change-Id: Ib14c561d8ac0b126617a20acfbd5fdb61c54f2c7
2012-07-11 14:04:09 -07:00
Monty Taylor c315c5274f Latest setup goodness.
Upgrade the common setup code to the latest versions, and use setuptools-git
for sdist tarball generation.

Change-Id: I81eca9199b7d330ef8ec80482565a75f8475a78c
2012-07-11 12:21:29 -05:00
Monty Taylor 089d509f35 Split reading of versioninfo out into a method
Make the read_versioninfo to match write_versioninfo.

Additionally, there is an edge case where if the code is installed from a
github zipball, versioning info is missing. Now that we're using this,
there should be virtual no instances where a zipball will be easier or
less cost than an sdist created tarball, all of which should be public and
accessible, but during the transition, we need to account for the codepath.

Change-Id: Icd3fe97c6341bb04da27adc55a85f1ab6b525c46
2012-06-26 14:05:36 -05:00
Monty Taylor 03efd16896 Add support for tag-based version numbers.
Change-Id: I9b0e24f65e9b79c39bdf279b7af9c1040ded7952
2012-06-25 10:09:44 -05:00
Monty Taylor 6e1157059e Add initial docs.
Change-Id: I1f8407597105a914945c932ff55945c8005e273c
2012-06-14 14:24:05 -04:00
Bhuvan Arumugam a1f8ea1c7f Auto generate AUTHORS file for glanceclient component.
Bug: 976267

Now that git commits are gated by CLA, we shouldn't enforce
committers to add an entry in AUTHORS file. The AUTHORS file
should be generated automatically, based on git commits.

This commit fixes the problem.

* AUTHORS
  Remove this file.

* .gitignore
  Add AUTHORS file.

* glanceclient/openstack/common/setup.py
  Sync changes from openstack-common.

* setup.py
  Generate AUTHORS file before creating the package.

* glanceclient/shell.py
  Pep8 fix.

* tests/test_authors.py
  Remove this test case.

Change-Id: I9e9d4da5ca3b147b483250dcf25a3b2a840123c2
2012-06-02 00:04:12 -07:00
Monty Taylor 32ba1385ef Properly install from zipball.
Change-Id: I505a42ec11b388e3ee5c818a1aadf0f70d5565c5
2012-05-25 14:38:33 -04:00
Brian Waldon 623a0898f8 Add importutils from openstack-common
As a side-effect, openstack.common.setup is getting updated

Change-Id: I9f8696ec5c82ef32872e1a974102dcd179eb70f9
2012-05-20 13:08:20 -07:00
Monty Taylor 57e352a070 All the latest OpenStack hotness. 2012-02-29 14:14:14 -08:00