Fixes bug 1056499.
Added a line to the help text of --checksum which enhances the help text
to show what checksum algorithm is expected.
Change-Id: Ie6604022dd9f398c639afe647b2d94b5179dbb61
Add nargs to argparse for image-delete command to
allow muliple (optional) positional image-id arguments.
For example:
image-delete xxx aaa yyy will delete valid images
xxx and yyy and print error message for invalid image
aaa. Also with --verbose you can see some extra text
on delete request for each image.
Fixes bug1056498.
Change-Id: I6e804700ed24d16f90ec92569c0893cad4aaa26f
It may not be possible to know in advance the total
size of image data which is to be uploaded, for example
if the data is being piped to stdin.
To handle this we use HTTP Transfer-Encoding: chunked
and do not set any image size headers.
Various subtly different cases needed to be handled for
both image-create and image-update, including:
* input from named pipe
* piped input of zero size
* regular file of zero length
Fix for bug 1056220.
Change-Id: I0c7f0a64d883e058993b954a1c465c5b057f2bcf
Fixes bug #1056497
This patch provides more information in the help text. Originally the text
provided the trivial definitions of the arguments disk_format and
container_format. This patch updates the text to display the acceptable
formats.
Change-Id: I893b52c9f72a34c75e8bea522820863592300302
The image-create help page reversed the DISK_FORMAT
and CONTAINER_FORMAT metavars.
Fixes bug 1051968.
Change-Id: I385cb0912ad87a62fd10742b5da23a5ea8bc9bb8
Fixes Bug #1050345
The image upload hangs if the file contains a byte with value 0x1A (EOF), due to
the fact that the file or stdin streams are treated as text and not
binary streams. This fix sets the proper binary mode.
Change-Id: I3425cb9729a8da4d1b73fbfba06fd6f2c7e8833e
While uploading a Volume to an image, the HTTPConnection's request method does
not set the Content-Length header (since the volume file is a sym link i.e. the
os.fstat call returns a st_size of 0). This causes Volume uploads to Glance
fail (since the image data is ignored as no content-length is specified).
Therefore setting the Content-Length from update( ) method if the image data is
provided.
Fixes LP: #1045824
Change-Id: If259fc5a338e3e90214a52b773132ed901691c0f
Several commands did not have descriptions or the descriptions
they had were insufficient. This adds mission descriptions
and fattens up those that were too lean.
Change-Id: I091ae70cdae5d3f72f273519d88873cb5392ba3b
Added the CLI option image-download to download an image via API V1.
Based on commit 137b3cf975
Related to bp glance-client-v2
Change-Id: Ie587e208ad7433e468798cd9b1846b4a21e1c4ec
The tests were present but were not asserting list results.
page_size was overriding the absolute limit so limits were
not working if they were less than the page_size.
Fixes bug 1037233
Change-Id: If102824212e3846bc65d3f7928cf7aa2e48aaa63
The legacy client allowed users to pass 'deleted' through an
update call. This is breaking some clients of this library because
they expect to be be able to still do that.
Fixes bug 1036315
Change-Id: I9ae20a5e4579240c7d5e86316d6d1e927755dbf5
To keep a consistent view of an image, is_public, protected, and
deleted need to be cast to a bool when being parsed from headers.
Fix bug 1036299
Change-Id: I2730a0f2d705d26ebc0ba883e99c1caf44d70b51
Cast size, min_ram, min_disk to integers before returning them
to the user from the v1 API.
Fixes bug 1036297
Change-Id: Ib1e2a3bf931e433b6311cc8a1a5219168b50be97
Added the CLI option image-download to download an image via API V2.
Added utility function to save an image.
Added common iterator to validate the checksum.
Related to bp glance-client-v2
Change-Id: I0247f5a3462142dc5e9f3dc16cbe00c8e3d42f42
This adds support for validation of ssl certs returned by remote
servers over SSL. The --ca-file param represents the CA cert used
to sign the remote server's cert. Use --insecure if the remote
server is using a self-signed cert or you don't have the CA cert.
Related to bp glance-client-parity
Change-Id: I45253a6e2d88da599addfcc464571e62ae920166
A few files were missing copyright headers:
* glanceclient/common/http.py
* glanceclient/v1/__init__.py
* glanceclient/exc.py
Change-Id: Ibbd53cd49f9367994de66a30601b3aefe1a8d6ee
All legacy CLI commands should work as expected with a few
minor exceptions:
- no upload animation
- no interactive pagination
- help/usage output has changed
Deprecated options are indicated as such in their usage info. Deprecated
commands have descriptions that label them as such.
Related to bp glance-client-parity
Change-Id: I584b2447361967228bea332e14880e18db12fca8
Using the --debug flag or the GLANCECLIENT_DEBUG env var, a user will
see http requests and responses in great detail. Requests are formed
into proper curl commands while responses are printed just as they would
as if the curl request provided were executed. Response bodies will not
be printed if they are application/octet-stream.
Change-Id: I9c9c5d6ec9f481091c944e596d073da3739795b6
* This allows us to send truly chunked responses to users
* Handle bad connection url schemes with a new InvalidEndpoint exception
* Fixes bug 1023240
Change-Id: I34500987f51d4e0c6e1f89ecf93853de3fcbb1c3
* Use recursive generator function to make subsequent requests
to the v1 detailed images resource
* 'limit' continues to act as the absolute limit of images to return
from a list call
* 'page_size' indicates how many images to ask for in each subsequent
pagination request
* Expose --page-size through the cli
* Convert v1 images tests to use strict url comparison
* Drop strict_url_check from FakeAPI kwargs - now the functionality
is always active and tests must directly match fixture urls
* Fix bug 1024614
Change-Id: Ifa7874d88360e03b5c8aa95bfb9d5e6dc6dc927e
This moves image-create closer to image-update by adding
--is-public and hiding the help output of --public. The
--public option will be removed once devstack no longer
depends on it.
Fix bug 1023632
Change-Id: I2c58655ba56eef1fa486246618c4fb5bd3c6c8cf
This is establishing the API for a future optimization. We want to
be able to offer true socket-level caching, but can't do that with
httplib2 right now. For now, we will just fake the optimization
by returning an iterator over the image body, which happens to already
be fully loaded into a string.
Change-Id: I2d36e3cdd45b26d7c7c27ba050bf6a4b5765df6c
When creating or updating an image, translate the 'is_protected'
argument into the proper 'protected' image attribute.
Fix bug 1023653
Change-Id: Icfe6c38e4fda098ce3f90fd94c8fbbc18be2f4a8
Make image-create match image-update when specifying a specific
value for 'protected'.
Fix bug 1023650
Change-Id: I02ddeb59c1f6882b206279a71f7af8889ce4602c
* By default, image properties should not be deleted on image update.
* A user can specify --purge-props through the CLI or purge_props
as a keyword argument to ImageManager.update to override the default
behavior and force properties to be deleted.
* Fixes bug 1022758
Change-Id: Ib079378cb765552fc29a66913aefbbcd934d2065
* Add the --file option to the image-update action, as it was left out
of a previous patch
* Additionally, change a bad reference (args.fields) to args.file
* Fix bug 1022750
Change-Id: Idde127ec3f138f718d671b2133d50debec26236e
A user can filter a list of images by passing in a 'properties'
sub-dictionary inside of the 'filters' keyword argumen to
ImageManager.list(). The same functionality can be used through
the CLI through the use of one or more'--property-filter' options.
Related to bp glance-client-parity.
Change-Id: I7d119174d83faa894dde557e1944289de296a02c
Add comparison filters for the v1 image-list command: --name,
--status, --container-format, --disk-format.
Related to bp glance-client-parity.
Change-Id: I27377764ea5543a4bef593f0a731b09a914a9265
Add --size-min and --size-max options to image-list to
represent the size_min and size_max filters passed to
the ImageManager.list method.
Related to bp glance-client-parity
Change-Id: Icb5458c3ed26ea754cff6360b741b3af99d1beb5
Allow an image to be read from a local file as an alternative to
stdin (which remains the default).
Change-Id: I81070ded9c505df7924c4efd5ae54cf3c0fa534d
Rather than depend on magic, I would prefer that we explicitly call
two different request methods: json_request and raw_request. The
former will encode/decode request bodies to and from JSON, while
the latter will not.
Change-Id: I6a429a5975993f71df85df55f11c5d51c050c289
Fields were missing from image-list that were present in the old index:
'Disk Format', 'Container Format', 'Size'
Change-Id: Ia86caec1938560c56292c0f3028ee48e774d0057
The return value of ImageManager._get_file_size() is passed on to
the glance server in the create api call. Returning None causes
the server to reject the request as malformed.
Add dtroyer to AUTHORS
Change-Id: I02c90e2db5fbd1e49d1516550c806f26dae83fb9
Andre Naehring