diff --git a/glanceclient/tests/unit/v2/test_shell_v2.py b/glanceclient/tests/unit/v2/test_shell_v2.py index b2a6415..e113995 100644 --- a/glanceclient/tests/unit/v2/test_shell_v2.py +++ b/glanceclient/tests/unit/v2/test_shell_v2.py @@ -2940,13 +2940,15 @@ class ShellV2Test(testtools.TestCase): args = self._make_args({'namespace': 'MyNamespace', 'name': "MyProperty", 'title': "Title", + 'type': 'boolean', 'schema': '{}'}) with mock.patch.object(self.gc.metadefs_property, 'create') as mocked_create: expect_property = { 'namespace': 'MyNamespace', 'name': 'MyProperty', - 'title': 'Title' + 'title': 'Title', + 'type': 'boolean', } mocked_create.return_value = expect_property @@ -2955,13 +2957,15 @@ class ShellV2Test(testtools.TestCase): mocked_create.assert_called_once_with('MyNamespace', name='MyProperty', - title='Title') + title='Title', + type='boolean') utils.print_dict.assert_called_once_with(expect_property) def test_do_md_property_create_invalid_schema(self): args = self._make_args({'namespace': 'MyNamespace', 'name': "MyProperty", 'title': "Title", + 'type': "boolean", 'schema': 'Invalid'}) self.assertRaises(SystemExit, test_shell.do_md_property_create, self.gc, args) diff --git a/glanceclient/v2/shell.py b/glanceclient/v2/shell.py index 3b5b248..652fab9 100644 --- a/glanceclient/v2/shell.py +++ b/glanceclient/v2/shell.py @@ -1218,6 +1218,8 @@ def do_md_namespace_resource_type_list(gc, args): help=_('Property name displayed to the user.')) @utils.arg('--schema', metavar='', required=True, help=_('Valid JSON schema of a property.')) +@utils.arg('--type', metavar='', required=True, + help=_('Type of the property')) def do_md_property_create(gc, args): """Create a new metadata definitions property inside a namespace.""" try: @@ -1225,7 +1227,7 @@ def do_md_property_create(gc, args): except ValueError: utils.exit('Schema is not a valid JSON object.') else: - fields = {'name': args.name, 'title': args.title} + fields = {'name': args.name, 'title': args.title, 'type': args.type} fields.update(schema) new_property = gc.metadefs_property.create(args.namespace, **fields) utils.print_dict(new_property)