womax/python-glanceclient
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Test: use assert_has_calls() instead

Browse Source 
Some of the assertions in glanceclient test are sequential, we should
better use assert_has_calls() instead of assert_any_call().
And assert_has_calls() provides more clear messages in case of failure.

Change-Id: Ie45e7c56b1c859916a1f31636c639422f1ffef28
This commit is contained in:
Chaozhe.Chen
2016-02-18 15:26:16 +08:00
parent c58b4cc984
commit d28ccb37ff
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
glanceclient/tests/unit/test_shell.py
+6 -3
View File
@@ -686,9 +686,12 @@ class ShellCacheSchemaTest(testutils.TestCase):
self.shell._cache_schemas(self._make_args(options),
client, home_dir=self.cache_dir)
os.path.exists.assert_any_call(self.prefix_path)
os.path.exists.assert_any_call(self.cache_files[0])
os.path.exists.assert_any_call(self.cache_files[1])
exists_mock.assert_has_calls([
mock.call(self.prefix_path),
mock.call(self.cache_files[0]),
mock.call(self.cache_files[1]),
mock.call(self.cache_files[2])
])
self.assertEqual(4, exists_mock.call_count)
self.assertEqual(0, open.mock_calls.__len__())