Enable hacking checks

Enabled following hacking checks from tox.ini:
- H233 Python 3.x incompatible use of print operator
- H303 no wildcard import
- H404 multi line docstring should start with a summary

Change-Id: I2553bcd3e80c00acc08d135a1d2dadfb6cda49fe
Partial-Bugs: #1475054
This commit is contained in:
Tin Lam
2016-03-25 03:07:45 -05:00
parent 04e1ea73a5
commit cd5925bc60
8 changed files with 29 additions and 40 deletions
+1 -1
View File
@@ -1,3 +1,3 @@
# This is here for compatibility purposes. Once all known OpenStack clients
# are updated to use glanceclient.exc, this file should be removed
from glanceclient.exc import *
from glanceclient.exc import * # noqa
+6 -9
View File
@@ -52,7 +52,7 @@ from glanceclient import exc
def verify_callback(host=None):
"""
"""Provide wrapper for do_verify_callback.
We use a partial around the 'real' verify_callback function
so that we can stash the host value without holding a
@@ -87,7 +87,7 @@ def do_verify_callback(connection, x509, errnum,
def host_matches_cert(host, x509):
"""
"""Verify the certificate identifies the host.
Verify that the x509 certificate we have received
from 'host' correctly identifies the server we are
@@ -187,7 +187,7 @@ class HTTPSAdapter(adapters.HTTPAdapter):
class HTTPSConnectionPool(connectionpool.HTTPSConnectionPool):
"""
"""A replacement for the default HTTPSConnectionPool.
HTTPSConnectionPool will be instantiated when a new
connection is requested to the HTTPSAdapter. This
@@ -232,10 +232,8 @@ class OpenSSLConnectionDelegator(object):
class VerifiedHTTPSConnection(HTTPSConnection):
"""
"""Extended OpenSSL HTTPSConnection for enhanced SSL support.
Extended HTTPSConnection which uses the OpenSSL library
for enhanced SSL support.
Note: Much of this functionality can eventually be replaced
with native Python 3.3 code.
"""
@@ -325,10 +323,9 @@ class VerifiedHTTPSConnection(HTTPSConnection):
self.context.set_default_verify_paths()
def connect(self):
"""
"""Connect to an SSL port using the OpenSSL library.
Connect to an SSL port using the OpenSSL library
and apply per-connection parameters.
This method also applies per-connection parameters to the connection.
"""
result = socket.getaddrinfo(self.host, self.port, 0,
socket.SOCK_STREAM)
+8 -7
View File
@@ -19,7 +19,7 @@ import six
class _ProgressBarBase(object):
"""
"""A progress bar provider for a wrapped obect.
Base abstract class used by specific class wrapper to show
a progress bar when the wrapped object are consumed.
@@ -51,10 +51,10 @@ class _ProgressBarBase(object):
class VerboseFileWrapper(_ProgressBarBase):
"""
"""A file wrapper with a progress bar.
A file wrapper that show and advance a progress bar
whenever file's read method is called.
The file wrapper shows and advances a progress bar whenever the
wrapped file's read method is called.
"""
def read(self, *args, **kwargs):
@@ -70,10 +70,11 @@ class VerboseFileWrapper(_ProgressBarBase):
class VerboseIteratorWrapper(_ProgressBarBase):
"""
"""An iterator wrapper with a progress bar.
The iterator wrapper shows and advances a progress bar whenever the
wrapped data is consumed from the iterator.
An iterator wrapper that show and advance a progress bar whenever
data is consumed from the iterator.
:note: Use only with iterator that yield strings.
"""