Stephen Finucane
41b436bff7
We already handled request bodies. Now we tackle query parameters. Note that we're only handling GET requests currently since these are the APIs where query parameters are most likely to be present. A future change will add a test to verify that all methods handling GET requests have schemas present. This patch might look huge but every one of these schemas is effectively a no-op since they're empty and have 'additionalProperties = True'. This means there are lots of TODOs left in here which would be nice to tackle in a future API microversion. Change-Id: I80fc84df7c2be908856e6d4033b4922d7b0e9af1 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
129 lines
4.6 KiB
Python
129 lines
4.6 KiB
Python
# Copyright 2011 Grid Dynamics
|
|
# Copyright 2011 OpenStack Foundation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from webob import exc
|
|
|
|
from nova.api.openstack.api_version_request \
|
|
import MAX_PROXY_API_SUPPORT_VERSION
|
|
from nova.api.openstack.compute.schemas import networks as schema
|
|
from nova.api.openstack import wsgi
|
|
from nova.api import validation
|
|
from nova import exception
|
|
from nova.i18n import _
|
|
from nova.network import neutron
|
|
from nova.policies import networks as net_policies
|
|
|
|
_removal_reason = """\
|
|
This %s only works with *nova-network*, which was deprecated in the
|
|
14.0.0 (Newton) release.
|
|
It fails with HTTP 404 starting from microversion 2.36.
|
|
It was removed in the 21.0.0 (Ussuri) release.
|
|
"""
|
|
_removal_reason_action = _removal_reason % 'action'
|
|
_removal_reason_api = _removal_reason % 'API'
|
|
|
|
|
|
def network_dict(context, network):
|
|
if not network:
|
|
return {}
|
|
|
|
fields = ('id', 'cidr', 'netmask', 'gateway', 'broadcast', 'dns1', 'dns2',
|
|
'cidr_v6', 'gateway_v6', 'label', 'netmask_v6')
|
|
admin_fields = ('created_at', 'updated_at', 'deleted_at', 'deleted',
|
|
'injected', 'bridge', 'vlan', 'vpn_public_address',
|
|
'vpn_public_port', 'vpn_private_address', 'dhcp_start',
|
|
'project_id', 'host', 'bridge_interface', 'multi_host',
|
|
'priority', 'rxtx_base', 'mtu', 'dhcp_server',
|
|
'enable_dhcp', 'share_address')
|
|
|
|
# NOTE(mnaser): We display a limited set of fields so users can know what
|
|
# networks are available, extra system-only fields are only visible if they
|
|
# are an admin.
|
|
|
|
if context.is_admin:
|
|
fields += admin_fields
|
|
|
|
result = {}
|
|
for field in fields:
|
|
# we only provide a limited number of fields now that nova-network is
|
|
# gone (yes, two fields of thirty)
|
|
if field == 'id':
|
|
result[field] = network['id']
|
|
elif field == 'label':
|
|
result[field] = network['name']
|
|
else:
|
|
result[field] = None
|
|
|
|
return result
|
|
|
|
|
|
class NetworkController(wsgi.Controller):
|
|
|
|
def __init__(self, network_api=None):
|
|
super(NetworkController, self).__init__()
|
|
# TODO(stephenfin): 'network_api' is only being passed for use by tests
|
|
self.network_api = network_api or neutron.API()
|
|
|
|
@wsgi.Controller.api_version("2.1", MAX_PROXY_API_SUPPORT_VERSION)
|
|
@wsgi.expected_errors(())
|
|
@validation.query_schema(schema.index_query)
|
|
def index(self, req):
|
|
context = req.environ['nova.context']
|
|
context.can(net_policies.POLICY_ROOT % 'list',
|
|
target={'project_id': context.project_id})
|
|
networks = self.network_api.get_all(context)
|
|
result = [network_dict(context, net_ref) for net_ref in networks]
|
|
return {'networks': result}
|
|
|
|
@wsgi.Controller.api_version("2.1", MAX_PROXY_API_SUPPORT_VERSION)
|
|
@wsgi.expected_errors(404)
|
|
@validation.query_schema(schema.show_query)
|
|
def show(self, req, id):
|
|
context = req.environ['nova.context']
|
|
context.can(net_policies.POLICY_ROOT % 'show',
|
|
target={'project_id': context.project_id})
|
|
|
|
try:
|
|
network = self.network_api.get(context, id)
|
|
except exception.NetworkNotFound:
|
|
msg = _("Network not found")
|
|
raise exc.HTTPNotFound(explanation=msg)
|
|
return {'network': network_dict(context, network)}
|
|
|
|
@wsgi.expected_errors(410)
|
|
@wsgi.action("disassociate")
|
|
@wsgi.removed('21.0.0', _removal_reason_action)
|
|
@validation.schema(schema.disassociate)
|
|
def _disassociate_host_and_project(self, req, id, body):
|
|
raise exc.HTTPGone()
|
|
|
|
@wsgi.expected_errors(410)
|
|
@wsgi.removed('21.0.0', _removal_reason_api)
|
|
def delete(self, req, id):
|
|
raise exc.HTTPGone()
|
|
|
|
@wsgi.expected_errors(410)
|
|
@wsgi.removed('21.0.0', _removal_reason_api)
|
|
@validation.schema(schema.create)
|
|
def create(self, req, body):
|
|
raise exc.HTTPGone()
|
|
|
|
@wsgi.expected_errors(410)
|
|
@wsgi.removed('21.0.0', _removal_reason_api)
|
|
@validation.schema(schema.add)
|
|
def add(self, req, body):
|
|
raise exc.HTTPGone()
|