This commit addresses some of the non-blocking comments/nits
in[1].
Main changes:
- Add 'source' property to InstancePCIRequest object
which contains the source of the request i.e. flavor alias
or neutron port. this avoids duplication of logic
and comments in the code.
- Move class method create_skeleton_migrate_vifs from
LiveMigrateData object to VIFMigrateData object as
frankly its more sensible to have it there.
- Separate unit test, test__claim_pci_for_instance_vifs,
to two separate unit tests for clarity.
- Some trivial nits and typos.
[1] https://review.opendev.org/#/c/620115/
Change-Id: I292a0e2d840bbf657ba6d0932f9a3decbcb2778f
Adrian Chiris
7824909048