Johannes Erdfelt
27c8086028
Fixes bug 1286187 Neither execute_get_output() nor execute() would wait for the process to fully finish executing. This could potentially create a race condition where commands execute in a different order than intended. Also, for execute() it could cause a process to never finish executing if it generates enough output to block writing to the pipe. Change-Id: I3404f4b3ca1cddeec2f3e7b393817a6ccc42bec7
39 lines
1.2 KiB
Python
39 lines
1.2 KiB
Python
#!/usr/bin/env python
|
|
# Copyright 2011 OpenStack Foundation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
|
|
import os
|
|
import subprocess
|
|
|
|
|
|
def execute_get_output(*command):
|
|
"""Execute and return stdout."""
|
|
devnull = open(os.devnull, 'w')
|
|
command = map(str, command)
|
|
proc = subprocess.Popen(command, close_fds=True,
|
|
stdout=subprocess.PIPE, stderr=devnull)
|
|
devnull.close()
|
|
stdout = proc.communicate()[0]
|
|
return stdout.strip()
|
|
|
|
|
|
def execute(*command):
|
|
"""Execute without returning stdout."""
|
|
devnull = open(os.devnull, 'w')
|
|
command = map(str, command)
|
|
subprocess.call(command, close_fds=True, stdout=devnull, stderr=devnull)
|
|
devnull.close()
|