Ghanshyam Mann
ba52a32a13
Current tests do not have good test coverage of existing policies. Either tests for policies do not exist or if they exist then they do not cover the actual negative and positive testing. For Example, if any policy with default rule as admin only then test should verify: - policy check pass with context having admin or server owner - policy check fail with context having non-admin and not server owner As discussed in policy-defaults-refresh, to change the policies with new default roles and scope_type, we need to have the enough testing coverage of existing policy behavior. When we will add the scope_type in policies or new default roles, then these test coverage will be extended to adopt the new changes and also make sure we do not break the existing behavior. This commit covers the testing coverage of existing lock server policies. Partial implement blueprint policy-defaults-refresh Change-Id: I4de714cc988e8dc25209869c28268ef390a12d33
128 lines
5.2 KiB
Python
128 lines
5.2 KiB
Python
# Copyright 2011 OpenStack Foundation
|
|
# Copyright 2013 IBM Corp.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
import six
|
|
|
|
from nova.api.openstack import api_version_request
|
|
from nova.api.openstack import common
|
|
from nova.api.openstack.compute import lock_server as lock_server_v21
|
|
from nova import exception
|
|
from nova.tests.unit.api.openstack.compute import admin_only_action_common
|
|
from nova.tests.unit import fake_instance
|
|
|
|
|
|
class LockServerTestsV21(admin_only_action_common.CommonTests):
|
|
lock_server = lock_server_v21
|
|
controller_name = 'LockServerController'
|
|
_api_version = '2.1'
|
|
|
|
def setUp(self):
|
|
super(LockServerTestsV21, self).setUp()
|
|
self.controller = getattr(self.lock_server, self.controller_name)()
|
|
self.compute_api = self.controller.compute_api
|
|
self.stub_out('nova.api.openstack.compute.lock_server.'
|
|
'LockServerController',
|
|
lambda *a, **kw: self.controller)
|
|
|
|
def test_lock_unlock(self):
|
|
args_map = {'_lock': ((), {"reason": None})}
|
|
body_map = {'_lock': {"lock": None}}
|
|
self._test_actions(['_lock', '_unlock'], args_map=args_map,
|
|
body_map=body_map)
|
|
|
|
def test_lock_unlock_with_non_existed_instance(self):
|
|
body_map = {'_lock': {"lock": None}}
|
|
self._test_actions_with_non_existed_instance(['_lock', '_unlock'],
|
|
body_map=body_map)
|
|
|
|
@mock.patch.object(common, 'get_instance')
|
|
def test_unlock_with_any_body(self, get_instance_mock):
|
|
instance = fake_instance.fake_instance_obj(
|
|
self.req.environ['nova.context'])
|
|
get_instance_mock.return_value = instance
|
|
# This will pass since there is no schema validation.
|
|
body = {'unlock': {'blah': 'blah'}}
|
|
|
|
with mock.patch.object(self.compute_api, 'unlock') as mock_lock:
|
|
self.controller._unlock(self.req, instance.uuid, body=body)
|
|
mock_lock.assert_called_once_with(
|
|
self.req.environ['nova.context'], instance)
|
|
|
|
@mock.patch.object(common, 'get_instance')
|
|
def test_lock_with_empty_dict_body_is_valid(self, get_instance_mock):
|
|
# Empty dict with no key in the body is allowed.
|
|
instance = fake_instance.fake_instance_obj(
|
|
self.req.environ['nova.context'])
|
|
get_instance_mock.return_value = instance
|
|
body = {'lock': {}}
|
|
|
|
with mock.patch.object(self.compute_api, 'lock') as mock_lock:
|
|
self.controller._lock(self.req, instance.uuid, body=body)
|
|
mock_lock.assert_called_once_with(
|
|
self.req.environ['nova.context'], instance, reason=None)
|
|
|
|
|
|
class LockServerTestsV273(LockServerTestsV21):
|
|
|
|
def setUp(self):
|
|
super(LockServerTestsV273, self).setUp()
|
|
self.req.api_version_request = api_version_request.APIVersionRequest(
|
|
'2.73')
|
|
|
|
@mock.patch.object(common, 'get_instance')
|
|
def test_lock_with_reason_V273(self, get_instance_mock):
|
|
instance = fake_instance.fake_instance_obj(
|
|
self.req.environ['nova.context'])
|
|
get_instance_mock.return_value = instance
|
|
reason = "I don't want to work"
|
|
body = {'lock': {"locked_reason": reason}}
|
|
|
|
with mock.patch.object(self.compute_api, 'lock') as mock_lock:
|
|
self.controller._lock(self.req, instance.uuid, body=body)
|
|
mock_lock.assert_called_once_with(
|
|
self.req.environ['nova.context'], instance, reason=reason)
|
|
|
|
def test_lock_with_reason_exceeding_255_chars(self):
|
|
instance = fake_instance.fake_instance_obj(
|
|
self.req.environ['nova.context'])
|
|
reason = 's' * 256
|
|
body = {'lock': {"locked_reason": reason}}
|
|
|
|
exp = self.assertRaises(exception.ValidationError,
|
|
self.controller._lock, self.req, instance.uuid, body=body)
|
|
self.assertIn('is too long', six.text_type(exp))
|
|
|
|
def test_lock_with_reason_in_invalid_format(self):
|
|
instance = fake_instance.fake_instance_obj(
|
|
self.req.environ['nova.context'])
|
|
reason = 256
|
|
body = {'lock': {"locked_reason": reason}}
|
|
|
|
exp = self.assertRaises(exception.ValidationError,
|
|
self.controller._lock, self.req, instance.uuid, body=body)
|
|
self.assertIn("256 is not of type 'string'", six.text_type(exp))
|
|
|
|
def test_lock_with_invalid_paramater(self):
|
|
# This will fail from 2.73 since we have a schema check that allows
|
|
# only locked_reason
|
|
instance = fake_instance.fake_instance_obj(
|
|
self.req.environ['nova.context'])
|
|
body = {'lock': {'blah': 'blah'}}
|
|
|
|
exp = self.assertRaises(exception.ValidationError,
|
|
self.controller._lock, self.req, instance.uuid, body=body)
|
|
self.assertIn("('blah' was unexpected)", six.text_type(exp))
|