Commit Graph

260 Commits

Author SHA1 Message Date
Jenkins 6ba704730e Merge "Enable InnoDB checking" 2012-05-01 17:50:17 +00:00
Johannes Erdfelt 97f0f80ada Trivial spelling fix
Change-Id: Ib5ba181886a073742ace4a8927061f5d4dcd0773
2012-04-30 15:38:59 +00:00
Joe Gordon 60b1154b14 Imports to human alphabetical order
Problems identified by enabling N306 in run_tests.sh

Change-Id: Ifddfe58da020dd041bcbbf5f14941514a09f61c1
2012-04-26 16:25:49 -07:00
Sean Dague f28dcaa183 Enable InnoDB checking
Addresses bug #978304

Refactor _walk_versions for readability and pep8 compliance

Change-Id: I94d17f2ec81a4115ae3ea3863c79b88462ceb835
2012-04-26 15:46:45 -04:00
Johannes Erdfelt b05d1d8982 Use instance_get_by_uuid since we're looking up a UUID
Change-Id: I60869ace0890dcef887a7984e41abd9cf16ea9e3
2012-04-26 16:17:41 +00:00
Johannes Erdfelt 8a8f0712af Use nova_uuid attribute instead of trying to parse out name_label
The name_label parsing code is out-of-date since key support was
added to the format string, but it's not needed anymore since
the internal uuid was added to other-config for a while now.

Change-Id: I2902320ae7118e42cd3d18f2d6d0fab0fcbec687
2012-04-26 15:20:28 +00:00
Joe Gordon 82e1019edb Number of missing imports should always be shown
In tools/hacking.py

Change-Id: I1219dcc140594be97fc680981a122157fed2e279
2012-04-24 13:00:13 -07:00
Jenkins d10077d18e Merge "Improved tools/hacking.py" 2012-04-24 17:35:10 +00:00
Joe Gordon 7ee0d7848d Improved tools/hacking.py
* cleaner output
* fix bug 980009
* Fix N201
* N306: alphabetical order imports
* N401: docstring start
* N402: one line docstring start
* N403: multi line docstring end
* Until fixed, N40* will be disabled by default

Change-Id: I9addafdaa7a1f8fb950e14a5409f661dec6c7b87
2012-04-24 09:29:43 -07:00
Johannes Erdfelt 8f9c2bae1e nova.virt.xenapi_conn -> nova.virt.xenapi.connection
This fixes a couple of references that were missed in the recent move

Change-Id: I653b8b85294838a39f9d805bef094938f692e7be
2012-04-19 23:45:35 +00:00
Johannes Erdfelt 6d750971fd xenapi_conn -> xenapi.connection
This keeps all of the XenAPI related code together in one directory,
like libvirt.

Change-Id: I1de51eb8bcead0695e9f8ede466416e0257d0148
2012-04-12 14:41:53 +00:00
Dan Prince 6489b23c93 Remove python-novaclient dependency from nova.
Nova should not depend on python-novaclient. Remove it.

Note: In order to get unit tests to pass I had to add in
a temporary dependency on httplib2. This is due to the fact
that pip installing glance does not properly setup all
the dependencies. See LP Bug #975483 for details.

Fixes LP Bug #978992.

Change-Id: I50c00139f9dc303223601230fd962abac977cd5e
2012-04-11 11:13:27 -04:00
Jenkins 1e133f60c7 Merge "Improved localization testing." 2012-04-10 19:14:02 +00:00
Yuriy Taraday 4fe6f839bd Improved localization testing.
Moved localization tests to tools/hacking.py.

Change-Id: I903b90dfb09a46a72b1c64c30301f90661999f5b
2012-04-10 22:01:55 +04:00
Joe Gordon 2c14f1818d Remove nova Direct API
blueprint remove-nova-direct-api

Change-Id: I3229f8d7f37d66fcd6b978966f3a428a69e08bb1
2012-04-10 09:23:30 -04:00
Jenkins 689fd02c06 Merge "HACKING fixes, sqlalchemy fix." 2012-04-09 23:41:10 +00:00
Brian Elliott 549616d122 bug 968452
Update test-requires to use pep8>=1.0.  Removed PEP8 warning suppression
around 3-arg raises.

Change-Id: Ib4ed42adc167aa1e8078619a36b409b76b9f5d73
2012-04-09 19:06:03 +00:00
Yuriy Taraday f7a6c58d92 HACKING fixes, sqlalchemy fix.
Add exceptions to hacking.py make sqlalchemy stuff legal and prevent
clutter.

Change-Id: I44b100b4c0c4dfcec81beea7aba2d8598d5a08d0
2012-04-09 18:00:40 +04:00
Russell Bryant 70a712921f Remove nova.rpc.impl_carrot.
This module was marked as deprecated and scheduled for removal in Essex.
Remove it now that Folsom development is open.  nova.rpc.impl_kombu
should be used instead.

This patch also removes nova.testing.fake.rabbit, since as far as I can
tell, it isn't used anymore and was the last thing still using the
carrot dependency.

Change-Id: I8cfb2d09ee5eed439ec1d152261f7097faf08ad6
2012-04-02 18:35:26 -04:00
Alex Meade 998e57b296 Updated docstrings in /tools as per HACKING
Change-Id: I06db6653784eb298ef7f78ebe99865b9c635aade
2012-03-28 15:25:45 -04:00
Joe Gordon 02afb4d60c Remove tools/nova-debug
Broken and outdated (last updated on Mon Jun 27 2011)

Change-Id: I3ed67430e01c2db531b89bc3ffd6e7b174791fbc
2012-03-22 13:17:08 -07:00
Jenkins 8bec631791 Merge "Hack to fixup absolute pybasedir in nova.conf.sample" 2012-03-13 18:06:54 +00:00
Rick Harris e6cf7fc7f4 Add VDI chain cleanup script.
References bug 949477

Change-Id: I819d4ed56675a4ef4e46adca2978b433386e128d
2012-03-09 23:27:48 +00:00
Mark McLoughlin 9120a7df37 Hack to fixup absolute pybasedir in nova.conf.sample
We want to avoid e.g. /home/markmc or /Users/vishvananda in this
file.

/usr/lib/python/site-packages is pretty dumb too, but it's suffices
as an example.

Change-Id: I851841a30ca01790c7b5a9b6bdbd160f4a84467c
2012-03-09 15:37:02 +00:00
Johannes Erdfelt cdf0753526 Require a more recent version of glance
Recent changes started using a recently added exception to
glance.common.exception, so update pip-requires to require a version
of glance that has that.

Change-Id: I56ca02bdb98a8e2ed40dcd8f08c9d69d5a043add
2012-03-08 16:59:00 +00:00
Yuriy Taraday 01a938f7fe HACKING fixes, all but sqlalchemy.
Looks like this fixes all HACKING problems that were around.
Thanks to Dina Belova and Alexander Kovalev for this work.

Change-Id: I8157f0d4890184c1216aab63ef7180ee8b7a184d
2012-03-07 12:51:39 +04:00
Hengqing Hu 9a042d3c50 Remove trailing whitespaces in regular file
Fixes bug #945346

Change-Id: I07a303c2e503e50d7138585c683e0d1310339276
2012-03-07 13:43:37 +08:00
Vishvananda Ishaya 6ee8a083f0 Cleans up the create_conf tool
* Makes it adhere to the config file format
 * Puts the sample output in etc/nova/nova.conf.sample
 * Updating sample is as easy as ./tools/conf/generate_sample.sh

Change-Id: I01e72cb58dd598a74f50c2c17f102d24df325f2e
2012-03-06 17:53:17 -08:00
Jenkins 01dbefb085 Merge "Nova options tool enhancements" 2012-03-06 18:05:16 +00:00
Joe Gordon e8bc00eff2 Add assertRaises check to tools/hacking.py as N202
Change-Id: I25113bcc73ff642cae146f0558f319684b4568d0
2012-03-05 14:09:57 -08:00
Mike Pittaro 2fbccc0c69 Clean stale lockfiles on service startup : fixes bug 785955
Adds cleanup_files_locks() to nova/utils, which cleans up stale locks
left behind after process failures.

Adds a call to clean up locks on service startup for nova-api, nova-cert,
nova-compute, nova-network, nova-objectstore, and nova-scheduler.

Adds tools/clean_file_locks.py, which can be used to manually clean
stale locks.

Change-Id: I752e0b24d3c7fc5f1dc290da355cbd7f430789b8
2012-02-24 15:10:33 -08:00
Zhongyue Luo cce1c217eb Nova options tool enhancements
Fixes bug #936898

1. Just import the modules and only look at nova.flags.FLAGS
   when they're all imported

2. ConfigOpts is iterable, there should be no need to iterate
   the private FLAGS._opts dict

3. Output should be .ini style

4. The output should only contain comments
   i.e. each option default should be commented out

Change-Id: I15835bb437bc6d575e8311d7c55b3a29d67b006d
2012-02-24 07:10:40 +08:00
Monty Taylor 51210081a8 Support tox-based unittests.
Change-Id: I6a0a616a979688595762e6b772d77a14f1968070
2012-02-20 11:54:37 -08:00
Jenkins 757d8aa6f5 Merge "Support non-UTC timestamps in changes-since filter" 2012-02-20 07:19:39 +00:00
Zhongyue Luo 9e16a2edb1 nova.conf sample tool
Fixes bug #918621

A tool to generate a sample nova.conf file

Change-Id: I2646d7e674ef3d1759558e820f051cc5e7f3b4ae
2012-02-18 07:51:46 +08:00
Eoghan Glynn c30193fbf5 Support non-UTC timestamps in changes-since filter
Fixes nova aspect of lp 837464

Prevously only Zulu time was supported in the changes-since filter,
i.e. timestamps formatted as %Y-%m-%dT%H:%M:%SZ

We now support arbitrary timezones, with the offset from UTC expressed
via the ISO 8601 ±hh:mm notation.

Microsecond accurracy is also optionally supported in timestamps.

Notes:

- nova.utils.parse_isotime(), isotime() & normalized_time() are
  prime candidates for promotion to openstack-common, as these
  methods were duplicated from my corresponding glance patch:

    https://review.openstack.org/#change,4198

- this patch introduces a new dependency on python-iso8601, which
  has already been packaged for Fedora, EPEL and Ubuntu/Debian.

Change-Id: I89b45f4f3d910606c578d927420f78cea94f4e3b
2012-02-17 20:40:51 +00:00
Monty Taylor 4a4c274c83 Get rid of distutils.extra.
We moved to DistUtilsExtra because it promised a more automatic workflow
from setup.py. It doesn't actually deliver though, and it also vomits
warnings during setup.py usage, and also breaks pip integration.

So this is going back to babel. Mostly folks shouldn't need to know
anything about this. We'll need to update the translations import
jobs in Jenkins, and we might need to add a corresponding translations
upload job that runs post-merge.

Translations installation doesn't fully work - but it actually wasn't fully
working before. Getting this part of the project done now though is a
pre-requisite for using tox for multi-python testing (tox starts by
creating an sdist tarball and then installing it into the venv, which
is just 100% broken with DistUtilsExtra)

Change-Id: I126e1bcfab0656eab6ca10de67d3d2aaa8b844f3
2012-02-08 19:30:39 -08:00
Jenkins 082750832e Merge "Require newer versions of SA and SA-Migrate" 2012-02-08 21:21:03 +00:00
Rick Harris 71247a627e Require newer versions of SA and SA-Migrate
Fixes bug 928637

Change-Id: I27d06d945449f70a6da00c1f5d306bd5fe43b253
2012-02-08 05:33:40 +00:00
Thierry Carrez 71410724cd Remove ajaxterm from Nova
Removes copy of ajaxterm code, nova-ajax-console-proxy,
and support for get_ajax_console from Nova proper.

Implements blueprint remove-ajaxterm
Fixes bug 917963

Change-Id: I2c0ff427c53c0f63a18b10475d6b4cbe9a085d83
2012-02-07 21:14:31 +01:00
Brian Waldon 3759bcf3fc Excise M2Crypto!
This required rewriting our Diffie-Hellman-Merkle implementation for
set_admin_password in xen. Fixes bug 917851.

Change-Id: Ic4cdcc06221f003aec2dcd5ba05a1a9ad19d39c9
2012-02-02 10:12:58 -08:00
Brian Lamar 7de828108a Boto 2.2.x failes. Capping pip-requires at 2.1.1
Fixes bug 924933

Change-Id: I808daedf9a860a8ef153785693cbc49a0a25f49c
2012-02-01 10:55:43 -05:00
Joe Gordon 9a08e00548 Add HACKING compliance testing to run_test.sh
Tests so far:
N101 TODO format
N201 Except format
N301 One import per line
N302 import only modules
N303 Invalid Import
N304 Relative Import

Change-Id: I33c021b842e7199b1f5f1f699ea17f7fa5f8ca49
2012-01-24 10:54:17 -08:00
Joe Gordon 236190c452 Cleanup Imports to match HACKING guidelines
found using https://github.com/cloudscaling/nova-HACKING

Change-Id: Ic010f0407e7a139f0f6436af2e72e817c140a4c3
2012-01-18 11:30:22 -08:00
Zhongyue Luo 1611c23928 greenlet version inconsistency
Fixes Bug #917003

The latest version of greenlet is installed in install_venv.py while
the version required is set to 0.3.1 in pip-requires.

Change-Id: I145deb46a8edc41e87634dc5ca839baf5acd8065
2012-01-16 01:58:39 -05:00
Daniel P. Berrange d97b64b6e6 Tell users what is about to be installed via sudo
Rather than just giving users the sudo password prompt immediately,
actually tell them what is about to be installed, so they know
whether it is reasonable to be entering their password.

Change-Id: Ic0c1de812be119384753895531a008075b13494e
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-01-05 16:08:04 +00:00
Jenkins dc3d6ee43e Merge "PEP8 remove direct type comparisons" 2012-01-03 17:53:05 +00:00
lzyeval ae1654bc59 PEP8 remove direct type comparisons
Fixes bug #910763

According to PEP8,
- Object type comparisons should always use isinstance() instead
      of comparing types directly.

        Yes: if isinstance(obj, int):

        No: if type(obj) is type(1):

      When checking if an object is a string, keep in mind that it might be a
      unicode string too! In Python 2.3, str and unicode have a common base
      class, basestring, so you can do:

        if isinstance(obj, basestring):

Change-Id: I7c0fdecf99872f5b8f72b2c2ed4f5c539c33def1
2012-01-03 11:12:42 +08:00
Monty Taylor f9ec38578b Install a good version of pip in the venv.
Change-Id: I1059824aae8c5bf1a65de6cfaef96fef0f68d8a3
2012-01-02 13:35:57 -08:00
Jenkins 435d6d8bb5 Merge "Rename .nova-venv to .venv." 2011-12-09 00:53:27 +00:00