fix the N402 errors that have slipped in in the last 48 hrs since
starting this patch series.
fix an N401 error that our scanner current can't find because it
only looks for doc strings on classes and defs.
this is the xeno's paradox of patch series, but we're getting close.
Change-Id: I4a763bb4c812335d853eae05c72464f18ab93297
Looks like this fixes all HACKING problems that were around.
Thanks to Dina Belova and Alexander Kovalev for this work.
Change-Id: I8157f0d4890184c1216aab63ef7180ee8b7a184d
Move openvswitch-nova to 23 in the boot order.
The openvswitch-nova init.d script used on XenServer has been set to run
at 96 in the boot order (i.e. very late). This is inconvenient, because it
means that it runs after the firstboot scripts, so if you want to do an
automated install of a compute VM, say, you can't rely on the Open vSwitch
rules being ready.
23 places it after the networking start up (9 through 14) and before the
firstboot scripts (24).
Change-Id: I5c4f2f02c78bd7b8ccc6cac4d6549209a6dcbdb0
If domain 0 has an IP address on a given bridge, then add a flow rule to
allow traffic to leave that port. This allows for the case where domain 0
and the tenant network are sharing a bridge, which is useful in non-production
environments.
At the same time, simplify the interface to ovs_configure_base_rules.py.
There is no need to pass the bridge in, because it's implicit in the selection
of the physical interface, and can be obtained using ovs-vsctl iface-to-br.
Having made these two changes, it's now reasonable to apply flow rules to all
interfaces as a default (if not overridden in the sysconfig file).
Change-Id: I2a33ed55246d49b0e4f57db909e1b40351d27602