Lots of details on the global requirements patch that
this Depends-On.
Essentially, nova tests are broken with the oslo.vmware
release and we need to block this version.
Partial-Bug: #1459021
Depends-On: Icf1ce8dbb4b2c0b6b627d5d8be0b85a42e99c784
Change-Id: I4b9a471c9783dff769cbdec2e534bb0157f141f6
we should just use what oslo.vmware requires. Transitive
dependency should be enough for Nova.
Remove a few imports in a test case to pass the nova
policy of "if any explicit import then need an entry
in requirements".
Also remove tests relating to suds as oslo.vmware uses
suds and any of these tests should be there instead.
Co-Authored-By: Victor Stinner <vstinner@redhat.com>
Change-Id: I28f29d3e5745c21b99dc0cf9eb0cfe4f95dffd17
Commit cb3fdc56b5 moved the
oslo.vmware package. This does the same with the suds package.
The suds package is only imported in the vmwareapi virt driver
code (and tests) so it's purely optional if you're using the vmware
driver or not, so move it to test-requirements.txt.
Change-Id: I2d2b832c163bb6707ef20aa908e8df48118aaeb8
The oslo_vmware package is only imported in the vmwareapi virt driver
code (and tests) so it's purely optional if you're using the vmware
driver or not, so move it to test-requirements.txt.
Change-Id: I1fc07badfe3652681872c6e4d78c347158f21a5f
Adds a barbican keymgr wrapper to the key manager interface in
nova. This allows barbican to be configured as the key manager
for encryption keys in nova. The wrapper translates calls from
the existing key manager interface to python-barbicanclient.
Change-Id: I110c7ceada48de28cee1169b643b12407f21b36c
Implements: blueprint encryption-with-barbican
DocImpact
Commit 4b9bec3a1c removed the mocking of
nova.virt.libvirt.host.Host.get_connection to use fakelibvirt instead,
but if you don't have libvirt-python in your venv the tests fail, so
fakelibvirt in it's current form wasn't actually working for all tests.
This change updates the uri_whitelist in the init method of the
fakelibvirt Connection class to add some other URIs found in other parts
of the libvirt code (the LibvirtDriver.uri static method).
Removes the unnecessary 'xen:///system' whitelisted URI.
Since libvirt-python is no longer needed to run the libvirt driver
unit tests, it's removed from test-requirements.txt.
Closes-Bug: #1414708
Change-Id: Id7aefe9bf21dc3d0e2db42e668faf28e926aea43
This patch cleans up the requirement list to remove old modules that are
not used anymore directly by Nova.
Change-Id: Ifb0548aff985669ea0c4df470b8881edc3f2c26c
Release notes:
http://git.openstack.org/cgit/openstack-dev/hacking/tag/?id=0.10.0
* Remove references in tox.ini to removed rules
* Fix minor changes (H501)
* Clarify that H306 (imports in alphabetical order shouldn't be skipped)
* Ignore H238: check for old style class declarations
* Temporary skip W292, fix in next patch.
Change-Id: I6d990a564df6a312bd09b2a152315bbdba732082
The pylint tests have been broken for several months and
the Jenkins job has also been disabled. There has been
no sign of attempts to address this, so just delete what
remains of the pylint support so developers don't mistakenly
think it is supposed to work with patches they are submitting.
Change-Id: Ifacc99e45acb0e9a72be6c31113e0cf073354f02
This commit removes the local copy of subunit-trace in nova and uses
the packaged version of the utility in tempest-lib.
Change-Id: I1ed2fea9ff3d8194628b722684492f8ba7a3cabb
The fixtures in nova/openstack/common will be removed as
they have been removed from oslo-incubator. We should use
the fixtures from oslotest.
Note that oslotest uses mox3 instead of mox and some of the
tests were failing as a result which have been fixed in this
review. Only the failing tests have been fixed, so you will
see some tests use a mix of mock and mox3 as a result.
Based on feedback from Nova core, all existing references
to 'import mox' have been switched over to mox3 as well.
Change-Id: Ifa9dbb6f9bb1a358d815ae80cf928b65d5dcf5bd
Use the common session loading parameters and the session object for
talking to cinder.
There are some related changes in this patch.
Firstly auth_token middleware now provides an authentication plugin that
can be used along with the session object to make requests under the
user's authentication. This will largely replace the information
required on the context object.
This authentication plugin is not serializable though and so it cannot
be transferred over RPC so we introduce a simple authentication plugin
that reconstructs the required information from the context.
When talking to cinder we now create a global session object (think of
this like keeping open a connection pool object) and use the
authentication plugin to send requests to cinder.
I also condense the cinder tests as they are largely copied and pasted
between v1 and v2 and this solves fixing them in two places.
DocImpact: Renames cinder's timeout, insecure and CA certificates
parameters to the parameters used by the common session object. Adds
options for using client certificates with connection.
Change-Id: I7afe604503b8597c16be61d2a66a10b94269a219
We can install libvirt-python bindings from pypi now because the libvirt
devs are supporting pypi packages and the version of libvirt we are
testing nova master against is new enough to link against that pypi
package.
Making this switch will better isolate nova test environments as all
dependencies can be installed without any site packages leaking into
virtualenvs. It will also make the dependency on libvirt-python a bit
more explicit.
Change-Id: I2890702869f05a02ad5e2ecb419db06433231b36
Hacking 0.9.0 had a minor bug so require 0.9.1 or higher.
In order to keep this patch to just a requirements bump, ignore new and
stricter hacking rules that are being triggered. Fixing up the code and
turning these on is out of scope of this patch and is for future patches.
Change-Id: Iafbd4adae8c6b446d53b62dfc490eab8e76a43ac
oslosphinx is now available as a replacement for oslo.sphinx that
won't conflict with oslo.config in virtual envs.
Change-Id: I7c116f816af895261e76af385ee3e9288e6fa70f
Closes-Bug: #1277168
There are several changes which depend on using mock rather than mox for
unit tests:
https://review.openstack.org/#/c/42474/https://review.openstack.org/#/c/43161/
And the general trend seems to be to move from using mock over mox for
new tests (see blueprint mox-to-mock-conversion).
And given mock is listed in the global-requirements.txt file in the
openstack/requirements project, we should require mock for nova so we
can start using it.
Change-Id: Iaa0f233c28de2f92a237ee6d089858ee10bc6d2f
There was a bug in hacking 0.6 that broke H202, assertRaises Exception
too broad, so switch to Hacking 0.7 and fix the one H202 bug.
Change-Id: Ia3fb22d1524022479d7068cb84a3bdf7ca19f408
Since the `ldap` module isn't a requirement, we need to guard against it not
being present.
One reason this is needed is that we generate sample configs by walking the
module import tree. If a module isn't importable--because a depenency isn't
met, for example--the module's configs are omitted from the sample config,
requiring the developer to manually add them back.
Fixes bug 1208560
Change-Id: Ie23b7fad118ecadabf7e36703934fa933f4e8c50
So we can start using new hacking 0.6 checks.
Since hacking 0.6 pins pep8, pyflakes and flake8 they can be removed
from test-requires. For any unfixed checks list them in tox.ini
Fix a H103, 'Header does not match Apache 2.0 License notice' that
leaked in
Change-Id: I652fe3270f1c37afdd386bfae7c4b27b6abcfa06
OpenStack Proposal Bot