womax/nova
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hacking: Always use 'assertIs(Not)None'

Browse Source 
This is per the OpenStack style guidelines.

Change-Id: Ia706045fe3524b6b5e1db0140672776d481a0c01
This commit is contained in:
Stephen Finucane
2016-08-31 10:52:41 +01:00
parent 2be8f702eb
commit ebc0219a50
3 changed files with 27 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
HACKING.rst
+2 -2
View File
@@ -26,8 +26,8 @@ Nova Specific Commandments
assertIsInstance(A, B).
- [N317] Change assertEqual(type(A), B) by optimal assert like
assertIsInstance(A, B)
- [N318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert like
assertIsNone(A)
- [N318] Change assertEqual(A, None) or assertIs(A, None) to optimal assert
like assertIsNone(A)
- [N319] Validate that debug level logs are not translated.
- [N320] Setting CONF.* attributes directly in tests is forbidden. Use
self.flags(option=value) instead.