From dc4d1a63ee60be3823eb763de64f9b4979638f8d Mon Sep 17 00:00:00 2001 From: Sean Dague Date: Mon, 19 Sep 2016 12:41:32 -0400 Subject: [PATCH] stub out instances_path in unit tests 3 unit tests were trying to write to instance_path without redirecting it to a temporary location, which leaks directories into your working directory. This sets that when needed. Change-Id: I115210163147a41e88ba43c4df100465b5159066 --- nova/tests/unit/virt/libvirt/test_driver.py | 1 + nova/tests/unit/virt/libvirt/test_imagebackend.py | 1 + 2 files changed, 2 insertions(+) diff --git a/nova/tests/unit/virt/libvirt/test_driver.py b/nova/tests/unit/virt/libvirt/test_driver.py index 9f0b56c212..e264fa235b 100644 --- a/nova/tests/unit/virt/libvirt/test_driver.py +++ b/nova/tests/unit/virt/libvirt/test_driver.py @@ -16275,6 +16275,7 @@ class LibvirtDriverTestCase(test.NoDBTestCase): mock_build_device_metadata, mock_set_host_enabled, mock_write_to_file, exists=None): + self.flags(instances_path=self.useFixture(fixtures.TempDir()).path) mock_build_device_metadata.return_value = None mock_supports_direct_io.return_value = True diff --git a/nova/tests/unit/virt/libvirt/test_imagebackend.py b/nova/tests/unit/virt/libvirt/test_imagebackend.py index 5d548f8746..b51811be97 100644 --- a/nova/tests/unit/virt/libvirt/test_imagebackend.py +++ b/nova/tests/unit/virt/libvirt/test_imagebackend.py @@ -1684,6 +1684,7 @@ class BackendTestCase(test.NoDBTestCase): def setUp(self): super(BackendTestCase, self).setUp() self.flags(enabled=False, group='ephemeral_storage_encryption') + self.flags(instances_path=self.useFixture(fixtures.TempDir()).path) self.INSTANCE['ephemeral_key_uuid'] = None def get_image(self, use_cow, image_type):