diff --git a/doc/source/contributor/code-review.rst b/doc/source/contributor/code-review.rst index 89d2457899..a887bbb92d 100644 --- a/doc/source/contributor/code-review.rst +++ b/doc/source/contributor/code-review.rst @@ -235,10 +235,12 @@ Microversion API If a new microversion API is added, the following needs to happen: -* A new patch for the microversion API change in python-novaclient side - should be submitted before the microversion change in Nova is merged. - See :python-novaclient-doc:`Adding support for a new microversion - ` in python-novaclient for more details. +* A new patch for the microversion API change in both python-novaclient + and in python-openstackclient should be submitted before the microversion + change in Nova is merged. See :python-novaclient-doc:`Adding support for a + new microversion ` in python-novaclient for more + details. See also `Add support for 'server group create --rule' parameter`_ + patch as example how to support a new microversion in the openstack client. * If the microversion changes the response schema, a new schema and test for the microversion must be added to Tempest. The microversion change in Nova should not be merged until the Tempest test is submitted and at least @@ -247,6 +249,8 @@ If a new microversion API is added, the following needs to happen: should reference the Change-Id of the Tempest test for reviewers to identify it. +.. _`Add support for 'server group create --rule' parameter`: https://review.opendev.org/#/c/761597 + Notifications =============