womax/nova
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove default override for RBAC config options

Browse Source 
RBAC config options enforce_scope and enforce_new_defaults
were disabled by default in oslo.policy and Nova had to override
the default value to enable those by default. Now oslo.policy
(4.4.0 onwards[1]) changed the default values[2] and enabled
by default for all the services. OpenStack service does not need
to override the default anymore.

NOTE: There is no change in behaviour here, oslo.policy provides the
same configuration that Nova has overridden till now.

[1] https://review.opendev.org/c/openstack/releases/+/925032
[2] https://review.opendev.org/c/openstack/oslo.policy/+/924283

Depends-On: https://review.opendev.org/c/openstack/requirements/+/925464

Change-Id: Ic0b5a75f01024e322ecbcd49f8caae0a6ab5c048
This commit is contained in:
Ghanshyam Mann
2024-08-01 10:54:44 -07:00
committed by Ghanshyam
parent bb2d7f9cad
commit c79a73bd42
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nova/policy.py
+3 -5
View File
@@ -42,14 +42,12 @@ saved_file_rules = []
KEY_EXPR = re.compile(r'%\((\w+)\)s') KEY_EXPR = re.compile(r'%\((\w+)\)s')
# TODO(gmann): Remove overriding the default value of config options # TODO(gmann): Remove overriding the default value of config options
# 'policy_file', 'enforce_scope', and 'enforce_new_defaults' once # 'policy_file' once oslo_policy change its default value to what
# oslo_policy change their default value to what is overridden here. # is overridden here.
DEFAULT_POLICY_FILE = 'policy.yaml' DEFAULT_POLICY_FILE = 'policy.yaml'
opts.set_defaults( opts.set_defaults(
cfg.CONF, cfg.CONF,
DEFAULT_POLICY_FILE, DEFAULT_POLICY_FILE)
enforce_scope=True,
enforce_new_defaults=True)
def reset(): def reset():
requirements.txt
+1 -1
View File
@@ -42,7 +42,7 @@ oslo.utils>=4.12.1 # Apache-2.0
oslo.db>=10.0.0 # Apache-2.0 oslo.db>=10.0.0 # Apache-2.0
oslo.rootwrap>=5.15.0 # Apache-2.0 oslo.rootwrap>=5.15.0 # Apache-2.0
oslo.messaging>=14.1.0 # Apache-2.0 oslo.messaging>=14.1.0 # Apache-2.0
oslo.policy>=3.11.0 # Apache-2.0 oslo.policy>=4.4.0 # Apache-2.0
oslo.privsep>=2.6.2 # Apache-2.0 oslo.privsep>=2.6.2 # Apache-2.0
oslo.i18n>=5.1.0 # Apache-2.0 oslo.i18n>=5.1.0 # Apache-2.0
oslo.service>=2.8.0 # Apache-2.0 oslo.service>=2.8.0 # Apache-2.0