From b8fea0351895f468d0b5e72087adde5e8a788ab1 Mon Sep 17 00:00:00 2001 From: EdLeafe Date: Thu, 18 Feb 2016 21:46:27 +0000 Subject: [PATCH] Remove unused config option 'fake_call' This option isn't used anywhere, and should be removed. Closes-Bug: #1547068 Change-Id: Id2983a3c31fb767992976d3eff9649cc6ff4d8c3 --- nova/conf/network.py | 11 ----------- nova/tests/unit/virt/libvirt/test_driver.py | 1 - ...-unused-config-opt-fake-call-37a56f6ec15f7d90.yaml | 4 ++++ 3 files changed, 4 insertions(+), 12 deletions(-) create mode 100644 releasenotes/notes/remove-unused-config-opt-fake-call-37a56f6ec15f7d90.yaml diff --git a/nova/conf/network.py b/nova/conf/network.py index 1f7b2b8edf..306e9e9a9e 100644 --- a/nova/conf/network.py +++ b/nova/conf/network.py @@ -284,17 +284,6 @@ Possible values: Any positive integer. The default is 5. -Related options: - - ``use_neutron`` -"""), - cfg.BoolOpt("fake_call", - default=False, - help=""" -When this option is True, calls are made locally instead of being placed in the -queue. However, all usage of this config option have been removed, so it -currently has no effect at all. - Related options: ``use_neutron`` diff --git a/nova/tests/unit/virt/libvirt/test_driver.py b/nova/tests/unit/virt/libvirt/test_driver.py index a48ed6870e..8e1ae2c3be 100644 --- a/nova/tests/unit/virt/libvirt/test_driver.py +++ b/nova/tests/unit/virt/libvirt/test_driver.py @@ -599,7 +599,6 @@ class LibvirtConnTestCase(test.NoDBTestCase): def setUp(self): super(LibvirtConnTestCase, self).setUp() - self.flags(fake_call=True) self.user_id = 'fake' self.project_id = 'fake' self.context = context.get_admin_context() diff --git a/releasenotes/notes/remove-unused-config-opt-fake-call-37a56f6ec15f7d90.yaml b/releasenotes/notes/remove-unused-config-opt-fake-call-37a56f6ec15f7d90.yaml new file mode 100644 index 0000000000..6cbc152fd2 --- /dev/null +++ b/releasenotes/notes/remove-unused-config-opt-fake-call-37a56f6ec15f7d90.yaml @@ -0,0 +1,4 @@ +other: + - The network configuration option 'fake_call' has been removed. It hasn't + been used for several cycles, and has no effect on any code, so there + should be no impact.