From 3f0879ccc3c702280a2be0a3449a9622a56e8560 Mon Sep 17 00:00:00 2001 From: Dan Smith Date: Wed, 15 May 2024 11:45:01 -0700 Subject: [PATCH] Fix hacking test with syntax error This hacking test has a syntax error in it. On older pythons, this does not prevent us from finding the second popen() use, but on python 3.12 it does. Change-Id: Ib74dc030118e0cb9fab548b112d32ce080969a15 --- nova/tests/unit/test_hacking.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nova/tests/unit/test_hacking.py b/nova/tests/unit/test_hacking.py index 4914367798..7dbb36484b 100644 --- a/nova/tests/unit/test_hacking.py +++ b/nova/tests/unit/test_hacking.py @@ -517,7 +517,7 @@ class HackingTestCase(test.NoDBTestCase): foobar_cmd = "foobar -get -beer" answer = os.popen(foobar_cmd).read() - if answer == nok": + if answer == "nok": try: os.popen(os.popen('foobar -beer -please')).read()