From aa67211acb701f02937f6dfe58899be873c388ed Mon Sep 17 00:00:00 2001
From: Matt Riedemann <mriedem.os@gmail.com>
Date: Thu, 17 May 2018 11:23:13 -0400
Subject: [PATCH] Make nova-lvm run in check on libvirt changes and compute API
 tests

This changes the nova-lvm job to run in the check queue on libvirt
driver changes only, and only runs the tempest compute API tests
to save time since we don't need to run things like the cinder,
glance, neutron etc API tests.

Once we're comfortable with the stability of this job we can
make it voting and gating.

This is in response to bug 1771700 which could have been prevented
if we were gating on the nova-lvm job on libvirt changes.

Change-Id: Ieaf00bcb6cb885e544d05b6f7276b6470b123258
Related-Bug: #1771700
---
 .zuul.yaml                   | 27 ++++++++++++++++++++++++---
 devstack/tempest-dsvm-lvm-rc |  5 +++++
 2 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/.zuul.yaml b/.zuul.yaml
index 2e1443335c..2d6a2abb8a 100644
--- a/.zuul.yaml
+++ b/.zuul.yaml
@@ -114,10 +114,31 @@
     name: nova-lvm
     parent: nova-dsvm-base
     description: |
-      Run standard integration tests using LVM image backend. This is useful if
-      there are tests touching this code.
+      Run tempest compute API tests using LVM image backend. This only runs
+      against nova/virt/libvirt/* changes.
     run: playbooks/legacy/nova-lvm/run.yaml
     post-run: playbooks/legacy/nova-lvm/post.yaml
+    # Copy irrelevant-files from nova-dsvm-base and then exclude anything
+    # that is not in the nova/virt/libvirt/* tree (besides the actual zuul
+    # playbook and tempest rc files so this can be self-testing).
+    irrelevant-files:
+      - ^(?!.zuul.yaml)(?!playbooks/legacy/nova-lvm/)(?!devstack/tempest-dsvm-lvm-rc)(?!nova/virt/libvirt/).*$
+      - ^(placement-)?api-.*$
+      - ^(test-|)requirements.txt$
+      - ^.*\.rst$
+      - ^.git.*$
+      - ^doc/.*$
+      - ^nova/hacking/.*$
+      - ^nova/locale/.*$
+      - ^nova/tests/.*$
+      - ^releasenotes/.*$
+      - ^setup.cfg$
+      - ^tests-py3.txt$
+      - ^tools/.*$
+      - ^tox.ini$
+    # TODO(mriedem): Make this voting and gating once bug 1771700 is fixed
+    # and we've had enough runs to feel comfortable with this setup.
+    voting: false
 
 - job:
     name: nova-multiattach
@@ -150,6 +171,7 @@
       jobs:
         - nova-cells-v1
         - nova-live-migration
+        - nova-lvm
         - nova-multiattach
         - nova-next
         - nova-tox-functional
@@ -167,4 +189,3 @@
     experimental:
       jobs:
         - nova-caching-scheduler
-        - nova-lvm
diff --git a/devstack/tempest-dsvm-lvm-rc b/devstack/tempest-dsvm-lvm-rc
index ba6aef9f67..eb87ba445b 100644
--- a/devstack/tempest-dsvm-lvm-rc
+++ b/devstack/tempest-dsvm-lvm-rc
@@ -33,6 +33,11 @@
 r="^(?!.*"
 r="$r(?:.*\[.*\bslow\b.*\])"
 
+# Only run compute API tests. The ! here looks confusing but it's to negate
+# the ! at the beginning of the regex since the rest of this is meant to be
+# a backlist.
+r="$r|(?!.*api.compute.*)"
+
 # NOTE(mriedem): resize of non-volume-backed lvm instances does not yet work
 # tempest.api.compute.admin.test_migrations.MigrationsAdminTest.test_list_migrations_in_flavor_resize_situation
 r="$r|(?:.*id\-1b512062\-8093\-438e\-b47a\-37d2f597cd64.*)"