From 0e64efc20f631a012ceafd4fc42043b1e6eb932c Mon Sep 17 00:00:00 2001 From: Eli Qiao Date: Tue, 2 Feb 2016 12:39:58 +0800 Subject: [PATCH] Object: Give more helpful error message in TestServiceVersion It is very helpful when we bump service rpc version since we have test_version() case to cover that, but sometime we do rebase/bump rpc service version we may forget to increae compute_manager's version, in this case test_version give a wrong message will make `new` developer confused, and spend time to do debuging, this patch improves the error message. Change-Id: I64320b5a46aa0543e3d9e8fdd27f6faa3829cf69 --- nova/tests/unit/objects/test_service.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/nova/tests/unit/objects/test_service.py b/nova/tests/unit/objects/test_service.py index 1bee51c552..40c9367c77 100644 --- a/nova/tests/unit/objects/test_service.py +++ b/nova/tests/unit/objects/test_service.py @@ -368,7 +368,8 @@ class TestServiceVersion(test.TestCase): self.assertEqual( current, calculated, 'Changes detected that require a SERVICE_VERSION change. Please ' - 'increment nova.objects.service.SERVICE_VERSION') + 'increment nova.objects.service.SERVICE_VERSION, and make sure it' + 'is equal to nova.compute.manager.ComputeManager.target.version.') def test_version_in_init(self): self.assertRaises(exception.ObjectActionError,