womax/nova
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing descriptions in HACKING.rst

Browse Source 
This patch is a follow-up patch for the following changes.

Ia7bcb40a21a804c7bc6b74f501d95ce2a88b09b5
Ie107a95bc06390ab519d3b3af9b07103a9a14316
I71439580e80d33cff62aba807df2b35164a47cbe

Change-Id: I244396fb96b01ebab875234f25097637ff1b1dbb
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
This commit is contained in:
Takashi Natsume
2022-08-13 23:34:25 +09:00
parent 733a87e612
commit a85d052a22
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
HACKING.rst
+5
View File
@@ -71,6 +71,11 @@ Nova Specific Commandments
- [N367] Disallow aliasing the mock.Mock and similar classes in tests. - [N367] Disallow aliasing the mock.Mock and similar classes in tests.
- [N368] Reject if the mock.Mock class is used as a replacement value instead of and - [N368] Reject if the mock.Mock class is used as a replacement value instead of and
instance of a mock.Mock during patching in tests. instance of a mock.Mock during patching in tests.
- [N369] oslo_concurrency.lockutils.ReaderWriterLock() or
fasteners.ReaderWriterLock() does not function correctly
with eventlet patched code. Use nova.utils.ReaderWriterLock() instead.
- [N370] Don't use or import six
- [N371] You must explicitly import python's mock: ``from unittest import mock``
Creating Unit Tests Creating Unit Tests
------------------- -------------------