From cabb6999a31603f57cbc782631daf42b3111ce02 Mon Sep 17 00:00:00 2001 From: Stephen Finucane Date: Fri, 16 Feb 2024 18:10:39 +0000 Subject: [PATCH] api: Add missing Controller inheritance This has many of the attributes of the 'Controller' class but does not subclass it. This means we are missing attributes like 'wsgi_actions' as well as helper methods like 'version_select', 'api_version', 'is_valid_body', and 'check_for_versions_intersection'. We correctly subclass for every other controller and there's no reason for us not to do so here, so correct this oversight. Change-Id: Ib89e2e02e8c85cc27f5b55caca5711e773959288 Signed-off-by: Stephen Finucane --- nova/api/openstack/compute/security_groups.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/nova/api/openstack/compute/security_groups.py b/nova/api/openstack/compute/security_groups.py index b10308393f..6ee5ee528a 100644 --- a/nova/api/openstack/compute/security_groups.py +++ b/nova/api/openstack/compute/security_groups.py @@ -369,7 +369,9 @@ class SecurityGroupRulesController(SecurityGroupControllerBase, raise exc.HTTPBadRequest(explanation=exp.format_message()) -class ServerSecurityGroupController(SecurityGroupControllerBase): +class ServerSecurityGroupController( + SecurityGroupControllerBase, wsgi.Controller +): @wsgi.expected_errors(404) def index(self, req, server_id):