womax/nova
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tune up db.instance_get_all_uuids_by_hosts

Browse Source 
When instance_get_all_uuids_by_hosts was added [1] some follow up
cleanups where suggested. This change provides them:

* removal of redundance in docstring
* moving docstring to the public method, rather than the private
  implementation
* more clarity on the type of the default (defaultdict(list)) and
  the implications thereof
* Using an sa.bindparam in the 'in_' call. This requires that the
  SQLAlchemy requirment be raised to at least 1.2.0 where the feature
  was added. 1.2.19, the latest bugfix release, is chosen.

[1] If92fe8b75d20a738f37e2a74c52c59bfc699a74f

Change-Id: Ib538ab070d73b06ddeb9fea3af149304e40952ec
This commit is contained in:
Chris Dent
2019-09-02 12:44:50 +01:00
parent ef6e49d5bc
commit 8ed9c9434f
6 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
requirements.txt
+1 -1
View File
@@ -3,7 +3,7 @@
# process, which may cause wedges in the gate later.
pbr!=2.1.0,>=2.0.0 # Apache-2.0
SQLAlchemy!=1.1.5,!=1.1.6,!=1.1.7,!=1.1.8,>=1.0.10 # MIT
SQLAlchemy>=1.2.19 # MIT
decorator>=3.4.0 # BSD
eventlet!=0.20.1,>=0.20.0 # MIT
Jinja2>=2.10 # BSD License (3 clause)