From 7e39a3bf38d8184f1a13b03893289ec83faedfbf Mon Sep 17 00:00:00 2001 From: Mark McLoughlin Date: Fri, 11 Jul 2014 08:07:28 +0100 Subject: [PATCH] libvirt: fix typo in fakelibvirt listAllDomains() It looks like this code isn't used in the tests at all since we replace it with a fake in the list_instance_domains() tests ... so what's the point of it? We could also add tests for the function in test_fakelibvirt, but that feels rather pointless too? Change-Id: I8fa5301ad86e2eb117f40d26a7cfe7b9d86c873a --- nova/tests/virt/libvirt/fakelibvirt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nova/tests/virt/libvirt/fakelibvirt.py b/nova/tests/virt/libvirt/fakelibvirt.py index 7dee9cd166..b76fcc886b 100644 --- a/nova/tests/virt/libvirt/fakelibvirt.py +++ b/nova/tests/virt/libvirt/fakelibvirt.py @@ -689,7 +689,7 @@ class Connection(object): if flags & VIR_CONNECT_LIST_DOMAINS_ACTIVE: if vm.state != VIR_DOMAIN_SHUTOFF: vms.append(vm) - if flags & VIR_CONNECT_LIST_DOMAINS_ACTIVE: + if flags & VIR_CONNECT_LIST_DOMAINS_INACTIVE: if vm.state == VIR_DOMAIN_SHUTOFF: vms.append(vm) return vms