From bd54341f8609e372b64f05dac383632bf87343af Mon Sep 17 00:00:00 2001 From: Ryan Rossiter Date: Tue, 19 Jan 2016 14:50:07 +0000 Subject: [PATCH] Add note to ComputeNode.numa_topology As the ComputeNode is being converted away from a dict, it was discovered that numa_topology is held in the ComputeNode as a StringField, not an ObjectField containing a NUMATopology. Because changing types within minor versions of an object is not a good thing to do, a note is added to change the field over to use the NUMATopology object in the next major version of the ComputeNode object (2.0). Change-Id: Ife9f7aefbe64638521abcd27a9e182612fab46c7 --- nova/objects/compute_node.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/nova/objects/compute_node.py b/nova/objects/compute_node.py index 2ab2ec34b7..b8a42e8f3a 100644 --- a/nova/objects/compute_node.py +++ b/nova/objects/compute_node.py @@ -71,6 +71,9 @@ class ComputeNode(base.NovaPersistentObject, base.NovaObject, 'metrics': fields.StringField(nullable=True), 'stats': fields.DictOfNullableStringsField(nullable=True), 'host_ip': fields.IPAddressField(nullable=True), + # TODO(rlrossit): because of history, numa_topology is held here as a + # StringField, not a NUMATopology object. In version 2 of ComputeNode + # this will be converted over to a fields.ObjectField('NUMATopology') 'numa_topology': fields.StringField(nullable=True), # NOTE(pmurray): the supported_hv_specs field maps to the # supported_instances field in the database