womax/nova
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

api: Add runtime check for query additionalProperties

Browse Source 
We also fix some types.

Change-Id: Ie1bf7b55f21cafdd311b1c58018a4c815cf7cc65
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane
2025-08-29 11:44:18 +01:00
parent 405948b06d
commit 36cd19b168
1 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nova/api/validation/__init__.py
+19 -7
View File
@@ -57,7 +57,7 @@ class Schemas:
def add_schema( def add_schema(
self, self,
schema: tuple[dict[str, object]], schema: dict[str, object],
min_version: str | None, min_version: str | None,
max_version: str | None, max_version: str | None,
) -> None: ) -> None:
@@ -261,10 +261,12 @@ def schema(
) )
return func(*args, **kwargs) return func(*args, **kwargs)
# we need to use setattr/getattr here else we see attr-defined errors
# since this is not an attribute of Callable
if not hasattr(wrapper, 'request_body_schemas'): if not hasattr(wrapper, 'request_body_schemas'):
wrapper.request_body_schemas = Schemas() setattr(wrapper, 'request_body_schemas', Schemas())
wrapper.request_body_schemas.add_schema( getattr(wrapper, 'request_body_schemas').add_schema(
request_body_schema, min_version, max_version request_body_schema, min_version, max_version
) )
@@ -332,10 +334,12 @@ def response_body_schema(
raise raise
return response return response
# we need to use setattr/getattr here else we see attr-defined errors
# since this is not an attribute of Callable
if not hasattr(wrapper, 'response_body_schemas'): if not hasattr(wrapper, 'response_body_schemas'):
wrapper.response_body_schemas = Schemas() setattr(wrapper, 'response_body_schemas', Schemas())
wrapper.response_body_schemas.add_schema( getattr(wrapper, 'response_body_schemas').add_schema(
response_body_schema, min_version, max_version response_body_schema, min_version, max_version
) )
@@ -428,13 +432,21 @@ def query_schema(request_query_schema, min_version=None,
_strip_additional_query_parameters(request_query_schema, req) _strip_additional_query_parameters(request_query_schema, req)
return func(*args, **kwargs) return func(*args, **kwargs)
# we need to use setattr/getattr here else we see attr-defined errors
# since this is not an attribute of Callable
if not hasattr(wrapper, 'request_query_schemas'): if not hasattr(wrapper, 'request_query_schemas'):
wrapper.request_query_schemas = Schemas() setattr(wrapper, 'request_query_schemas', Schemas())
wrapper.request_query_schemas.add_schema( getattr(wrapper, 'request_query_schemas').add_schema(
request_query_schema, min_version, max_version request_query_schema, min_version, max_version
) )
return wrapper return wrapper
if (
api_version_request.APIVersionRequest(min_version) >=
api_version_request.APIVersionRequest('2.102')
):
assert request_query_schema['additionalProperties'] is False
return add_validator return add_validator