womax/nova
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Convert features not supported error to HTTPBadRequest

Browse Source 
There is inconsistency on return code nova API return
for "Feature not supported/implemented'. Current return
code are 400, 409, and 403.
- 400 case: Example: Multiattach Swap Volume Not Supported
- 403 case: Cyborg integration
- 409 case: Example: Operation Not Supported For SEV ,
  Operation Not Supported For VTPM

In xena PTG, we agreed to fix this by returning 400 in all cases
- L446: https://etherpad.opendev.org/p/nova-xena-ptg

This commit convert all the features not supported error to
HTTPBadRequest(400).

To avoid converting every NotSupported inherited exception
in API controller to HTTPBadRequest generic conversion is
added in expected_errors() decorator.

Closes-Bug: #1938093

Change-Id: I410924668a73785f1bfe5c79827915d72e1d9e03
This commit is contained in:
Ghanshyam Mann
2021-08-26 19:46:09 -05:00
parent 7c1ca501ee
commit 1b6a6e3916
21 changed files with 163 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nova/tests/unit/api/openstack/compute/test_migrate_server.py
+15 -5
View File
@@ -140,6 +140,15 @@ class MigrateServerTestsV21(admin_only_action_common.CommonTests):
allowed=0)
self._test_migrate_exception(exc_info, webob.exc.HTTPForbidden)
def test_migrate_raise_badrequest_for_accelerator(self):
exc_info = exception.ForbiddenWithAccelerators()
self._test_migrate_exception(exc_info, webob.exc.HTTPBadRequest)
def test_migrate_raise_badrequest_for_vdpainterface(self):
exc_info = exception.OperationNotSupportedForVDPAInterface(
instance_uuid=uuids.instance, operation='foo')
self._test_migrate_exception(exc_info, webob.exc.HTTPBadRequest)
def _test_migrate_live_succeeded(self, param):
instance = self._stub_instance_get()
@@ -290,21 +299,21 @@ class MigrateServerTestsV21(admin_only_action_common.CommonTests):
self._test_migrate_live_failed_with_exception(
exception.OperationNotSupportedForSEV(
instance_uuid=uuids.instance, operation='foo'),
expected_exc=webob.exc.HTTPConflict,
expected_exc=webob.exc.HTTPBadRequest,
check_response=False)
def test_migrate_live_vtpm_not_supported(self):
self._test_migrate_live_failed_with_exception(
exception.OperationNotSupportedForVTPM(
instance_uuid=uuids.instance, operation='foo'),
expected_exc=webob.exc.HTTPConflict,
expected_exc=webob.exc.HTTPBadRequest,
check_response=False)
def test_migrate_live_vdpa_interfaces_not_supported(self):
self._test_migrate_live_failed_with_exception(
exception.OperationNotSupportedForVDPAInterface(
instance_uuid=uuids.instance, operation='foo'),
expected_exc=webob.exc.HTTPConflict,
expected_exc=webob.exc.HTTPBadRequest,
check_response=False)
def test_migrate_live_pre_check_error(self):
@@ -319,9 +328,10 @@ class MigrateServerTestsV21(admin_only_action_common.CommonTests):
@mock.patch('nova.compute.api.API.live_migrate',
side_effect=exception.ForbiddenWithAccelerators)
def test_live_migration_raises_http_forbidden(self, mock_migrate):
def test_live_migration_raises_badrequest_for_accelerators(
self, mock_migrate):
body = self._get_migration_body(host='hostname')
self.assertRaises(webob.exc.HTTPForbidden,
self.assertRaises(webob.exc.HTTPBadRequest,
self.controller._migrate_live,
self.req, fakes.FAKE_UUID, body=body)