# All Rights Reserved.
#
#    Licensed under the Apache License, Version 2.0 (the "License"); you may
#    not use this file except in compliance with the License. You may obtain
#    a copy of the License at
#
#         http://www.apache.org/licenses/LICENSE-2.0
#
#    Unless required by applicable law or agreed to in writing, software
#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
#    License for the specific language governing permissions and limitations
#    under the License.

from os_brick import encryptors
from unittest import mock

import ddt
from oslo_serialization import jsonutils
from oslo_utils.fixture import uuidsentinel as uuids

from nova import block_device
from nova import context
from nova import exception
from nova import objects
from nova.objects import fields
from nova import test
from nova.tests.unit import fake_block_device
from nova.tests.unit import fake_instance
from nova.tests.unit import matchers
from nova.virt import block_device as driver_block_device
from nova.virt import driver
from nova.virt import fake as fake_virt
from nova.volume import cinder

ATTACHMENT_ID = uuids.attachment_id


@ddt.ddt
class TestDriverBlockDevice(test.NoDBTestCase):
    # os-brick>=5.1 now uses external file system locks instead of internal
    # locks so we need to set up locking
    REQUIRES_LOCKING = True
    # This is used to signal if we're dealing with a new style volume
    # attachment (Cinder v3.44 flow).
    attachment_id = None

    driver_classes = {
        'swap': driver_block_device.DriverSwapBlockDevice,
        'ephemeral': driver_block_device.DriverEphemeralBlockDevice,
        'volume': driver_block_device.DriverVolumeBlockDevice,
        'volsnapshot': driver_block_device.DriverVolSnapshotBlockDevice,
        'volimage': driver_block_device.DriverVolImageBlockDevice,
        'volblank': driver_block_device.DriverVolBlankBlockDevice,
        'image': driver_block_device.DriverImageBlockDevice,
    }

    swap_bdm_dict = block_device.BlockDeviceDict(
        {'id': 1, 'instance_uuid': uuids.instance,
         'device_name': '/dev/sdb1',
         'source_type': 'blank',
         'destination_type': 'local',
         'delete_on_termination': True,
         'guest_format': 'swap',
         'disk_bus': 'scsi',
         'volume_size': 2,
         'boot_index': -1,
         'encrypted': False,
         'encryption_secret_uuid': None,
         'encryption_format': None,
         'encryption_options': None})

    swap_driver_bdm = {
        'device_name': '/dev/sdb1',
        'swap_size': 2,
        'disk_bus': 'scsi',
        'encrypted': False,
        'encryption_secret_uuid': None,
        'encryption_format': None,
        'encryption_options': None}

    ephemeral_bdm_dict = block_device.BlockDeviceDict(
        {'id': 2, 'instance_uuid': uuids.instance,
         'device_name': '/dev/sdc1',
         'source_type': 'blank',
         'destination_type': 'local',
         'disk_bus': 'scsi',
         'device_type': 'disk',
         'volume_size': 4,
         'guest_format': 'ext4',
         'delete_on_termination': True,
         'boot_index': -1,
         'encrypted': False,
         'encryption_secret_uuid': None,
         'encryption_format': None,
         'encryption_options': None})

    ephemeral_driver_bdm = {
        'device_name': '/dev/sdc1',
        'size': 4,
        'device_type': 'disk',
        'guest_format': 'ext4',
        'disk_bus': 'scsi',
        'encrypted': False,
        'encryption_secret_uuid': None,
        'encryption_format': None,
        'encryption_options': None}

    volume_bdm_dict = block_device.BlockDeviceDict(
        {'id': 3, 'instance_uuid': uuids.instance,
         'device_name': '/dev/sda1',
         'source_type': 'volume',
         'disk_bus': 'scsi',
         'device_type': 'disk',
         'volume_size': 8,
         'destination_type': 'volume',
         'volume_id': 'fake-volume-id-1',
         'guest_format': 'ext4',
         'connection_info': '{"fake": "connection_info"}',
         'delete_on_termination': False,
         'boot_index': 0})

    volume_driver_bdm = {
        'mount_device': '/dev/sda1',
        'connection_info': {"fake": "connection_info"},
        'delete_on_termination': False,
        'disk_bus': 'scsi',
        'device_type': 'disk',
        'guest_format': 'ext4',
        'boot_index': 0,
        'volume_type': None}

    volume_bdm_dict_without_conn_info = block_device.BlockDeviceDict(
        {'id': 3, 'instance_uuid': uuids.instance,
         'device_name': '/dev/sda1',
         'source_type': 'volume',
         'disk_bus': 'scsi',
         'device_type': 'disk',
         'volume_size': 8,
         'destination_type': 'volume',
         'volume_id': 'fake-volume-id-1',
         'guest_format': 'ext4',
         'connection_info': None,
         'delete_on_termination': False,
         'boot_index': 0})

    volume_driver_bdm_without_conn_info = {
        'attachment_id': None,
        'mount_device': '/dev/sda1',
        'connection_info': {},
        'delete_on_termination': False,
        'disk_bus': 'scsi',
        'device_type': 'disk',
        'guest_format': 'ext4',
        'boot_index': 0,
        'volume_type': None}

    volsnapshot_bdm_dict = block_device.BlockDeviceDict(
        {'id': 4, 'instance_uuid': uuids.instance,
         'device_name': '/dev/sda2',
         'delete_on_termination': True,
         'volume_size': 3,
         'disk_bus': 'scsi',
         'device_type': 'disk',
         'source_type': 'snapshot',
         'destination_type': 'volume',
         'connection_info': '{"fake": "connection_info"}',
         'snapshot_id': 'fake-snapshot-id-1',
         'volume_id': 'fake-volume-id-2',
         'boot_index': -1,
         'volume_type': None})

    volsnapshot_driver_bdm = {
        'mount_device': '/dev/sda2',
        'connection_info': {"fake": "connection_info"},
        'delete_on_termination': True,
        'disk_bus': 'scsi',
        'device_type': 'disk',
        'guest_format': None,
        'boot_index': -1,
        'volume_type': None}

    volimage_bdm_dict = block_device.BlockDeviceDict(
        {'id': 5, 'instance_uuid': uuids.instance,
         'device_name': '/dev/sda2',
         'delete_on_termination': True,
         'volume_size': 1,
         'disk_bus': 'scsi',
         'device_type': 'disk',
         'source_type': 'image',
         'destination_type': 'volume',
         'connection_info': '{"fake": "connection_info"}',
         'image_id': 'fake-image-id-1',
         'volume_id': 'fake-volume-id-2',
         'boot_index': -1,
         'volume_type': None})

    volimage_driver_bdm = {
        'mount_device': '/dev/sda2',
        'connection_info': {"fake": "connection_info"},
        'delete_on_termination': True,
        'disk_bus': 'scsi',
        'device_type': 'disk',
        'guest_format': None,
        'boot_index': -1,
        'volume_type': None}

    volblank_bdm_dict = block_device.BlockDeviceDict(
        {'id': 6, 'instance_uuid': uuids.instance,
         'device_name': '/dev/sda2',
         'delete_on_termination': True,
         'volume_size': 3,
         'disk_bus': 'scsi',
         'device_type': 'disk',
         'source_type': 'blank',
         'destination_type': 'volume',
         'connection_info': '{"fake": "connection_info"}',
         'snapshot_id': 'fake-snapshot-id-1',
         'boot_index': -1,
         'volume_type': None})

    volblank_driver_bdm = {
        'mount_device': '/dev/sda2',
        'connection_info': {"fake": "connection_info"},
        'delete_on_termination': True,
        'disk_bus': 'scsi',
        'device_type': 'disk',
        'guest_format': None,
        'boot_index': -1,
        'volume_type': None}

    image_bdm_dict = block_device.BlockDeviceDict(
        {'id': 7, 'instance_uuid': uuids.instance,
         'device_name': '/dev/vda',
         'source_type': 'image',
         'destination_type': 'local',
         'disk_bus': 'virtio',
         'device_type': 'disk',
         'guest_format': 'ext4',
         'boot_index': 0,
         'image_id': 'fake-image-id-1',
         'volume_size': 5,
         'encrypted': True,
         'encryption_secret_uuid': uuids.secret,
         'encryption_format': 'plain',
         'encryption_options': None})

    image_driver_bdm = {
        'device_name': '/dev/vda',
        'device_type': 'disk',
        'guest_format': 'ext4',
        'disk_bus': 'virtio',
        'boot_index': 0,
        'image_id': 'fake-image-id-1',
        'size': 5,
        'encrypted': True,
        'encryption_secret_uuid': uuids.secret,
        'encryption_format': 'plain',
        'encryption_options': None}

    def setUp(self):
        super(TestDriverBlockDevice, self).setUp()
        self.volume_api = mock.MagicMock(autospec=cinder.API)
        self.virt_driver = mock.MagicMock(autospec=driver.ComputeDriver)
        self.context = context.RequestContext('fake_user',
                                              'fake_project')
        # create bdm objects for testing
        self.swap_bdm = fake_block_device.fake_bdm_object(
            self.context, self.swap_bdm_dict)
        self.image_bdm = fake_block_device.fake_bdm_object(
            self.context, self.image_bdm_dict)
        self.ephemeral_bdm = fake_block_device.fake_bdm_object(
            self.context, self.ephemeral_bdm_dict)
        self.volume_bdm = fake_block_device.fake_bdm_object(
            self.context, self.volume_bdm_dict)
        self.volume_bdm_without_conn_info = fake_block_device.fake_bdm_object(
            self.context, self.volume_bdm_dict_without_conn_info)
        self.volsnapshot_bdm = fake_block_device.fake_bdm_object(
            self.context, self.volsnapshot_bdm_dict)
        self.volimage_bdm = fake_block_device.fake_bdm_object(
            self.context, self.volimage_bdm_dict)
        self.volblank_bdm = fake_block_device.fake_bdm_object(
            self.context, self.volblank_bdm_dict)

        # Set the attachment_id on our fake class variables which we have
        # to do in setUp so that any attachment_id set by a subclass will
        # be used properly.
        for name in ('volume', 'volsnapshot', 'volimage', 'volblank'):
            for attr in ('%s_bdm', '%s_driver_bdm'):
                bdm = getattr(self, attr % name)
                bdm['attachment_id'] = self.attachment_id

    def stub_volume_create(self, volume):
        # For any test that creates a volume (boot from volume where the source
        # type is blank/image/snapshot), we'll also be creating an attachment
        # so set the self.attachment_id value on the test and stub out the
        # attachment_create method.
        self.volume_api.create.return_value = volume
        self.attachment_id = ATTACHMENT_ID
        self.volume_api.attachment_create.return_value = {'id': ATTACHMENT_ID}

    @mock.patch('nova.virt.block_device.LOG')
    @mock.patch('os_brick.encryptors')
    def test_driver_detach_passes_failed(self, enc, log):
        virt = mock.MagicMock()
        virt.detach_volume.side_effect = exception.DeviceDetachFailed(
            device='sda', reason='because testing')
        driver_bdm = self.driver_classes['volume'](self.volume_bdm)
        inst = mock.MagicMock(),
        vol_api = mock.MagicMock()

        # Make sure we pass through DeviceDetachFailed,
        # but don't log it as an exception, just a warning
        self.assertRaises(exception.DeviceDetachFailed,
                          driver_bdm.driver_detach,
                          self.context, inst, vol_api, virt)
        self.assertFalse(log.exception.called)
        self.assertTrue(log.warning.called)
        vol_api.roll_detaching.assert_called_once_with(self.context,
                                                       driver_bdm.volume_id)

    def test_no_device_raises(self):
        for name, cls in self.driver_classes.items():
            bdm = fake_block_device.fake_bdm_object(
                    self.context, {'no_device': True})
            self.assertRaises(driver_block_device._NotTransformable,
                              cls, bdm)

    def _test_driver_device(self, name):
        db_bdm = getattr(self, "%s_bdm" % name)
        test_bdm = self.driver_classes[name](db_bdm)
        expected = getattr(self, "%s_driver_bdm" % name)
        self.assertThat(expected, matchers.DictMatches(test_bdm))

        for k, v in db_bdm.items():
            field_val = getattr(test_bdm._bdm_obj, k)
            if isinstance(field_val, bool):
                v = bool(v)
            self.assertEqual(field_val, v)

        for field, value in expected.items():
            # Test that all driver bdm fields are available as both attrs and
            # dict values
            self.assertEqual(test_bdm[field], value)
            self.assertEqual(getattr(test_bdm, field), value)

            test_value = mock.sentinel.value
            if field in test_bdm._proxy_as_attr:
                # We can't set a versioned object field to a sentinel because
                # it's an invalid type. It's not worth creating valid example
                # values for all possible field types just for this, so we just
                # test setting it to its current value. This at least
                # exercises the code path without being a maintenance burden.
                test_value = value

            # Test that we can set values via either attribute or dict
            test_bdm[field] = test_value
            self.assertEqual(getattr(test_bdm, field), test_value)

            setattr(test_bdm, field, value)
            self.assertEqual(test_bdm[field], value)

            # Reset the value
            test_bdm[field] = value

        # Test passthru attributes
        for passthru in test_bdm._proxy_as_attr:
            self.assertEqual(getattr(test_bdm, passthru),
                             getattr(test_bdm._bdm_obj, passthru))

        # Make sure that all others raise _invalidType
        for other_name, cls in self.driver_classes.items():
            if other_name == name:
                continue
            self.assertRaises(driver_block_device._InvalidType,
                              cls,
                              getattr(self, '%s_bdm' % name))

        def assign_fake_changed_value(test_bdm, field, alias=None):
            # We can't set fake values on enums, like device_type,
            # so skip those.
            if not isinstance(test_bdm._bdm_obj.fields[field],
                              fields.BaseEnumField):
                field_or_alias = alias or field
                if field_or_alias == 'attachment_id':
                    # Must set UUID values on UUID fields.
                    fake_value = ATTACHMENT_ID
                elif isinstance(test_bdm._bdm_obj.fields[field],
                                fields.UUIDField):
                    # Generically handle other UUID fields.
                    fake_value = uuids.fake_value
                elif isinstance(test_bdm._bdm_obj.fields[field],
                                fields.BooleanField):
                    fake_value = not test_bdm[field_or_alias]
                else:
                    fake_value = 'fake_changed_value'
                test_bdm[field_or_alias] = fake_value

        # Test the save method
        with mock.patch.object(test_bdm._bdm_obj, 'save') as save_mock:
            # First test saveable fields.
            for fld, alias in test_bdm._update_on_save.items():
                assign_fake_changed_value(test_bdm, fld, alias=alias)

            test_bdm.save()

            for fld, alias in test_bdm._update_on_save.items():
                self.assertEqual(test_bdm[alias or fld],
                                 getattr(test_bdm._bdm_obj, fld))

            # Then test read-only fields.
            for field in test_bdm._readonly_fields:
                value = test_bdm[field]

                assign_fake_changed_value(test_bdm, field)
                self.assertRaises(AttributeError, test_bdm.save)

                # Reset to original value so this already tested field won't
                # be considered during the next save().
                test_bdm[field] = value

            save_mock.assert_called_once_with()

        def check_save():
            self.assertEqual(set([]), test_bdm._bdm_obj.obj_what_changed())

        # Test that nothing is set on the object if there are no actual changes
        test_bdm._bdm_obj.obj_reset_changes()
        with mock.patch.object(test_bdm._bdm_obj, 'save') as save_mock:
            save_mock.side_effect = check_save
            test_bdm.save()

    def _test_driver_default_size(self, name):
        size = 'swap_size' if name == 'swap' else 'size'
        no_size_bdm = getattr(self, "%s_bdm_dict" % name).copy()
        no_size_bdm['volume_size'] = None

        driver_bdm = self.driver_classes[name](
            fake_block_device.fake_bdm_object(self.context, no_size_bdm))
        self.assertEqual(driver_bdm[size], 0)

        del no_size_bdm['volume_size']

        driver_bdm = self.driver_classes[name](
            fake_block_device.fake_bdm_object(self.context, no_size_bdm))
        self.assertEqual(driver_bdm[size], 0)

    def test_driver_swap_block_device(self):
        self._test_driver_device("swap")

    def test_driver_swap_default_size(self):
        self._test_driver_default_size('swap')

    def test_driver_image_block_device(self):
        self._test_driver_device("image")

    def test_driver_image_default_size(self):
        self._test_driver_default_size('image')

    def test_driver_image_block_device_destination_not_local(self):
        self._test_driver_device('image')
        bdm = self.image_bdm_dict.copy()
        bdm['destination_type'] = 'volume'
        self.assertRaises(driver_block_device._InvalidType,
                          self.driver_classes['image'],
                          fake_block_device.fake_bdm_object(self.context, bdm))

    def test_driver_ephemeral_block_device(self):
        self._test_driver_device("ephemeral")

    def test_driver_ephemeral_default_size(self):
        self._test_driver_default_size('ephemeral')

    def test_driver_volume_block_device(self):
        self._test_driver_device("volume")

        test_bdm = self.driver_classes['volume'](
            self.volume_bdm)
        self.assertEqual(test_bdm['connection_info'],
                         jsonutils.loads(test_bdm._bdm_obj.connection_info))
        self.assertEqual(test_bdm._bdm_obj.id, 3)
        self.assertEqual(test_bdm.volume_id, 'fake-volume-id-1')
        self.assertEqual(test_bdm.volume_size, 8)
        self.assertEqual('fake-volume-id-1', test_bdm.get('volume_id'))

    def test_driver_snapshot_block_device(self):
        self._test_driver_device("volsnapshot")

        test_bdm = self.driver_classes['volsnapshot'](
            self.volsnapshot_bdm)
        self.assertEqual(test_bdm._bdm_obj.id, 4)
        self.assertEqual(test_bdm.snapshot_id, 'fake-snapshot-id-1')
        self.assertEqual(test_bdm.volume_id, 'fake-volume-id-2')
        self.assertEqual(test_bdm.volume_size, 3)
        self.assertEqual('fake-snapshot-id-1', test_bdm.get('snapshot_id'))

    def test_driver_volume_image_block_device(self):
        self._test_driver_device('volimage')

        test_bdm = self.driver_classes['volimage'](
            self.volimage_bdm)
        self.assertEqual(test_bdm._bdm_obj.id, 5)
        self.assertEqual(test_bdm.image_id, 'fake-image-id-1')
        self.assertEqual(test_bdm.volume_size, 1)
        self.assertEqual('fake-image-id-1', test_bdm.get('image_id'))

    def test_driver_volume_image_block_device_destination_local(self):
        self._test_driver_device('volimage')
        bdm = self.volimage_bdm_dict.copy()
        bdm['destination_type'] = 'local'
        self.assertRaises(driver_block_device._InvalidType,
                          self.driver_classes['volimage'],
                          fake_block_device.fake_bdm_object(self.context, bdm))

    def test_driver_blank_block_device(self):
        self._test_driver_device('volblank')

        test_bdm = self.driver_classes['volblank'](
            self.volblank_bdm)
        self.assertEqual(6, test_bdm._bdm_obj.id)
        self.assertIsNone(test_bdm.volume_id)
        self.assertEqual(3, test_bdm.volume_size)
        self.assertIsNone(test_bdm.get('volume_id'))

    def _test_call_wait_func(self, delete_on_termination, delete_fail=False):
        test_bdm = self.driver_classes['volume'](self.volume_bdm)
        test_bdm['delete_on_termination'] = delete_on_termination
        if delete_on_termination and delete_fail:
            self.volume_api.delete.side_effect = Exception()

        wait_func = mock.MagicMock()
        mock_exception = exception.VolumeNotCreated(volume_id='fake-id',
                                                    seconds=1,
                                                    attempts=1,
                                                    volume_status='error')
        wait_func.side_effect = mock_exception

        self.assertRaises(exception.VolumeNotCreated,
                          test_bdm._call_wait_func,
                          context=self.context,
                          wait_func=wait_func,
                          volume_api=self.volume_api,
                          volume_id='fake-id')
        self.assertEqual(delete_on_termination, self.volume_api.delete.called)

    def test_call_wait_delete_volume(self):
        self._test_call_wait_func(True)

    def test_call_wait_delete_volume_fail(self):
        self._test_call_wait_func(True, True)

    def test_call_wait_no_delete_volume(self):
        self._test_call_wait_func(False)

    def test_volume_delete_attachment(
        self,
        include_shared_targets=False,
        delete_attachment_raises=None
    ):
        attachment_id = uuids.attachment
        driver_bdm = self.driver_classes['volume'](self.volume_bdm)
        driver_bdm['attachment_id'] = attachment_id

        elevated_context = self.context.elevated()
        instance_detail = {'id': '123', 'uuid': uuids.uuid,
                           'availability_zone': None}
        instance = fake_instance.fake_instance_obj(self.context,
                                                   **instance_detail)
        connector = {'ip': 'fake_ip', 'host': 'fake_host'}
        volume = {'id': driver_bdm.volume_id,
                  'attach_status': 'attached',
                  'status': 'in-use'}
        if include_shared_targets:
            volume['shared_targets'] = True
            volume['service_uuid'] = uuids.service_uuid

        if delete_attachment_raises:
            self.volume_api.attachment_delete.side_effect = (
                delete_attachment_raises)

        self.virt_driver.get_volume_connector.return_value = connector

        with test.nested(
            mock.patch.object(driver_bdm, '_get_volume', return_value=volume),
            mock.patch('os_brick.initiator.utils.guard_connection'),
        ) as (mock_get_volume, mock_guard):

            driver_bdm.detach(elevated_context, instance,
                              self.volume_api, self.virt_driver,
                              attachment_id=attachment_id)

            mock_guard.assert_called_once_with(volume)
            self.volume_api.attachment_delete.assert_called_once_with(
                elevated_context, attachment_id)

    def test_volume_delete_attachment_with_shared_targets(self):
        self.test_volume_delete_attachment(include_shared_targets=True)

    def test_volume_delete_attachment_raises_attachment_not_found(self):
        self.test_volume_delete_attachment(
            delete_attachment_raises=exception.VolumeAttachmentNotFound(
                attachment_id=uuids.attachment_id))

    @mock.patch.object(encryptors, 'get_encryption_metadata')
    @mock.patch.object(objects.BlockDeviceMapping, 'save')
    def _test_volume_attach(self, driver_bdm, bdm_dict,
                            fake_volume, mock_save, mock_get_encry,
                            fail_check_av_zone=False,
                            driver_attach=False, fail_driver_attach=False,
                            volume_attach=True, fail_volume_attach=False,
                            access_mode='rw', availability_zone=None,
                            multiattach=False, driver_multi_attach=False,
                            fail_with_virt_driver=False,
                            include_shared_targets=False,
                            wait_func=None):
        expected_save_calls = []
        if driver_multi_attach:
            # 'supports_multiattach' is True
            self.virt_driver.capabilities.get.return_value = True
        else:
            # 'supports_multiattach' is False
            self.virt_driver.capabilities.get.return_value = False
        elevated_context = self.context.elevated()
        self.stub_out('nova.context.RequestContext.elevated',
                      lambda s: elevated_context)
        instance_detail = {'id': '123', 'uuid': uuids.uuid,
                           'availability_zone': availability_zone}
        instance = fake_instance.fake_instance_obj(self.context,
                                                   **instance_detail)
        connector = {'ip': 'fake_ip', 'host': 'fake_host'}
        connection_info = {'data': {'access_mode': access_mode}}
        expected_conn_info = {'data': {'access_mode': access_mode},
                              'serial': fake_volume['id']}
        if multiattach and driver_multi_attach:
            expected_conn_info['multiattach'] = True
        enc_data = {'fake': 'enc_data'}

        if include_shared_targets:
            fake_volume['shared_targets'] = True
            fake_volume['service_uuid'] = uuids.service_uuid
            self.volume_api.get.return_value = fake_volume
        else:
            # First call to get() fails because the API isn't new enough.
            # So we fallback to the old call.
            self.volume_api.get.side_effect = [
                exception.CinderAPIVersionNotAvailable(version='3.69'),
                exception.CinderAPIVersionNotAvailable(version='3.48'),
                fake_volume]

        try:
            if fail_check_av_zone:
                self.volume_api.check_availability_zone.side_effect = (
                    test.TestingException())
                # The @update_db decorator will save any changes.
                expected_save_calls.append(mock.call())
                # Exit setting mock
                raise test.TestingException()

            self.virt_driver.get_volume_connector.return_value = connector

            if fail_with_virt_driver:
                expected_save_calls.append(mock.call())
                # Exit setting mock
                raise test.TestingException()

            if self.attachment_id is None:
                self.volume_api.initialize_connection.return_value = (
                    connection_info)
            else:
                self.volume_api.attachment_update.return_value = {
                    'connection_info': connection_info}

            if driver_attach:
                mock_get_encry.return_value = enc_data
                if fail_driver_attach:
                    self.virt_driver.attach_volume.side_effect = (
                        test.TestingException())
                    # The @update_db decorator will save any changes.
                    expected_save_calls.append(mock.call())
                    # Exit setting mock
                    raise test.TestingException()

            if volume_attach:
                # save updates before marking the volume as in-use
                expected_save_calls.append(mock.call())
                if fail_volume_attach:
                    if self.attachment_id is None:
                        self.volume_api.attach.side_effect = (
                            test.TestingException())
                    else:
                        self.volume_api.attachment_complete.side_effect = (
                            test.TestingException())

            # The @update_db decorator will save any changes.
            expected_save_calls.append(mock.call())
        except test.TestingException:
            pass

        if multiattach and fail_with_virt_driver:
            self.assertRaises(exception.MultiattachNotSupportedByVirtDriver,
                              driver_bdm.attach, self.context, instance,
                              self.volume_api, self.virt_driver)
        elif fail_check_av_zone or fail_driver_attach or fail_volume_attach:
            self.assertRaises(test.TestingException, driver_bdm.attach,
                              self.context, instance, self.volume_api,
                              self.virt_driver,
                              do_driver_attach=driver_attach)
        else:
            if wait_func:
                driver_bdm.attach(self.context, instance,
                                  self.volume_api, self.virt_driver,
                                  wait_func)
            else:
                driver_bdm.attach(self.context, instance,
                                  self.volume_api, self.virt_driver,
                                  do_driver_attach=driver_attach)
                self.assertThat(driver_bdm['connection_info'],
                                matchers.DictMatches(expected_conn_info))

        if include_shared_targets:
            self.volume_api.get.assert_called_once_with(
                self.context, fake_volume['id'], microversion='3.69')
        else:
            # First call to get() fails because the API isn't new enough.
            # So we fallback to the old call.
            self.volume_api.get.assert_has_calls([
                mock.call(self.context, fake_volume['id'],
                          microversion='3.69'),
                mock.call(self.context, fake_volume['id'],
                          microversion='3.48'),
                mock.call(self.context, fake_volume['id'],
                          microversion=None)])

        try:
            self.volume_api.check_availability_zone.assert_called_once_with(
                self.context, fake_volume, instance=instance)
            if fail_check_av_zone:
                # Exit assert calls
                raise test.TestingException()

            self.virt_driver.get_volume_connector.assert_called_once_with(
                instance)

            if fail_with_virt_driver:
                raise test.TestingException()

            if self.attachment_id is None:
                self.volume_api.initialize_connection.assert_called_once_with(
                    elevated_context, fake_volume['id'], connector)
            else:
                self.volume_api.attachment_update.assert_called_once_with(
                    elevated_context, self.attachment_id, connector,
                    bdm_dict['device_name'])

            if driver_attach:
                mock_get_encry.assert_called_once_with(
                    elevated_context, self.volume_api, fake_volume['id'],
                    connection_info)
                self.virt_driver.attach_volume.assert_called_once_with(
                    elevated_context, expected_conn_info, instance,
                    bdm_dict['device_name'], disk_bus=bdm_dict['disk_bus'],
                    device_type=bdm_dict['device_type'], encryption=enc_data)
                if fail_driver_attach:
                    if self.attachment_id is None:
                        mock_terminate = self.volume_api.terminate_connection
                        mock_terminate.assert_called_once_with(
                            elevated_context, fake_volume['id'], connector)
                    else:
                        mock_att_delete = self.volume_api.attachment_delete
                        mock_att_delete.assert_called_once_with(
                            elevated_context, self.attachment_id)
                    # Exit assert calls
                    raise test.TestingException()

            if volume_attach:
                if not fail_volume_attach:
                    if self.attachment_id is None:
                        self.volume_api.attach.assert_called_once_with(
                            elevated_context, fake_volume['id'], uuids.uuid,
                            bdm_dict['device_name'], mode=access_mode)
                    else:
                        mock_att_complete = self.volume_api.attachment_complete
                        mock_att_complete.assert_called_once_with(
                            elevated_context, self.attachment_id)
                else:
                    if self.attachment_id is None:
                        self.volume_api.attach.assert_called_once_with(
                            elevated_context, fake_volume['id'], uuids.uuid,
                            bdm_dict['device_name'], mode=access_mode)
                        mock_terminate = self.volume_api.terminate_connection
                        mock_terminate.assert_called_once_with(
                            elevated_context, fake_volume['id'], connector)
                        self.volume_api.detach.assert_called_once_with(
                            elevated_context, fake_volume['id'])
                    else:
                        mock_att_complete = self.volume_api.attachment_complete
                        mock_att_complete.assert_called_once_with(
                            elevated_context, self.attachment_id)
                        mock_att_delete = self.volume_api.attachment_delete
                        mock_att_delete.assert_called_once_with(
                            elevated_context, self.attachment_id)
        except test.TestingException:
            pass

        if expected_save_calls:
            mock_save.assert_has_calls(expected_save_calls)
        return instance.uuid

    def test_volume_attach(self, include_shared_targets=False):
        test_bdm = self.driver_classes['volume'](
            self.volume_bdm)
        volume = {'id': 'fake-volume-id-1',
                  'attach_status': 'detached'}

        self._test_volume_attach(test_bdm, self.volume_bdm, volume,
                                 include_shared_targets=include_shared_targets)

    def test_volume_attach_with_shared_targets(self):
        self.test_volume_attach(include_shared_targets=True)

    def test_volume_attach_ro(self):
        test_bdm = self.driver_classes['volume'](self.volume_bdm)
        volume = {'id': 'fake-volume-id-1',
                  'attach_status': 'detached'}

        self._test_volume_attach(
            test_bdm, self.volume_bdm, volume, access_mode='ro')

    def test_volume_attach_update_size(self):
        test_bdm = self.driver_classes['volume'](self.volume_bdm)
        test_bdm.volume_size = None
        volume = {'id': 'fake-volume-id-1',
                  'attach_status': 'detached',
                  'size': 42}

        self._test_volume_attach(test_bdm, self.volume_bdm, volume)
        self.assertEqual(42, test_bdm.volume_size)

    def test_volume_attach_check_av_zone_fails(self):
        test_bdm = self.driver_classes['volume'](
            self.volume_bdm)
        volume = {'id': 'fake-volume-id-1'}

        self._test_volume_attach(test_bdm, self.volume_bdm, volume,
                                 fail_check_av_zone=True)

    def test_volume_no_volume_attach(self):
        test_bdm = self.driver_classes['volume'](
            self.volume_bdm)
        volume = {'id': 'fake-volume-id-1',
                  'attach_status': 'detached'}

        self._test_volume_attach(test_bdm, self.volume_bdm, volume,
                                 driver_attach=False)

    def test_volume_attach_no_check_driver_attach(self):
        test_bdm = self.driver_classes['volume'](
            self.volume_bdm)
        volume = {'id': 'fake-volume-id-1',
                  'attach_status': 'detached'}

        self._test_volume_attach(test_bdm, self.volume_bdm, volume,
                                 driver_attach=True)

    def test_volume_attach_driver_attach_fails(self):
        test_bdm = self.driver_classes['volume'](
            self.volume_bdm)
        volume = {'id': 'fake-volume-id-1'}

        self._test_volume_attach(test_bdm, self.volume_bdm, volume,
                                 driver_attach=True, fail_driver_attach=True)

    @mock.patch('nova.objects.BlockDeviceMapping.save')
    @mock.patch('nova.volume.cinder.API')
    @mock.patch('os_brick.encryptors.get_encryption_metadata',
                return_value={})
    def test_volume_attach_volume_attach_fails(self, mock_get_encryption,
                                               mock_volume_api, mock_bdm_save):
        """Tests that attaching the volume fails and driver rollback occurs."""
        test_bdm = self.driver_classes['volume'](
            self.volume_bdm)
        volume = {'id': 'fake-volume-id-1',
                  'attach_status': 'detached'}
        mock_volume_api.get.return_value = volume
        instance = fake_instance.fake_instance_obj(self.context)
        virt_driver = fake_virt.SmallFakeDriver(virtapi=mock.MagicMock())

        fake_conn_info = {
            'serial': volume['id'],
            'data': {
                'foo': 'bar'
            }
        }
        if self.attachment_id:
            mock_volume_api.attachment_update.return_value = {
                'connection_info': fake_conn_info
            }
            mock_volume_api.attachment_complete.side_effect = (
                test.TestingException)
        else:
            # legacy flow, stub out the volume_api accordingly
            mock_volume_api.attach.side_effect = test.TestingException
            mock_volume_api.initialize_connection.return_value = fake_conn_info

        with mock.patch.object(virt_driver, 'detach_volume') as drvr_detach:
            with mock.patch.object(self.context, 'elevated',
                                   return_value=self.context):
                self.assertRaises(test.TestingException, test_bdm.attach,
                                  self.context, instance, mock_volume_api,
                                  virt_driver, do_driver_attach=True)

        drvr_detach.assert_called_once_with(
            self.context, fake_conn_info, instance,
            self.volume_bdm.device_name,
            encryption=mock_get_encryption.return_value)

        if self.attachment_id:
            mock_volume_api.attachment_delete.assert_called_once_with(
                self.context, self.attachment_id)
        else:
            mock_volume_api.terminate_connection.assert_called_once_with(
                self.context, volume['id'],
                virt_driver.get_volume_connector(instance))
            mock_volume_api.detach.assert_called_once_with(
                self.context, volume['id'])

        self.assertEqual(2, mock_bdm_save.call_count)

    def test_volume_attach_no_driver_attach_volume_attach_fails(self):
        test_bdm = self.driver_classes['volume'](
            self.volume_bdm)
        volume = {'id': 'fake-volume-id-1',
                  'attach_status': 'detached'}

        self._test_volume_attach(test_bdm, self.volume_bdm, volume,
                                 fail_volume_attach=True)

    @mock.patch.object(objects.BlockDeviceMapping, 'save')
    def test_refresh_connection(self, mock_save):
        test_bdm = self.driver_classes['volsnapshot'](
            self.volsnapshot_bdm)

        instance = {'id': 'fake_id', 'uuid': uuids.uuid}
        connector = {'ip': 'fake_ip', 'host': 'fake_host'}
        connection_info = {'data': {'multipath_id': 'fake_multipath_id'}}
        expected_conn_info = {'data': {'multipath_id': 'fake_multipath_id'},
                              'serial': 'fake-volume-id-2'}

        if self.attachment_id is None:
            self.virt_driver.get_volume_connector.return_value = connector
            self.volume_api.initialize_connection.return_value = (
                connection_info)
        else:
            self.volume_api.attachment_get.return_value = {
                'connection_info': connection_info}

        test_bdm.refresh_connection_info(self.context, instance,
                                         self.volume_api, self.virt_driver)
        self.assertThat(test_bdm['connection_info'],
                        matchers.DictMatches(expected_conn_info))
        if self.attachment_id is None:
            self.virt_driver.get_volume_connector.assert_called_once_with(
                instance)
            self.volume_api.initialize_connection.assert_called_once_with(
                self.context, test_bdm.volume_id, connector)
        else:
            self.volume_api.attachment_get.assert_called_once_with(
                self.context, self.attachment_id)
        mock_save.assert_called_once_with()

    def test_snapshot_attach_no_volume(self):
        no_volume_snapshot = self.volsnapshot_bdm_dict.copy()
        no_volume_snapshot['volume_id'] = None
        test_bdm = self.driver_classes['volsnapshot'](
                fake_block_device.fake_bdm_object(
                        self.context, no_volume_snapshot))
        # Make sure the test didn't already setup an attachment_id on the
        # DriverVolSnapshotBlockDevice that we use to create a new volume.
        self.assertIsNone(test_bdm.get('attachment_id'), test_bdm)

        snapshot = {'id': 'fake-volume-id-1',
                    'attach_status': 'detached'}
        volume = {'id': 'fake-volume-id-2',
                  'attach_status': 'detached'}

        wait_func = mock.MagicMock()
        self.volume_api.get_snapshot.return_value = snapshot
        self.stub_volume_create(volume)

        instance_uuid = self._test_volume_attach(
            test_bdm, no_volume_snapshot, volume, wait_func=wait_func)

        self.assertEqual('fake-volume-id-2', test_bdm.volume_id)
        self.volume_api.get_snapshot.assert_called_once_with(
            self.context, 'fake-snapshot-id-1')
        self.volume_api.create.assert_called_once_with(
            self.context, 3, '', '', availability_zone=None,
            snapshot=snapshot, volume_type=None)
        wait_func.assert_called_once_with(self.context, 'fake-volume-id-2')
        self.volume_api.attachment_create.assert_called_once_with(
            self.context, volume['id'], instance_uuid)
        self.assertEqual(ATTACHMENT_ID, test_bdm.get('attachment_id'))

    def test_snapshot_attach_no_volume_cinder_cross_az_attach_false(self):
        # Tests that the volume created from the snapshot has the same AZ as
        # the instance.
        self.flags(cross_az_attach=False, group='cinder')
        no_volume_snapshot = self.volsnapshot_bdm_dict.copy()
        no_volume_snapshot['volume_id'] = None
        test_bdm = self.driver_classes['volsnapshot'](
                fake_block_device.fake_bdm_object(
                        self.context, no_volume_snapshot))

        snapshot = {'id': 'fake-volume-id-1',
                    'attach_status': 'detached'}
        volume = {'id': 'fake-volume-id-2',
                  'attach_status': 'detached'}

        wait_func = mock.MagicMock()

        self.volume_api.get_snapshot.return_value = snapshot
        self.stub_volume_create(volume)
        self._test_volume_attach(test_bdm, no_volume_snapshot, volume,
                                 availability_zone='test-az',
                                 wait_func=wait_func)

        self.assertEqual('fake-volume-id-2', test_bdm.volume_id)
        self.volume_api.get_snapshot.assert_called_once_with(
            self.context, 'fake-snapshot-id-1')
        self.volume_api.create.assert_called_once_with(
            self.context, 3, '', '', availability_zone='test-az',
            snapshot=snapshot, volume_type=None)
        wait_func.assert_called_once_with(self.context, 'fake-volume-id-2')

    def test_snapshot_attach_fail_volume(self):
        fail_volume_snapshot = self.volsnapshot_bdm_dict.copy()
        fail_volume_snapshot['volume_id'] = None
        test_bdm = self.driver_classes['volsnapshot'](
                fake_block_device.fake_bdm_object(
                        self.context, fail_volume_snapshot))

        snapshot = {'id': 'fake-volume-id-1',
                    'attach_status': 'detached'}
        volume = {'id': 'fake-volume-id-2',
                  'attach_status': 'detached'}

        instance = fake_instance.fake_instance_obj(mock.sentinel.ctx,
                                                   **{'uuid': uuids.uuid})
        self.volume_api.get_snapshot.return_value = snapshot
        self.volume_api.create.return_value = volume
        wait_func = mock.MagicMock()
        mock_exception = exception.VolumeNotCreated(volume_id=volume['id'],
                                                    seconds=1,
                                                    attempts=1,
                                                    volume_status='error')
        wait_func.side_effect = mock_exception
        self.assertRaises(exception.VolumeNotCreated,
                          test_bdm.attach, context=self.context,
                          instance=instance,
                          volume_api=self.volume_api,
                          virt_driver=self.virt_driver,
                          wait_func=wait_func)

        self.volume_api.get_snapshot.assert_called_once_with(
            self.context, 'fake-snapshot-id-1')
        self.volume_api.create.assert_called_once_with(
            self.context, 3, '', '', availability_zone=None,
            snapshot=snapshot, volume_type=None)
        self.volume_api.delete.assert_called_once_with(
            self.context, volume['id'])

    def test_snapshot_attach_volume(self):
        test_bdm = self.driver_classes['volsnapshot'](
            self.volsnapshot_bdm)

        instance = {'id': 'fake_id', 'uuid': uuids.uuid}

        with mock.patch.object(
            self.driver_classes['volume'], 'attach'
        ) as mock_attach:
            test_bdm.attach(self.context, instance, self.volume_api,
                            self.virt_driver)
            self.assertEqual('fake-volume-id-2', test_bdm.volume_id)
            mock_attach.assert_called_once_with(
                self.context, instance, self.volume_api, self.virt_driver)
            # Make sure these are not called
            self.volume_api.get_snapshot.assert_not_called()
            self.volume_api.create.assert_not_called()

    def test_snapshot_attach_no_volume_and_no_volume_type(self):
        bdm = self.driver_classes['volsnapshot'](self.volsnapshot_bdm)
        instance = fake_instance.fake_instance_obj(self.context,
                                                   **{'uuid': uuids.uuid})
        snapshot = {'volume_id': uuids.original_volume_id}
        original_volume = {'id': uuids.original_volume_id,
                           'volume_type_id': 'original_volume_type'}
        new_volume = {'id': uuids.new_volume_id}
        self.volume_api.get_snapshot.return_value = snapshot
        self.volume_api.get.return_value = original_volume
        self.volume_api.create.return_value = new_volume
        with mock.patch.object(self.driver_classes["volume"], "attach"):
            bdm.volume_id = None
            bdm.volume_type = None
            bdm.attach(self.context, instance, self.volume_api,
                       self.virt_driver)

            # Assert that the original volume type is fetched, stored within
            # the bdm and then used to create the new snapshot based volume.
            self.volume_api.get.assert_called_once_with(
                self.context, uuids.original_volume_id)
            self.assertEqual('original_volume_type', bdm.volume_type)
            self.volume_api.create.assert_called_once_with(
                self.context, bdm.volume_size,
                '', '', volume_type='original_volume_type', snapshot=snapshot,
                availability_zone=None)

    def test_image_attach_no_volume(self):
        no_volume_image = self.volimage_bdm_dict.copy()
        no_volume_image['volume_id'] = None
        test_bdm = self.driver_classes['volimage'](
                fake_block_device.fake_bdm_object(
                        self.context, no_volume_image))
        # Make sure the test didn't already setup an attachment_id on the
        # DriverVolImageBlockDevice that we use to create a new volume.
        self.assertIsNone(test_bdm.get('attachment_id'), test_bdm)

        image = {'id': 'fake-image-id-1'}
        volume = {'id': 'fake-volume-id-2',
                  'attach_status': 'detached'}

        wait_func = mock.MagicMock()

        self.stub_volume_create(volume)
        instance_uuid = self._test_volume_attach(
            test_bdm, no_volume_image, volume, wait_func=wait_func)
        self.assertEqual('fake-volume-id-2', test_bdm.volume_id)
        self.volume_api.create.assert_called_once_with(
            self.context, 1, '', '', image_id=image['id'],
            availability_zone=None, volume_type=None)
        wait_func.assert_called_once_with(self.context, 'fake-volume-id-2')
        self.volume_api.attachment_create.assert_called_once_with(
            self.context, volume['id'], instance_uuid)
        self.assertEqual(ATTACHMENT_ID, test_bdm.get('attachment_id'))

    def test_image_attach_no_volume_cinder_cross_az_attach_false(self):
        # Tests that the volume created from the image has the same AZ as the
        # instance.
        self.flags(cross_az_attach=False, group='cinder')
        no_volume_image = self.volimage_bdm_dict.copy()
        no_volume_image['volume_id'] = None
        test_bdm = self.driver_classes['volimage'](
                fake_block_device.fake_bdm_object(
                        self.context, no_volume_image))

        image = {'id': 'fake-image-id-1'}
        volume = {'id': 'fake-volume-id-2',
                  'attach_status': 'detached'}

        wait_func = mock.MagicMock()
        self.stub_volume_create(volume)

        self._test_volume_attach(test_bdm, no_volume_image, volume,
                                 availability_zone='test-az',
                                 wait_func=wait_func)

        self.assertEqual('fake-volume-id-2', test_bdm.volume_id)
        self.volume_api.create.assert_called_once_with(
            self.context, 1, '', '', image_id=image['id'],
            availability_zone='test-az', volume_type=None)
        wait_func.assert_called_once_with(self.context, 'fake-volume-id-2')

    def test_image_attach_fail_volume(self):
        fail_volume_image = self.volimage_bdm_dict.copy()
        fail_volume_image['volume_id'] = None
        test_bdm = self.driver_classes['volimage'](
                fake_block_device.fake_bdm_object(
                        self.context, fail_volume_image))

        image = {'id': 'fake-image-id-1'}
        volume = {'id': 'fake-volume-id-2',
                  'attach_status': 'detached'}

        instance = fake_instance.fake_instance_obj(mock.sentinel.ctx,
                                                   **{'uuid': uuids.uuid})
        self.volume_api.create.return_value = volume
        wait_func = mock.MagicMock()
        mock_exception = exception.VolumeNotCreated(volume_id=volume['id'],
                                                    seconds=1,
                                                    attempts=1,
                                                    volume_status='error')
        wait_func.side_effect = mock_exception
        self.assertRaises(exception.VolumeNotCreated,
                          test_bdm.attach, context=self.context,
                          instance=instance,
                          volume_api=self.volume_api,
                          virt_driver=self.virt_driver,
                          wait_func=wait_func)

        self.volume_api.create.assert_called_once_with(
            self.context, 1, '', '', image_id=image['id'],
            availability_zone=None, volume_type=None)
        self.volume_api.delete.assert_called_once_with(
            self.context, volume['id'])

    def test_image_attach_volume(self):
        test_bdm = self.driver_classes['volimage'](
            self.volimage_bdm)

        instance = {'id': 'fake_id', 'uuid': uuids.uuid}

        with mock.patch.object(
            self.driver_classes['volume'], 'attach'
        ) as mock_attach:
            test_bdm.attach(self.context, instance, self.volume_api,
                            self.virt_driver)
            self.assertEqual('fake-volume-id-2', test_bdm.volume_id)
            mock_attach.assert_called_once_with(
                self.context, instance, self.volume_api, self.virt_driver)
            # Make sure these are not called
            self.volume_api.get_snapshot.assert_not_called()
            self.volume_api.create.assert_not_called()

    def test_blank_attach_fail_volume(self):
        no_blank_volume = self.volblank_bdm_dict.copy()
        no_blank_volume['volume_id'] = None
        test_bdm = self.driver_classes['volblank'](
                fake_block_device.fake_bdm_object(
                        self.context, no_blank_volume))
        instance = fake_instance.fake_instance_obj(mock.sentinel.ctx,
                                                   **{'uuid': uuids.uuid})
        volume = {'id': 'fake-volume-id-2',
                  'display_name': '%s-blank-vol' % uuids.uuid}
        self.volume_api.create.return_value = volume
        wait_func = mock.MagicMock()
        mock_exception = exception.VolumeNotCreated(volume_id=volume['id'],
                                                    seconds=1,
                                                    attempts=1,
                                                    volume_status='error')
        wait_func.side_effect = mock_exception
        self.assertRaises(exception.VolumeNotCreated,
                          test_bdm.attach, context=self.context,
                          instance=instance,
                          volume_api=self.volume_api,
                          virt_driver=self.virt_driver,
                          wait_func=wait_func)

        self.volume_api.create.assert_called_once_with(
            self.context, test_bdm.volume_size,
            '%s-blank-vol' % uuids.uuid,
            '', volume_type=None, availability_zone=None)
        self.volume_api.delete.assert_called_once_with(
            self.context, volume['id'])

    def test_blank_attach_volume(self):
        no_blank_volume = self.volblank_bdm_dict.copy()
        no_blank_volume['volume_id'] = None
        test_bdm = self.driver_classes['volblank'](
                fake_block_device.fake_bdm_object(
                        self.context, no_blank_volume))
        # Make sure the test didn't already setup an attachment_id on the
        # DriverVolBlankBlockDevice that we use to create a new volume.
        self.assertIsNone(test_bdm.get('attachment_id'), test_bdm)
        instance = fake_instance.fake_instance_obj(mock.sentinel.ctx,
                                                   **{'uuid': uuids.uuid})
        volume_class = self.driver_classes['volume']
        volume = {'id': 'fake-volume-id-2',
                  'display_name': '%s-blank-vol' % uuids.uuid}
        self.stub_volume_create(volume)

        with mock.patch.object(volume_class, 'attach') as vol_attach:
            test_bdm.attach(self.context, instance, self.volume_api,
                            self.virt_driver)

            self.volume_api.create.assert_called_once_with(
                self.context, test_bdm.volume_size,
                '%s-blank-vol' % uuids.uuid,
                '', volume_type=None, availability_zone=None)
            vol_attach.assert_called_once_with(self.context, instance,
                                               self.volume_api,
                                               self.virt_driver)
            self.assertEqual('fake-volume-id-2', test_bdm.volume_id)
        self.volume_api.attachment_create.assert_called_once_with(
            self.context, volume['id'], instance.uuid)
        self.assertEqual(ATTACHMENT_ID, test_bdm.get('attachment_id'))

    def test_blank_attach_volume_cinder_cross_az_attach_false(self):
        # Tests that the blank volume created is in the same availability zone
        # as the instance.
        self.flags(cross_az_attach=False, group='cinder')
        no_blank_volume = self.volblank_bdm_dict.copy()
        no_blank_volume['volume_id'] = None
        test_bdm = self.driver_classes['volblank'](
                fake_block_device.fake_bdm_object(
                        self.context, no_blank_volume))
        updates = {'uuid': uuids.uuid, 'availability_zone': 'test-az'}
        instance = fake_instance.fake_instance_obj(mock.sentinel.ctx,
                                                   **updates)
        volume_class = self.driver_classes['volume']
        volume = {'id': 'fake-volume-id-2',
                  'display_name': '%s-blank-vol' % uuids.uuid}
        self.stub_volume_create(volume)

        with mock.patch.object(volume_class, 'attach') as vol_attach:
            test_bdm.attach(self.context, instance, self.volume_api,
                            self.virt_driver)

            self.volume_api.create.assert_called_once_with(
                self.context, test_bdm.volume_size,
                '%s-blank-vol' % uuids.uuid,
                '', volume_type=None, availability_zone='test-az')
            vol_attach.assert_called_once_with(self.context, instance,
                                               self.volume_api,
                                               self.virt_driver)
            self.assertEqual('fake-volume-id-2', test_bdm.volume_id)

    def test_convert_block_devices(self):
        bdms = objects.BlockDeviceMappingList(
                objects=[self.volume_bdm, self.ephemeral_bdm])
        converted = driver_block_device._convert_block_devices(
            self.driver_classes['volume'], bdms)
        self.assertEqual(converted, [self.volume_driver_bdm])

    def test_convert_all_volumes(self):
        converted = driver_block_device.convert_all_volumes()
        self.assertEqual([], converted)

        converted = driver_block_device.convert_all_volumes(
            self.volume_bdm, self.ephemeral_bdm, self.volimage_bdm,
            self.volblank_bdm, self.volsnapshot_bdm)
        self.assertEqual(converted, [self.volume_driver_bdm,
                                     self.volimage_driver_bdm,
                                     self.volblank_driver_bdm,
                                     self.volsnapshot_driver_bdm])

    def test_convert_volume(self):
        self.assertIsNone(driver_block_device.convert_volume(self.swap_bdm))
        self.assertEqual(self.volume_driver_bdm,
                         driver_block_device.convert_volume(self.volume_bdm))
        self.assertEqual(self.volsnapshot_driver_bdm,
                         driver_block_device.convert_volume(
                             self.volsnapshot_bdm))

    def test_convert_volume_without_connection_info(self):
        self.assertEqual(self.volume_driver_bdm_without_conn_info,
                         driver_block_device.convert_volume(
                             self.volume_bdm_without_conn_info))

    def test_get_swap(self):
        swap = [self.swap_driver_bdm]
        no_swap = [self.volume_driver_bdm]

        self.assertEqual(swap[0], driver_block_device.get_swap(swap))
        self.assertIsNone(driver_block_device.get_swap(no_swap))
        self.assertIsNone(driver_block_device.get_swap([]))

    def test_is_implemented(self):
        for bdm in (self.volimage_bdm, self.volume_bdm, self.swap_bdm,
                    self.ephemeral_bdm, self.volsnapshot_bdm, self.image_bdm):
            self.assertTrue(driver_block_device.is_implemented(bdm))

    def test_is_block_device_mapping(self):
        test_swap = self.driver_classes['swap'](self.swap_bdm)
        test_ephemeral = self.driver_classes['ephemeral'](self.ephemeral_bdm)
        test_image = self.driver_classes['volimage'](self.volimage_bdm)
        test_snapshot = self.driver_classes['volsnapshot'](
                self.volsnapshot_bdm)
        test_volume = self.driver_classes['volume'](self.volume_bdm)
        test_blank = self.driver_classes['volblank'](self.volblank_bdm)

        for bdm in (test_image, test_snapshot, test_volume, test_blank):
            self.assertTrue(driver_block_device.is_block_device_mapping(
                bdm._bdm_obj))

        for bdm in (test_swap, test_ephemeral):
            self.assertFalse(driver_block_device.is_block_device_mapping(
                bdm._bdm_obj))

    def test_get_volume_create_az_cinder_cross_az_attach_true(self):
        # Tests  that we get None back if cinder.cross_az_attach=True even if
        # the instance has an AZ assigned. Note that since cross_az_attach
        # defaults to True we don't need to set a flag explicitly for the test.
        updates = {'availability_zone': 'test-az'}
        instance = fake_instance.fake_instance_obj(self.context, **updates)
        self.assertIsNone(
            driver_block_device._get_volume_create_az_value(instance))

    def test_refresh_conn_infos(self):
        # Only DriverVolumeBlockDevice derived devices should refresh their
        # connection_info during a refresh_conn_infos call.
        test_volume = mock.MagicMock(
            spec=driver_block_device.DriverVolumeBlockDevice)
        test_image = mock.MagicMock(
            spec=driver_block_device.DriverVolImageBlockDevice)
        test_snapshot = mock.MagicMock(
            spec=driver_block_device.DriverVolSnapshotBlockDevice)
        test_blank = mock.MagicMock(
            spec=driver_block_device.DriverVolBlankBlockDevice)
        test_eph = mock.MagicMock(
            spec=driver_block_device.DriverEphemeralBlockDevice)
        test_swap = mock.MagicMock(
            spec=driver_block_device.DriverSwapBlockDevice)
        block_device_mapping = [test_volume, test_image, test_eph,
                                test_snapshot, test_swap, test_blank]
        driver_block_device.refresh_conn_infos(block_device_mapping,
                                               mock.sentinel.refresh_context,
                                               mock.sentinel.refresh_instance,
                                               mock.sentinel.refresh_vol_api,
                                               mock.sentinel.refresh_virt_drv)
        for test_mock in [test_volume, test_image, test_snapshot, test_blank]:
            test_mock.refresh_connection_info.assert_called_once_with(
                mock.sentinel.refresh_context,
                mock.sentinel.refresh_instance,
                mock.sentinel.refresh_vol_api,
                mock.sentinel.refresh_virt_drv)
        # NOTE(lyarwood): Can't think of a better way of testing this as we
        # can't assert_not_called if the method isn't in the spec.
        self.assertFalse(hasattr(test_eph, 'refresh_connection_info'))
        self.assertFalse(hasattr(test_swap, 'refresh_connection_info'))

    def test_proxy_as_attr(self):
        class A(driver_block_device.DriverBlockDevice):
            pass

            def _transform(self):
                pass

        class B(A):
            _proxy_as_attr_inherited = set('B')

        class C(A):
            _proxy_as_attr_inherited = set('C')

        class D(B):
            _proxy_as_attr_inherited = set('D')

        class E(B, C):
            _proxy_as_attr_inherited = set('E')

        bdm = objects.BlockDeviceMapping(self.context, no_device=False)
        self.assertEqual(set(['uuid', 'is_volume']), A(bdm)._proxy_as_attr)
        self.assertEqual(set(['uuid', 'is_volume', 'B']),
                         B(bdm)._proxy_as_attr)
        self.assertEqual(set(['uuid', 'is_volume', 'C']),
                         C(bdm)._proxy_as_attr)
        self.assertEqual(set(['uuid', 'is_volume', 'B', 'D']),
                         D(bdm)._proxy_as_attr)
        self.assertEqual(set(['uuid', 'is_volume', 'B', 'C', 'E']),
                         E(bdm)._proxy_as_attr)

    def _test_boot_from_volume_source_blank_volume_type(
            self, bdm, expected_volume_type):
        self.flags(cross_az_attach=False, group='cinder')
        test_bdm = self.driver_classes['volblank'](bdm)
        updates = {'uuid': uuids.uuid, 'availability_zone': 'test-az'}
        instance = fake_instance.fake_instance_obj(mock.sentinel.ctx,
                                                   **updates)
        volume_class = self.driver_classes['volume']
        volume = {'id': 'fake-volume-id-2',
                  'display_name': '%s-blank-vol' % uuids.uuid}
        self.stub_volume_create(volume)

        with mock.patch.object(volume_class, 'attach') as vol_attach:
            test_bdm.attach(self.context, instance, self.volume_api,
                            self.virt_driver)

            self.volume_api.create.assert_called_once_with(
                self.context, test_bdm.volume_size,
                '%s-blank-vol' % uuids.uuid, '',
                volume_type=expected_volume_type,
                availability_zone='test-az')
            vol_attach.assert_called_once_with(
                self.context, instance, self.volume_api, self.virt_driver)
            self.assertEqual('fake-volume-id-2', test_bdm.volume_id)

    def test_boot_from_volume_source_blank_with_unset_volume_type(self):
        """Tests the scenario that the BlockDeviceMapping.volume_type field
        is unset for RPC compatibility to an older compute.
        """
        no_blank_volume = self.volblank_bdm_dict.copy()
        no_blank_volume['volume_id'] = None
        bdm = fake_block_device.fake_bdm_object(self.context, no_blank_volume)
        delattr(bdm, 'volume_type')
        self.assertNotIn('volume_type', bdm)
        self._test_boot_from_volume_source_blank_volume_type(bdm, None)

    def test_boot_from_volume_source_blank_with_volume_type(self):
        # Tests that the blank volume created specifies the volume type.
        no_blank_volume = self.volblank_bdm_dict.copy()
        no_blank_volume['volume_id'] = None
        no_blank_volume['volume_type'] = 'fake-lvm-1'
        bdm = fake_block_device.fake_bdm_object(self.context, no_blank_volume)
        self._test_boot_from_volume_source_blank_volume_type(bdm, 'fake-lvm-1')

    def _test_boot_from_volume_source_image_volume_type(
            self, bdm, expected_volume_type):
        self.flags(cross_az_attach=False, group='cinder')
        test_bdm = self.driver_classes['volimage'](bdm)

        updates = {'uuid': uuids.uuid, 'availability_zone': 'test-az'}
        instance = fake_instance.fake_instance_obj(mock.sentinel.ctx,
                                                   **updates)
        volume_class = self.driver_classes['volume']
        image = {'id': 'fake-image-id-1'}
        volume = {'id': 'fake-volume-id-2',
                  'display_name': 'fake-image-vol'}
        self.stub_volume_create(volume)

        with mock.patch.object(volume_class, 'attach') as vol_attach:
            test_bdm.attach(self.context, instance, self.volume_api,
                            self.virt_driver)

            self.volume_api.create.assert_called_once_with(
                self.context, test_bdm.volume_size,
                '', '', image_id=image['id'],
                volume_type=expected_volume_type,
                availability_zone='test-az')
            vol_attach.assert_called_once_with(
                self.context, instance, self.volume_api, self.virt_driver)
            self.assertEqual('fake-volume-id-2', test_bdm.volume_id)

    def test_boot_from_volume_source_image_with_unset_volume_type(self):
        """Tests the scenario that the BlockDeviceMapping.volume_type field
        is unset for RPC compatibility to an older compute.
        """
        no_volume_image = self.volimage_bdm_dict.copy()
        no_volume_image['volume_id'] = None
        bdm = fake_block_device.fake_bdm_object(self.context, no_volume_image)
        delattr(bdm, 'volume_type')
        self.assertNotIn('volume_type', bdm)
        self._test_boot_from_volume_source_image_volume_type(bdm, None)

    def test_boot_from_volume_source_image_with_volume_type(self):
        # Tests that the volume created from the image specifies the volume
        # type.
        no_volume_image = self.volimage_bdm_dict.copy()
        no_volume_image['volume_id'] = None
        no_volume_image['volume_type'] = 'fake-lvm-1'
        bdm = fake_block_device.fake_bdm_object(self.context, no_volume_image)
        self._test_boot_from_volume_source_image_volume_type(bdm, 'fake-lvm-1')

    def _test_boot_from_volume_source_snapshot_volume_type(
            self, bdm, expected_volume_type):
        self.flags(cross_az_attach=False, group='cinder')
        test_bdm = self.driver_classes['volsnapshot'](bdm)

        snapshot = {'id': 'fake-snapshot-id-1',
                    'attach_status': 'detached'}

        updates = {'uuid': uuids.uuid, 'availability_zone': 'test-az'}
        instance = fake_instance.fake_instance_obj(mock.sentinel.ctx,
                                                   **updates)
        volume_class = self.driver_classes['volume']
        volume = {'id': 'fake-volume-id-2',
                  'display_name': 'fake-snapshot-vol'}
        self.stub_volume_create(volume)

        self.volume_api.get_snapshot.return_value = snapshot

        with mock.patch.object(volume_class, 'attach') as vol_attach:
            test_bdm.attach(self.context, instance, self.volume_api,
                            self.virt_driver)

            self.volume_api.create.assert_called_once_with(
                self.context, test_bdm.volume_size, '', '',
                availability_zone='test-az', snapshot=snapshot,
                volume_type=expected_volume_type)
            vol_attach.assert_called_once_with(
                self.context, instance, self.volume_api, self.virt_driver)
            self.assertEqual('fake-volume-id-2', test_bdm.volume_id)

    def test_boot_from_volume_source_snapshot_with_unset_volume_type(self):
        """Tests the scenario that the BlockDeviceMapping.volume_type field
        is unset for RPC compatibility to an older compute.
        """
        no_volume_snapshot = self.volsnapshot_bdm_dict.copy()
        no_volume_snapshot['volume_id'] = None
        bdm = fake_block_device.fake_bdm_object(
            self.context, no_volume_snapshot)
        delattr(bdm, 'volume_type')
        self.assertNotIn('volume_type', bdm)
        self._test_boot_from_volume_source_snapshot_volume_type(bdm, None)

    def test_boot_from_volume_source_snapshot_with_volume_type(self):
        # Tests that the volume created from the snapshot specifies the volume
        # type.
        no_volume_snapshot = self.volsnapshot_bdm_dict.copy()
        no_volume_snapshot['volume_id'] = None
        no_volume_snapshot['volume_type'] = 'fake-lvm-1'
        bdm = fake_block_device.fake_bdm_object(
            self.context, no_volume_snapshot)
        self._test_boot_from_volume_source_snapshot_volume_type(
            bdm, 'fake-lvm-1')

    @ddt.data(['3.69'], ['3.69', '3.48'], ['3.69', '3.48', None])
    def test__get_volume(self, microversions):
        volume_api = mock.Mock()
        exp = mock.Mock()
        exc = exception.CinderAPIVersionNotAvailable
        side_effect = [exc(version=mv) for mv in microversions[:-1]] + [exp]
        volume_api.get.side_effect = side_effect

        res = self.driver_classes['volume']._get_volume(
            self.context, volume_api, mock.sentinel.volume_id)

        self.assertEqual(exp, res)

        self.assertEqual(len(microversions), volume_api.get.call_count)
        volume_api.get.assert_has_calls(
            [mock.call(self.context, mock.sentinel.volume_id, microversion=mv)
             for mv in microversions])


class TestDriverBlockDeviceNewFlow(TestDriverBlockDevice):
    """Virt block_device tests for the Cinder 3.44 volume attach flow
    where a volume BDM has an attachment_id.
    """
    attachment_id = ATTACHMENT_ID

    def test_volume_attach_multiattach(self):
        test_bdm = self.driver_classes['volume'](
            self.volume_bdm)
        volume = {'id': 'fake-volume-id-1',
                  'multiattach': True,
                  'attach_status': 'attached',
                  'status': 'in-use',
                  'attachments': {'fake_instance_2':
                                  {'mountpoint': '/dev/vdc'}}}

        self._test_volume_attach(test_bdm, self.volume_bdm, volume,
                                 multiattach=True, driver_multi_attach=True)

    def test_volume_attach_multiattach_no_virt_driver_support(self):
        test_bdm = self.driver_classes['volume'](
            self.volume_bdm)
        volume = {'id': 'fake-volume-id-1',
                  'multiattach': True,
                  'attach_status': 'attached',
                  'status': 'in-use',
                  'attachments': {'fake_instance_2':
                                  {'mountpoint': '/dev/vdc'}}}

        self._test_volume_attach(test_bdm, self.volume_bdm,
                                 volume, multiattach=True,
                                 fail_with_virt_driver=True)

    @mock.patch('nova.objects.BlockDeviceMapping.save')
    def test_refresh_connection_preserve_multiattach(self, mock_bdm_save):
        """Tests that we've already attached a multiattach-capable volume
        and when refreshing the connection_info from the attachment record,
        the multiattach flag in the bdm.connection_info is preserved.
        """
        test_bdm = self.driver_classes['volume'](self.volume_bdm)
        test_bdm['connection_info']['multiattach'] = True
        volume_api = mock.Mock()
        volume_api.attachment_get.return_value = {
            'connection_info': {
                'data': {
                    'some': 'goodies'
                }
            }
        }

        test_bdm.refresh_connection_info(
            self.context, mock.sentinel.instance,
            volume_api, mock.sentinel.virt_driver)
        volume_api.attachment_get.assert_called_once_with(
            self.context, self.attachment_id)
        mock_bdm_save.assert_called_once_with()
        expected_connection_info = {
            'data': {
                'some': 'goodies'
            },
            'serial': self.volume_bdm.volume_id,
            'multiattach': True
        }
        self.assertDictEqual(expected_connection_info,
                             test_bdm['connection_info'])


class TestGetVolumeId(test.NoDBTestCase):

    def test_get_volume_id_none_found(self):
        self.assertIsNone(driver_block_device.get_volume_id(None))
        self.assertIsNone(driver_block_device.get_volume_id({}))
        self.assertIsNone(driver_block_device.get_volume_id({'data': {}}))

    def test_get_volume_id_found_volume_id_no_serial(self):
        self.assertEqual(uuids.volume_id,
                         driver_block_device.get_volume_id(
                             {'data': {'volume_id': uuids.volume_id}}))

    def test_get_volume_id_found_no_volume_id_serial(self):
        self.assertEqual(uuids.serial,
                         driver_block_device.get_volume_id(
                             {'serial': uuids.serial}))

    def test_get_volume_id_found_both(self):
        # volume_id is taken over serial
        self.assertEqual(uuids.volume_id,
                         driver_block_device.get_volume_id(
                             {'serial': uuids.serial,
                              'data': {'volume_id': uuids.volume_id}}))
